From patchwork Fri Aug 13 13:49:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 496565 Delivered-To: patch@linaro.org Received: by 2002:a02:cf8a:0:0:0:0:0 with SMTP id w10csp585338jar; Fri, 13 Aug 2021 06:54:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWotlxwxRxH93hnY7BBfks+uJEpqg+5UavXdQtbvB4HOs1HxTSsHgajBv2NFZN/6eNy6Bn X-Received: by 2002:a17:906:4a51:: with SMTP id a17mr2517198ejv.435.1628862854610; Fri, 13 Aug 2021 06:54:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628862854; cv=none; d=google.com; s=arc-20160816; b=TUu3YPrDKbLa6M8OuOzNGgbDzNu7iBYr6bOz6qGt6bHhmFrRBX5uClFF8JSVHOV9Mk T99Lg9dN057j5Y1m5buoTD2YRCCDg/T+oOjpaAlsoFIjMkfQDlJRCn0B+Nn/hfrNYfbK lFzhj+3gIPD6PJmtlFiRYpFwkBS7UgXaN98VaQGs2WDpwQ49v0/GbV66TKOcGtjmM0wq PRBPqe84XBOQG3TYbD872GKW6oGF0/9biob6MmoAOzBk2nn2zY4Jz/jbIjR32afaMoOA 9/TkswNofDB7hc0tJWPSIg4GuLPbl5FH/QPQScee3ulb2VrRlhLN3Dxjt9S/rRP1NIZG GAJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=aUDtlGi3kW5PjimkWmIWUVsfjpe7bJQtlrvZYOmJzQY=; b=BHBauvybPK37Z+dqf5XmjnmVYHdiwnvg3zGx1kU4uRaZuLII6H2EjcwyIIule8gsVt icasScHpD4cwYNG96FyW3Tt2c2AgmIYETchLCrAlvsn4EnsFLn8vs+S0Oswt0jnJYzCD 15VEWOtlYr1lPzWDYhQ800Skt6eY2TY413lP3fNRXfxZMDioSI3/uqN6LBvSBUyUvo8P 5P8WnudgOY3nWDZCVnQ6DH3aHQcXYbqkruOFIk4p1/A3y7ngH4nZSkHr8p0zwmTHXCJw f77O4MTsaCPD4ZL9yWQ/TQELqpckE6Wr3yVkopzly0CglLCwKbnEbUYGvUYgzmKTf1Sb XCuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq6si1764414ejc.589.2021.08.13.06.54.14 for ; Fri, 13 Aug 2021 06:54:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240763AbhHMNyj (ORCPT ); Fri, 13 Aug 2021 09:54:39 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3648 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240753AbhHMNyh (ORCPT ); Fri, 13 Aug 2021 09:54:37 -0400 Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GmQ4p5mwHz6GDFx; Fri, 13 Aug 2021 21:53:30 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 13 Aug 2021 15:54:08 +0200 Received: from localhost.localdomain (10.69.192.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 14:54:06 +0100 From: John Garry To: , , , , CC: , , , , , John Garry Subject: [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag Date: Fri, 13 Aug 2021 21:49:12 +0800 Message-ID: <1628862553-179450-3-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1628862553-179450-1-git-send-email-john.garry@huawei.com> References: <1628862553-179450-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org It is never read. Setting it and the request tag seems dodgy anyway. Signed-off-by: John Garry --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2 Reviewed-by: Hannes Reinecke Reviewed-by: Bart Van Assche diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 0f9cedf78872..f8afbfb468dc 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -2213,7 +2213,7 @@ fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc) if (IS_ERR(dummy)) return SCSI_NO_TAG; - sc->tag = rq->tag = dummy->tag; + rq->tag = dummy->tag; sc->host_scribble = (unsigned char *)dummy; return dummy->tag;