From patchwork Fri Aug 13 13:49:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 496566 Delivered-To: patch@linaro.org Received: by 2002:a02:cf8a:0:0:0:0:0 with SMTP id w10csp585398jar; Fri, 13 Aug 2021 06:54:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywr1i6Q2jPxBBJotkFW//sv5RyNOL2fdyyuzOL7/i9LWc8gN6SjLG0IPliB7S9VxI0b0q8 X-Received: by 2002:a17:906:b0d1:: with SMTP id bk17mr2558037ejb.59.1628862858341; Fri, 13 Aug 2021 06:54:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628862858; cv=none; d=google.com; s=arc-20160816; b=0oRv7SXq9XGe1ZSsmbLUGoCkIT7ihV7RqXd9879VBIhdIQeq0Cyv/CSVAyDPDLxRPP hdjUxT/2mS8YQ2tGlqqOng4fOQyeDkR+X/tef1myKoRCE7S6RxRmIcMMZgQJfLXZaBdm sNJYD3/2LLgEmqRmzdAd+c7kgFUMQGxOycCZhuHmB8fjvcD86+ndnRSAysLeL9dSwsbJ +puELB8BfSmQKSUPVzWyoCbtKPgE9USMewWq2pRM/FzXPVzNScmCQqAep8Is/klgL1vM I6/QEEPP5zIbHUbtCAyvplI76FGu25KcqpZFHaKTRgXRETJti/Gn4NDYoCiWW8VbFIOS uLkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ouYD2uzqHwhOw9HjkxPBeYRFEny971PJHszhpTZS0YA=; b=T1XlU3YyiDLi4eUGfOdQ58TiZUI7gReJNfLGY5j1gaNTsj1gNtYr0lTF3kpsYcI4N7 na6587Y5MaE3jJzhfLrnvDULq8sI4cvCfdVDI02oH+dy51ux9oflSdvS6/lDv3wvayE+ 4f9rg5zr6Xbdud1ywabn7dI+xJ0huOh+zxmSUlVTgE+UHein3XPI48FYA6+xl8nggu1a yIDwWAYDHTuuaTZy2+oHSEbfA5wCZvZ8srHtQIR1Xtv2iR1dHeOuQTpIydOj2SLHn4Ps d2Jag20wuMYyI60gg1I6TcUIpgx8G4gqrh0nGbRdyvN9k4YIlA/sc6WvOkTvdUqcmu1N P3xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq6si1764414ejc.589.2021.08.13.06.54.18 for ; Fri, 13 Aug 2021 06:54:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240785AbhHMNyn (ORCPT ); Fri, 13 Aug 2021 09:54:43 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3649 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240762AbhHMNyj (ORCPT ); Fri, 13 Aug 2021 09:54:39 -0400 Received: from fraeml735-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GmQ4m5BBYz6D8Vt; Fri, 13 Aug 2021 21:53:28 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml735-chm.china.huawei.com (10.206.15.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 13 Aug 2021 15:54:11 +0200 Received: from localhost.localdomain (10.69.192.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 14:54:08 +0100 From: John Garry To: , , , , CC: , , , , , John Garry Subject: [PATCH 3/3] scsi: Remove scsi_cmnd.tag Date: Fri, 13 Aug 2021 21:49:13 +0800 Message-ID: <1628862553-179450-4-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1628862553-179450-1-git-send-email-john.garry@huawei.com> References: <1628862553-179450-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org It is never read, so get rid of it. Signed-off-by: John Garry --- drivers/scsi/scsi_lib.c | 1 - include/scsi/scsi_cmnd.h | 1 - 2 files changed, 2 deletions(-) -- 2.26.2 Reviewed-by: Hannes Reinecke Reviewed-by: Bart Van Assche diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 9ba1aa7530a9..572673873ddf 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1540,7 +1540,6 @@ static blk_status_t scsi_prepare_cmd(struct request *req) scsi_init_command(sdev, cmd); - cmd->tag = req->tag; cmd->prot_op = SCSI_PROT_NORMAL; if (blk_rq_bytes(req)) cmd->sc_data_direction = rq_dma_dir(req); diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index 6c5a1c1c6b1e..eaf04c9a1dfc 100644 --- a/include/scsi/scsi_cmnd.h +++ b/include/scsi/scsi_cmnd.h @@ -139,7 +139,6 @@ struct scsi_cmnd { int flags; /* Command flags */ unsigned long state; /* Command completion state */ - unsigned char tag; /* SCSI-II queued command tag */ unsigned int extra_len; /* length of alignment and padding */ };