From patchwork Thu Jul 9 17:45:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235165 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1631472ilg; Thu, 9 Jul 2020 10:46:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWlPwJ71S/46Kbdox8Fsw0ojIBsGzhfeWzuxQiNXK+sli4enaPhaHLinkj5DEYM/uB37nA X-Received: by 2002:a17:906:1414:: with SMTP id p20mr56340498ejc.247.1594316769867; Thu, 09 Jul 2020 10:46:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594316769; cv=none; d=google.com; s=arc-20160816; b=e3f/XBj/8upMTDZqQLyseFA2LygGWikPKCl8agKp6GlF2VQmQuv6uPAVZWeaePEVYJ RONKK7Bsi1i9R+PZ6xB78GzjCUjLS+CfHBy22U302Q+lwIXF0ILhF2Xkcn29qH/fDHdX IQ4AZGParxF1s2G0FV7t3zm0EbN0B0oOR+XPitj/6wGtJAyLk+LHjp2QK3pX2/rh63/I my511pqJbDEL0COxUE+6wMEutGKi1eCd4+0GaP2kXectR5m1m9Zcv+NhJDDOQ7impECy y5eSplQ8BBp8VTvsIdgjPQZTu04RYgSiSlGlXdZ2rmKZgeiyBTVtpy4QB3bWNypt7SXS ASDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RfY0NWdcaY2EP3FmoORbq4kbjZDAFhNLFjss0f92Lio=; b=Y6gr46TSgGg2UvjEjAFcsR7eq8NdwW72yUaO5dPgOHAFxPHMKMjKZeKt9rdxh3kG1O 806w7zkKlC1mf7Ss1DfAPI1sUc9we+p6obcxHnSs3tZ2DFtr8gj06V1Ltk4RhgNsFAjR 6pTu1ECcD6jaJg0mrzmnbG5iqeShWAz/xf6jm5GjGaKaqAUGO3varXcdnv0ofoDOeX/c W/YrCHtztMaY82WOtgq69kVBUmQHHPdRiLsThwuQjZqIaJgCUsOQfHjcLlSt7HeRgV7I 8K2cY5MFqSMqHuALGR30K/PklpChRKqOZh+zZIve/PtQEIaHpaaZcnlIJIX3wh4nSL+j hjUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fxWsWdjx; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn22si2359666edb.477.2020.07.09.10.46.09 for ; Thu, 09 Jul 2020 10:46:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fxWsWdjx; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728500AbgGIRqI (ORCPT ); Thu, 9 Jul 2020 13:46:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728467AbgGIRqH (ORCPT ); Thu, 9 Jul 2020 13:46:07 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92F8CC08C5DC for ; Thu, 9 Jul 2020 10:46:06 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id a6so3294597wrm.4 for ; Thu, 09 Jul 2020 10:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RfY0NWdcaY2EP3FmoORbq4kbjZDAFhNLFjss0f92Lio=; b=fxWsWdjxXCwYott0gwgsFWwu5RCZefGZ1QnMRJoPwCA+hqDDEzcF8/6f0mKUo1F9/w 9aSvsMy5bvmp0jd9N811D9npGUzRIswp5G7SK53qrJKSLF0UAM+V1q/xC913sG7b8Yp6 XEYnpj0FfTzqoeimcjzOj2zh9hRAEABgNgSgdAn4mulh2p1JNXQAlg4ZDHDrTxNA4Q5x Tjm3aCwmNIijd/mgkXCE0JhiUrp+SIa/AY0vSeB9wxWve8maNPXTM5yogbCn06YxmZyM b5WR984aWLaXU/vO8p2D4knaliVQEuLcxMlDlwbf3EgbjlLXxMTPdIA4QuPU5TqPm1Ko yNoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RfY0NWdcaY2EP3FmoORbq4kbjZDAFhNLFjss0f92Lio=; b=pV3zRmzzMnHNdD2/irb28oeZO0D1tpQ9lZaun0/ogmJm+btLUNXJ0MnoijSYY0eb9g FPjzOVMyylrXpmlWEhn+372SLNpvYd3kB7xcoILTSbBBa3MxJkD6AxnAuoO6nsxmpz8h zXB1GcAhm41g9sY85UR2kPA9rLQaaZIibIeT65lsmcAD8b1J6/IEkIIpYR/XrP5+bTNR 9bjQ3hhyqVSx9LsZaDhqJhpf79Cox5HvP5vHtBmXp1m295I0Ii51pVfUf5Qi0iYg+HjZ 6YGWzs93KH2GcGa2KzlN5FnmDE9l7h2AmitHb26VhCsyC01NirHO48JzO/FkuMl5RWAA PSyA== X-Gm-Message-State: AOAM532EkRqGu2tniFvfhnU3SDxwWNlQU2GbADP7rdHUxgV1mZ4Et1mP MX3xI60xTdwsLfqd3strGuQbDQ== X-Received: by 2002:adf:e3c5:: with SMTP id k5mr64956020wrm.121.1594316765343; Thu, 09 Jul 2020 10:46:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id f15sm6063854wrx.91.2020.07.09.10.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 10:46:04 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Luben Tuikov Subject: [PATCH 06/24] scsi: aic94xx: aic94xx_seq: Document 'lseq' and repair asd_update_port_links() header Date: Thu, 9 Jul 2020 18:45:38 +0100 Message-Id: <20200709174556.7651-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200709174556.7651-1-lee.jones@linaro.org> References: <20200709174556.7651-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_seq.c:587: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_mip' drivers/scsi/aic94xx/aic94xx_seq.c:674: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_mdp' drivers/scsi/aic94xx/aic94xx_seq.c:958: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_cio' drivers/scsi/aic94xx/aic94xx_seq.c:1364: warning: Function parameter or member 'asd_ha' not described in 'asd_update_port_links' drivers/scsi/aic94xx/aic94xx_seq.c:1364: warning: Function parameter or member 'phy' not described in 'asd_update_port_links' drivers/scsi/aic94xx/aic94xx_seq.c:1364: warning: Excess function parameter 'sas_phy' description in 'asd_update_port_links' Cc: Luben Tuikov Signed-off-by: Lee Jones --- drivers/scsi/aic94xx/aic94xx_seq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c index 11853ec29d87a..c0f685c86851b 100644 --- a/drivers/scsi/aic94xx/aic94xx_seq.c +++ b/drivers/scsi/aic94xx/aic94xx_seq.c @@ -582,6 +582,7 @@ static void asd_init_cseq_scratch(struct asd_ha_struct *asd_ha) /** * asd_init_lseq_mip -- initialize LSEQ Mode independent pages 0-3 * @asd_ha: pointer to host adapter structure + * @lseq: link sequencer */ static void asd_init_lseq_mip(struct asd_ha_struct *asd_ha, u8 lseq) { @@ -669,6 +670,7 @@ static void asd_init_lseq_mip(struct asd_ha_struct *asd_ha, u8 lseq) /** * asd_init_lseq_mdp -- initialize LSEQ mode dependent pages. * @asd_ha: pointer to host adapter structure + * @lseq: link sequencer */ static void asd_init_lseq_mdp(struct asd_ha_struct *asd_ha, int lseq) { @@ -953,6 +955,7 @@ static void asd_init_cseq_cio(struct asd_ha_struct *asd_ha) /** * asd_init_lseq_cio -- initialize LmSEQ CIO registers * @asd_ha: pointer to host adapter structure + * @lseq: link sequencer */ static void asd_init_lseq_cio(struct asd_ha_struct *asd_ha, int lseq) { @@ -1345,7 +1348,8 @@ int asd_start_seqs(struct asd_ha_struct *asd_ha) /** * asd_update_port_links -- update port_map_by_links and phy_is_up - * @sas_phy: pointer to the phy which has been added to a port + * @asd_ha: pointer to host adapter structure + * @phy: pointer to the phy which has been added to a port * * 1) When a link reset has completed and we got BYTES DMAED with a * valid frame we call this function for that phy, to indicate that