From patchwork Thu Jul 9 17:45:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235183 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1632537ilg; Thu, 9 Jul 2020 10:47:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNrablmGFr4b5jDpYwMPnG+5j0DQncZb4CpNaJ0Maybo2WKOrFbVtrJ/mltF/wxMtAaW18 X-Received: by 2002:a17:906:38da:: with SMTP id r26mr55798405ejd.120.1594316854025; Thu, 09 Jul 2020 10:47:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594316854; cv=none; d=google.com; s=arc-20160816; b=sUqzQEE6H647lGF9Jw8jwShedIHrf/DV0asQYs2+aeTaljYh15WYUWmnVChngBQORU du171aWF1MjegKTBdWwd8t2wL5TXiA817J4+COW2Cv7V7MwmvfMyFd+BWwThgJ8gNVkY heNnT7AjvMYYZwrcSNnA88ckbeK/ZgSILDrQjVUpprp1ygIAZAaMHT9bjzC1LSweOcYy 2qG5lE/ls7hTqvMiXVCZVz1XpHPjJZyGFdWmiyo1VO+xECGOLOyTv36cKBWHKe655Vui mJ+Y9BDrkbsyXd7NixveSsAwIw+XXT60g8gxqtGftBcl3hwsyz2aI0KPEFWS5E2GeDXd i/Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kZ+k2VRrvfDu4ASYD2+0hveDy1rv8dVhxsnPb7NP+X0=; b=kASn+sIhP8SuZI8//LNKnnNmOBjCQnTcqFD9btJ91q4R+Xijop9ID7G3RPTFW2QT82 uGp3uHw8cHdwXRbYYNyXemeknuASz54p0uKoUZeqojWa4w6aayL+SGGYOZ4dk+PSVCsC ZQW/FD76hWsQZaKMHYSHt+5B5xUVyv/y3+0wr2FLojcX2zx+9tyGHnEzr4z8Gk/HkNih OJBkicX2O80idqR7y6+bA8Kki4H3hL/s2mtF6lSZnxAVS66ulPuZNawhPlElEtynCcyv 8LKDHzbP55uttSjUhsIqtUrpFftYmAlaipM/LUC2mHUlKuhMNsCGCIAGsX32PhHvo+3o Dkrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V8V9ImnR; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h7si2395058ejy.82.2020.07.09.10.47.33 for ; Thu, 09 Jul 2020 10:47:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V8V9ImnR; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728824AbgGIRr3 (ORCPT ); Thu, 9 Jul 2020 13:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728505AbgGIRqJ (ORCPT ); Thu, 9 Jul 2020 13:46:09 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E401DC08E6DC for ; Thu, 9 Jul 2020 10:46:08 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f7so3317458wrw.1 for ; Thu, 09 Jul 2020 10:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kZ+k2VRrvfDu4ASYD2+0hveDy1rv8dVhxsnPb7NP+X0=; b=V8V9ImnR8xB5UICcA8klK0T3O2TMEGcxT3IeNsvPi2SesI8NXMjPkjfKTzlDixJeCA TQUqVu9VgmdWB+IBVVm0GRFDpp3C7Gk64FNmT42cb45zFIF6tGGGrHhXyzp6hbmv9o+R u8TYWFy6Cr7KgZDkvlKEz8xv7m2tev+Z26lCnfQh3hnc1EebHn1tpGWwp34hZ4n9rDgo kIVsqIXv64xReH0F7tfZIN+biNjWMFRe5z+Ri70+RxymufKT/jhglyDIQQEkuPVjzlAo tBASIAPgtFIRXkLj84Eq/CYZEOVlPaD1UXcI1xLsL+/1SRFCDJaiM0te7MPC2S/VM+u7 7w9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kZ+k2VRrvfDu4ASYD2+0hveDy1rv8dVhxsnPb7NP+X0=; b=dCpTqEuIFVqnT6jD3OUdqZEXd0JY/ZdTdewfqm9OKP8tSCaKnTu2PDaOewF13x2gsH rzahB8iR/gi6H2fZSI/q1XhGFeVeq65zPygfxNenGyynB7qoauo0acnUAGoIxddHf/IF plG3pRPHH9r7E6tq505kOzr2+nc5146c8Ksyn9C4h9eXhGTb42fzC91oy/CuErGpTwFZ phn4ivXA4EZRFmZ9X9P8GT1dtvL66deH0KwgnPYZ/bjpXX7LAnhKvbIMCyQBz9ivz79C 6svoHWqXaAd3MYIdH6SEyybTzuWM+LItzJR4N8Ijy+mZZUh3azL9URK8ZWfKQtv6heDg ouiQ== X-Gm-Message-State: AOAM530FX2p9zd3IUjhYoMdTw5s5Q6x6nLYl4ajluA+VJSSwAwVC23V7 klV6ret1WZjzq+U0oQfG0sg/Rw== X-Received: by 2002:adf:c44d:: with SMTP id a13mr66244554wrg.205.1594316767535; Thu, 09 Jul 2020 10:46:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id f15sm6063854wrx.91.2020.07.09.10.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 10:46:07 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Luben Tuikov Subject: [PATCH 08/24] scsi: aic94xx: aic94xx_scb: Fix a couple of formatting and bitrot issues Date: Thu, 9 Jul 2020 18:45:40 +0100 Message-Id: <20200709174556.7651-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200709174556.7651-1-lee.jones@linaro.org> References: <20200709174556.7651-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Kerneldoc format should be '@.*: ', else the checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_scb.c:137: warning: Function parameter or member 'phy' not described in 'asd_get_attached_sas_addr' drivers/scsi/aic94xx/aic94xx_scb.c:137: warning: Function parameter or member 'sas_addr' not described in 'asd_get_attached_sas_addr' drivers/scsi/aic94xx/aic94xx_scb.c:860: warning: Function parameter or member 't' not described in 'asd_ascb_timedout' drivers/scsi/aic94xx/aic94xx_scb.c:860: warning: Excess function parameter 'data' description in 'asd_ascb_timedout' Cc: Luben Tuikov Signed-off-by: Lee Jones --- drivers/scsi/aic94xx/aic94xx_scb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/aic94xx/aic94xx_scb.c b/drivers/scsi/aic94xx/aic94xx_scb.c index 4a80ec08f0c96..c264b4b56970b 100644 --- a/drivers/scsi/aic94xx/aic94xx_scb.c +++ b/drivers/scsi/aic94xx/aic94xx_scb.c @@ -123,8 +123,8 @@ static unsigned ord_phy(struct asd_ha_struct *asd_ha, struct asd_phy *phy) /** * asd_get_attached_sas_addr -- extract/generate attached SAS address - * phy: pointer to asd_phy - * sas_addr: pointer to buffer where the SAS address is to be written + * @phy: pointer to asd_phy + * @sas_addr: pointer to buffer where the SAS address is to be written * * This function extracts the SAS address from an IDENTIFY frame * received. If OOB is SATA, then a SAS address is generated from the @@ -847,7 +847,7 @@ void asd_build_initiate_link_adm_task(struct asd_ascb *ascb, int phy_id, /** * asd_ascb_timedout -- called when a pending SCB's timer has expired - * @data: unsigned long, a pointer to the ascb in question + * @t: Timer context used to fetch the SCB * * This is the default timeout function which does the most necessary. * Upper layers can implement their own timeout function, say to free