From patchwork Tue Jul 21 16:41:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 246914 Delivered-To: patch@linaro.org Received: by 2002:a54:2c11:0:0:0:0:0 with SMTP id g17csp2711795ecp; Tue, 21 Jul 2020 09:43:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK2eSn6qnC8xaD6GGf55YczyM6KlmTf8kWl3SyBWxk4O5S/n8HDMGIOk8/5m8UIynNDJbJ X-Received: by 2002:a05:6402:3048:: with SMTP id bu8mr27759454edb.367.1595349791920; Tue, 21 Jul 2020 09:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595349791; cv=none; d=google.com; s=arc-20160816; b=eJ0VG3zyRo/CtHCEgRn1ML0Voklhv3dtfnJ4T4wMUMzBKJ3lCQ+T3mSInBp2B9xiSY PuMQ7FdrkhnvetngyUvImZ8IqoL5cSA6diURdmten1Mwi62oSvh1NU94EbbPzqNrZAUz IKNTohlsl3Ria2wLZidxDVMqmXne7JHMEzBKnWFqsSjNjPlwvmI5yfpQ2Cv2m9Z4fUTm F4qdgSwraHfBs8SjL3puQ+cxVjWQ8W7MpetvZKqA+C49D3dUSdPTM1+drSYggC05ovYZ DrSdFnBBby3rQ6CbiFXLhhyWLARkecoDq//ogTuAoj4pLq1cp8VJ7JdPjSF8eFLYRu50 CMhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eqUDrvqp47gD9IcVnzMp1ejaV+Kp3xiawYLE5j2QDM4=; b=y14qMEbgv7A8La6tRHqh0AN2BmIJLU+HpXlbOFuiZWvUUNVIj7cC+p+3FVEgdg34YW YActVsLkJL19w8wj2ZXNkEZbQ4JJBGTDk1iUMuEesGu0AS7dvl4CWX7Ipcjh5tWZs823 wq51FZTnsixQemijS0WSdtPiwVWprdEVPxh1vdh0+3KJK4FPjfRItmFg12a6XVyzvTpD oaQ74iiY+P2ketoxWMNXS9KL9To7zjaEJHzhkV3WCWaCG5w6xY/UWsLS2iq1TqX6mHZ5 A4rwPb/buj8XaOzl+LWIjnVn7grHK96/rHo5Yp1K+NPWV9VtrI/17FMaAZyhgwCPHl7O Ytzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BmkVY0fv; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si12089888ejc.314.2020.07.21.09.43.11 for ; Tue, 21 Jul 2020 09:43:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BmkVY0fv; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730813AbgGUQm6 (ORCPT ); Tue, 21 Jul 2020 12:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730807AbgGUQmy (ORCPT ); Tue, 21 Jul 2020 12:42:54 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46294C0619DB for ; Tue, 21 Jul 2020 09:42:54 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 22so3481837wmg.1 for ; Tue, 21 Jul 2020 09:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eqUDrvqp47gD9IcVnzMp1ejaV+Kp3xiawYLE5j2QDM4=; b=BmkVY0fv9v0/nDQ2O9/Z4PhE/KjvOh31PPQoFLXaiJK9CJzVEos9o1gVkAvQsqUSPA QwVzEpu+r0bTUmxG515TI9eXFGA95IiPDbxD4g7+zLSsllv0eLWaPv1Wnfol0yyI5pRM E9Bvd0a9sMISnVs2KSG4V0PJGZenB0N8C23+jHJo4WP2ztN+63/j9E4eVhRt7ntdUYzS PuK+5V5F92vBYRk9GvroDMvQBTI+0OgwP8DRoNEeiEjDCDir0q/06G2XmI9oo8nebPf4 n6TZj/yLggcoyLyucMOhGACv+IAYw316esHeRq+4xVtiPqUy3SJXU8UuwjMmMNuo+vOr Ny7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eqUDrvqp47gD9IcVnzMp1ejaV+Kp3xiawYLE5j2QDM4=; b=iYitKYHbOXJH8ajtxCz2o1NxESQjAeII9EzW84HhT4e5Z6yeFlJZ5EbWdkXWxjfVXH CTtBUqzSzvR/U+i6Ddr3SxJCZmE7MpqWpUZ/E48ui8OomW8y91y0nrWbkTwViSbB6bbx Uv4lWbsSRKl0forPkz8mr1HXxFmEndF+z6JT/KpJSzh9DOLV11X3JE1ilOaRM4p/3i91 d0edx3JicxxkX2IGm5dgEhsMDLPhPMdN5gKeUF4R43h7o/YzXHl5GOHL6Bjm4YON4JV8 3S+7srtm/zhQQoEc8bVnBd0MLzMwhYnDS5NFu7OW7YME92nJ++iGeHpPMR8eTx4T0OFG iSmw== X-Gm-Message-State: AOAM530Oy3bm2fxzBf5HQbaWxdAmfnR+Jsvu8Rk4ppjPvVGny5oO1nIx +GpFXtWBUwgdwPIdJ65Gc6bFOw== X-Received: by 2002:a7b:c116:: with SMTP id w22mr4584794wmi.97.1595349773040; Tue, 21 Jul 2020 09:42:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id m4sm3933524wmi.48.2020.07.21.09.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 09:42:52 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Karen Xie , Dimitris Michailidis Subject: [PATCH 40/40] scsi: cxgbi: cxgb3i: cxgb3i: Remove bad documentation and demote kerneldoc header Date: Tue, 21 Jul 2020 17:41:48 +0100 Message-Id: <20200721164148.2617584-41-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200721164148.2617584-1-lee.jones@linaro.org> References: <20200721164148.2617584-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Also move the header block above the correct function. Fixes the following W=1 kernel build warning(s): drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Function parameter or member 'dev' not described in 'arp_failure_skb_discard' drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Function parameter or member 'skb' not described in 'arp_failure_skb_discard' drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Excess function parameter 'c3cn' description in 'arp_failure_skb_discard' drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Excess function parameter 'req_completion' description in 'arp_failure_skb_discard' drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:895: warning: Function parameter or member 'csk' not described in 'l2t_put' drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:895: warning: Excess function parameter 'c3cn' description in 'l2t_put' Cc: Karen Xie Cc: Dimitris Michailidis Signed-off-by: Lee Jones --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c index f2714c54a5196..2b48954b6b1ef 100644 --- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c +++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c @@ -375,10 +375,8 @@ static inline void make_tx_data_wr(struct cxgbi_sock *csk, struct sk_buff *skb, } } -/** +/* * push_tx_frames -- start transmit - * @c3cn: the offloaded connection - * @req_completion: request wr_ack or not * * Prepends TX_DATA_WR or CPL_CLOSE_CON_REQ headers to buffers waiting in a * connection's send queue and sends them on to T3. Must be called with the @@ -886,11 +884,6 @@ static int alloc_cpls(struct cxgbi_sock *csk) return -ENOMEM; } -/** - * release_offload_resources - release offload resource - * @c3cn: the offloaded iscsi tcp connection. - * Release resources held by an offload connection (TID, L2T entry, etc.) - */ static void l2t_put(struct cxgbi_sock *csk) { struct t3cdev *t3dev = (struct t3cdev *)csk->cdev->lldev; @@ -902,6 +895,10 @@ static void l2t_put(struct cxgbi_sock *csk) } } +/* + * release_offload_resources - release offload resource + * Release resources held by an offload connection (TID, L2T entry, etc.) + */ static void release_offload_resources(struct cxgbi_sock *csk) { struct t3cdev *t3dev = (struct t3cdev *)csk->cdev->lldev;