From patchwork Thu Jul 23 12:24:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 247051 Delivered-To: patch@linaro.org Received: by 2002:a54:2c11:0:0:0:0:0 with SMTP id g17csp1148477ecp; Thu, 23 Jul 2020 05:26:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhK46X0FX4DHAlcj+FoUxEHTaJHyhZzc3yVhUgqvt76peJPeLY/q8j36hDrFzDFHJG+WYx X-Received: by 2002:a17:906:d8db:: with SMTP id re27mr4094177ejb.554.1595507174008; Thu, 23 Jul 2020 05:26:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595507174; cv=none; d=google.com; s=arc-20160816; b=rKH947xDfyAwyy2LjGdsXA0t+wcZGWL8mPqAnOEGdk3lLyLwg4t5acnVIGLBIAfKLq P5KDx/yHyyx+YTEWXAg7rkH8iVgeN/H40s8mRns0jZbsw8cLoLGHZB2VA+N5u0R7fidg FzIIMAX5yL9uupCFHDbV8UpTkF2Qk/08Pl+PJ5Yl4QgqEjxquxw7MALCIy6WyPuR0OyO S1LcDZ67NXZpfhOX7eduwoAPTxir0bUPcFaVyXoFwmRkTOCxy5r5seJUaCVGqN6uZvBS IfB9dqtTuJXADXDVryOExqAOW9L89XhmCY8RW8rGXmAGmxXgLv6jouG7BG6aTWs/3vjQ MLyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y7MiQFR4MfIftYnbJz642q1pbyBNEj9l/lt1l++SzIE=; b=uFptJ9s1g33keV++IcldvRRAAwSvvgyQuJW6unZ7ooFtAcVL8wRvSPjlkRkq4oF3DY TbIh6qOXFZod/JCptN6yE3YDwbxGH4K5r/tjr2nmiscIeRvsWFEksCTdIt3cp+2n5Bqw K8wwMhaPKJsV0moHysstBYDk/SVUTnTL+LsyUEyaMfoN7amvDSDK+jotkLv0STmTZQV1 v7NYr1aYy+r9fQGOKtgEvvQ2qJEvTFqU+CsFWLtlxzpz3mKvjLGlbwMK+A57KwcGPRqI Na+MZE1xBn5WsTSjvOafqiMTxMr0CbJlfpbwJwYXWMWKULHvkhuMywBiIT73J/BwDcrf bHew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Us3D32gP; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi20si1699073ejb.365.2020.07.23.05.26.13 for ; Thu, 23 Jul 2020 05:26:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Us3D32gP; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729041AbgGWMZ2 (ORCPT ); Thu, 23 Jul 2020 08:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729032AbgGWMZ1 (ORCPT ); Thu, 23 Jul 2020 08:25:27 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE8CC0619E6 for ; Thu, 23 Jul 2020 05:25:26 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 9so4774084wmj.5 for ; Thu, 23 Jul 2020 05:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y7MiQFR4MfIftYnbJz642q1pbyBNEj9l/lt1l++SzIE=; b=Us3D32gPY+JYnXjK++12vZVZDsA2wXNOc9+OYP8A3BePDPwztRgB5/Z/8IAizc97X8 nKosVGZ9N+dVKncBJjX433ecd0HYtaZ0zTUjtqgi2JAWtEIHEjrSDa1JZQCVzqMYHExW 2fTUrUmz7ey6c01MHFuKqbLY5uBwj3NKh+7F0pIrL0RsdKuXIpxlS7EvGmsa4P24aGWZ avIAkIAnxjVTvxYIF4cX3zHHwfitNVezEEnnRyzFNOsn1wXfCanvLpbtR7F6MP4gGsLK VeSUgNdufmcTSewKqZD1d1f91zqBK2q13hmqogTzrClLfFGeT1nYIgIt4KeVDJlreBKM SWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7MiQFR4MfIftYnbJz642q1pbyBNEj9l/lt1l++SzIE=; b=uPplsrHHn0vjGNQ85EmbcyL0/UuVmIIl9nt/5cvsP1LQ0XJJNTqQcI61xD1sXkl02y /Q5S38IKuGx1l+9zuqRFDyaJAQtGKKsZvbgzViJuu6kXXkKa9ivwp3NyyerB+BYRckG9 gYOqgczXiob3J++gb3RoMEBjCx6avJNyuIKDHZ31zUPJaV77VTwkGBaBvn48MjPpm3vV nF5EqFOYSQI338aiIZjS0uJRAJGdb6MhMR8JD8AWhB6G9DvhjWObDnovYIvrLu1/zR2o MZApzjUrqsywpmtbhlR4V+rY3mkqci1wwwgWopti08Hzcbisqv4YwBwKmkn5wLjTcEpK TpDg== X-Gm-Message-State: AOAM531XQPsOPlbqxShidpXBfIPIciZ4x/LA2Z17o7OwmyQ+VrNTZPLt y7Y/BdTiAMUJwTlfMSM15aCAJpc3CL8= X-Received: by 2002:a1c:750a:: with SMTP id o10mr4120196wmc.165.1595507125085; Thu, 23 Jul 2020 05:25:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:24 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Anil Veerabhadrappa , Eddie Wai Subject: [PATCH 29/40] scsi: bnx2i: bnx2i_iscsi: Add, remove and edit some function parameter descriptions Date: Thu, 23 Jul 2020 13:24:35 +0100 Message-Id: <20200723122446.1329773-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_bind_conn_to_iscsi_cid' drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Excess function parameter 'conn' description in 'bnx2i_bind_conn_to_iscsi_cid' drivers/scsi/bnx2i/bnx2i_iscsi.c:470: warning: Excess function parameter 'cmd' description in 'bnx2i_destroy_cmd_pool' drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Function parameter or member 'cls_session' not described in 'bnx2i_drop_session' drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'hba' description in 'bnx2i_drop_session' drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'session' description in 'bnx2i_drop_session' drivers/scsi/bnx2i/bnx2i_iscsi.c:1290: warning: Function parameter or member 'ep' not described in 'bnx2i_session_create' drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Function parameter or member 'bnx2i_ep' not described in 'bnx2i_ep_tcp_conn_active' drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Excess function parameter 'ep' description in 'bnx2i_ep_tcp_conn_active' drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'shost' not described in 'bnx2i_nl_set_path' drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'params' not described in 'bnx2i_nl_set_path' drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Excess function parameter 'buf' description in 'bnx2i_nl_set_path' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa Cc: Eddie Wai Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index 0b28d44d35738..a9ffd89ec2c85 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -228,7 +228,7 @@ static void bnx2i_setup_cmd_wqe_template(struct bnx2i_cmd *cmd) /** * bnx2i_bind_conn_to_iscsi_cid - bind conn structure to 'iscsi_cid' * @hba: pointer to adapter instance - * @conn: pointer to iscsi connection + * @bnx2i_conn: pointer to iscsi connection * @iscsi_cid: iscsi context ID, range 0 - (MAX_CONN - 1) * * update iscsi cid table entry with connection pointer. This enables @@ -463,7 +463,6 @@ static int bnx2i_alloc_bdt(struct bnx2i_hba *hba, struct iscsi_session *session, * bnx2i_destroy_cmd_pool - destroys iscsi command pool and release BD table * @hba: adapter instance pointer * @session: iscsi session pointer - * @cmd: iscsi command structure */ static void bnx2i_destroy_cmd_pool(struct bnx2i_hba *hba, struct iscsi_session *session) @@ -582,8 +581,7 @@ static void bnx2i_free_mp_bdt(struct bnx2i_hba *hba) /** * bnx2i_drop_session - notifies iscsid of connection error. - * @hba: adapter instance pointer - * @session: iscsi session pointer + * @cls_session: iscsi cls session pointer * * This notifies iscsid that there is a error, so it can initiate * recovery. @@ -1277,7 +1275,7 @@ static int bnx2i_task_xmit(struct iscsi_task *task) /** * bnx2i_session_create - create a new iscsi session - * @cmds_max: max commands supported + * @ep: pointer to iscsi endpoint * @qdepth: scsi queue depth to support * @initial_cmdsn: initial iscsi CMDSN to be used for this session * @@ -1971,7 +1969,7 @@ static int bnx2i_ep_poll(struct iscsi_endpoint *ep, int timeout_ms) /** * bnx2i_ep_tcp_conn_active - check EP state transition - * @ep: endpoint pointer + * @bnx2i_ep: endpoint pointer * * check if underlying TCP connection is active */ @@ -2014,9 +2012,9 @@ static int bnx2i_ep_tcp_conn_active(struct bnx2i_endpoint *bnx2i_ep) } -/* +/** * bnx2i_hw_ep_disconnect - executes TCP connection teardown process in the hw - * @ep: TCP connection (bnx2i endpoint) handle + * @bnx2i_ep: TCP connection (bnx2i endpoint) handle * * executes TCP connection teardown process */ @@ -2171,8 +2169,8 @@ static void bnx2i_ep_disconnect(struct iscsi_endpoint *ep) /** * bnx2i_nl_set_path - ISCSI_UEVENT_PATH_UPDATE user message handler + * @shost: scsi host pointer * @buf: pointer to buffer containing iscsi path message - * */ static int bnx2i_nl_set_path(struct Scsi_Host *shost, struct iscsi_path *params) {