From patchwork Wed Oct 14 12:26:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kashyap Desai X-Patchwork-Id: 269814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MIME_HEADER_CTYPE_ONLY, MIME_NO_TEXT, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, T_TVD_MIME_NO_HEADERS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064AAC43457 for ; Wed, 14 Oct 2020 12:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B2D2221FE for ; Wed, 14 Oct 2020 12:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="gAbDVWS2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730170AbgJNM04 (ORCPT ); Wed, 14 Oct 2020 08:26:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730097AbgJNM0z (ORCPT ); Wed, 14 Oct 2020 08:26:55 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E51CC0613D2 for ; Wed, 14 Oct 2020 05:26:55 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id h24so4521848ejg.9 for ; Wed, 14 Oct 2020 05:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=IjKh0FaFgmuuZc9CkOcgT87lCaWqpTRvHPDaIWdNegc=; b=gAbDVWS2l0Sxtn+QAq5lOe/4lvJI5u0wy5YQezRHu4ExJjyTKDbN1mgSihNVAcgy/E 7oi5n6R3ocDYw+DYlldoo1zwdh+ow//MWTYvR1/LloqUAUzoJMdfOb9Gurmk8Vcy12Ky LPRTKizbrRIITCZajLCytz4iRyCk/rLS2YROY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IjKh0FaFgmuuZc9CkOcgT87lCaWqpTRvHPDaIWdNegc=; b=kyEWaezcL45SquNNwQzze5nHA3HnzwhHyH7FydaA57CjLefYbRPQ/rgD9kcgdYnFyv Bm2HLQgg0Il66SPBXL6PufDESIfB4Xe8AX0mjtJzcttFf4lQ4k8UGUU5vsu1XWW/wJzY LLpN0F0pebK4LKU7Ijm4mQDZ6UfVJUGY3qJV5cM2EKdhAVvt8FqjCi/nmpzGAAlo3xtO Mw1xsrq82XWfv4pUsc6LYyZz7ElqAa3t4oMu8DzJqf39Hs/jCPYSv3/KmO79v+FQRiRH l5+dE+d6MG9w7xXCs27PnoAtkLaNVVD+NLf5uE4S+6l92A9k4QsGs3q0F13v5PvuslUJ RbJg== X-Gm-Message-State: AOAM5337JB4p5NuLQ5Pyqur4t37287VpSkB8OyUbkqOCZa7a7UIZFC6P I2Wzz2Z8TV8uKSfZRSas0Ztvac6mWMAAVYzFsHoxVzMjQwOvNypailZWOof5pU605amnODe6aTg vPjZfwgDOomSrdA/C3IYpjitXYwBF3fSR1trxeBGT1fwE8wemKd0J+dvg9t2QOm/D9e7tZ6Y2VB 3kksrLSyrgmFI= X-Google-Smtp-Source: ABdhPJzwT9b98N+pkQsDgYgVYPfebGg3/RX/c+RsgBVURQByt57iPpzOdgzTnLRExjGbAH47I/Vpjg== X-Received: by 2002:a17:906:4a97:: with SMTP id x23mr4858751eju.471.1602678413580; Wed, 14 Oct 2020 05:26:53 -0700 (PDT) Received: from drv-bst-rhel8.static.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id w4sm1532505eds.83.2020.10.14.05.26.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 05:26:52 -0700 (PDT) From: Kashyap Desai To: linux-scsi@vger.kernel.org Cc: Kashyap Desai , sumit.saxena@broadcom.com, chandrakanth.patil@broadcom.com, linux-block@vger.kernel.org Subject: [PATCH 1/3] add io_uring with IOPOLL support in scsi layer Date: Wed, 14 Oct 2020 17:56:29 +0530 Message-Id: <20201014122629.201223-1-kashyap.desai@broadcom.com> X-Mailer: git-send-email 2.18.1 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org io_uring with IOPOLL is not currently supported in scsi mid layer. Outside of that everything else should work and no extra support in the driver is needed. Currently io_uring with IOPOLL support is only available in block layer. This patch is to extend support of mq_poll in scsi layer. Signed-off-by: Kashyap Desai Cc: sumit.saxena@broadcom.com Cc: chandrakanth.patil@broadcom.com Cc: linux-block@vger.kernel.org --- drivers/scsi/scsi_lib.c | 16 ++++++++++++++++ include/scsi/scsi_cmnd.h | 1 + include/scsi/scsi_host.h | 11 +++++++++++ 3 files changed, 28 insertions(+) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index a89478a0c588..0140d9aac64b 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1757,6 +1757,19 @@ static void scsi_mq_exit_request(struct blk_mq_tag_set *set, struct request *rq, cmd->sense_buffer); } + +static int scsi_mq_poll(struct blk_mq_hw_ctx *hctx) +{ + struct request_queue *q = hctx->queue; + struct scsi_device *sdev = q->queuedata; + struct Scsi_Host *shost = sdev->host; + + if (shost->hostt->mq_poll) + return shost->hostt->mq_poll(shost, hctx->queue_num); + + return 0; +} + static int scsi_map_queues(struct blk_mq_tag_set *set) { struct Scsi_Host *shost = container_of(set, struct Scsi_Host, tag_set); @@ -1824,6 +1837,7 @@ static const struct blk_mq_ops scsi_mq_ops_no_commit = { .cleanup_rq = scsi_cleanup_rq, .busy = scsi_mq_lld_busy, .map_queues = scsi_map_queues, + .poll = scsi_mq_poll, }; @@ -1852,6 +1866,7 @@ static const struct blk_mq_ops scsi_mq_ops = { .cleanup_rq = scsi_cleanup_rq, .busy = scsi_mq_lld_busy, .map_queues = scsi_map_queues, + .poll = scsi_mq_poll, }; struct request_queue *scsi_mq_alloc_queue(struct scsi_device *sdev) @@ -1884,6 +1899,7 @@ int scsi_mq_setup_tags(struct Scsi_Host *shost) else tag_set->ops = &scsi_mq_ops_no_commit; tag_set->nr_hw_queues = shost->nr_hw_queues ? : 1; + tag_set->nr_maps = shost->nr_maps ? : 1; tag_set->queue_depth = shost->can_queue; tag_set->cmd_size = cmd_size; tag_set->numa_node = NUMA_NO_NODE; diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index e76bac4d14c5..5844374a85b1 100644 --- a/include/scsi/scsi_cmnd.h +++ b/include/scsi/scsi_cmnd.h @@ -9,6 +9,7 @@ #include #include #include +#include #include #include diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index 701f178b20ae..905ee6b00c55 100644 --- a/include/scsi/scsi_host.h +++ b/include/scsi/scsi_host.h @@ -270,6 +270,16 @@ struct scsi_host_template { */ int (* map_queues)(struct Scsi_Host *shost); + /* + * SCSI interface of blk_poll - poll for IO completions. + * Possible interface only if scsi LLD expose multiple h/w queues. + * + * Return values: Number of completed entries found. + * + * Status: OPTIONAL + */ + int (* mq_poll)(struct Scsi_Host *shost, unsigned int queue_num); + /* * Check if scatterlists need to be padded for DMA draining. * @@ -610,6 +620,7 @@ struct Scsi_Host { * the total queue depth is can_queue. */ unsigned nr_hw_queues; + unsigned nr_maps; unsigned active_mode:2; unsigned unchecked_isa_dma:1;