diff mbox series

[14/37] zfcp: do not set COMMAND_COMPLETE

Message ID	20201204100140.140863-15-hare@suse.de
State	Superseded
Headers	show Return-Path: <linux-scsi-owner@kernel.org> From: Hannes Reinecke <hare@suse.de> To: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Christoph Hellwig <hch@lst.de>, James Bottomley <james.bottomley@hansenpartnership.com>, linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCH 14/37] zfcp: do not set COMMAND_COMPLETE Date: Fri, 4 Dec 2020 11:01:17 +0100 Message-Id: <20201204100140.140863-15-hare@suse.de> In-Reply-To: <20201204100140.140863-1-hare@suse.de> References: <20201204100140.140863-1-hare@suse.de> Precedence: bulk
Series	SCSI result handling cleanup, part 1 \| expand [PATCHv2,00/37] SCSI result handling cleanup, part 1 [01/37] scsi: drop gdth driver [02/37] 3w-xxxx: Whitespace cleanup [03/37] 3w-9xxx: Whitespace cleanup [04/37] 3w-sas: Whitespace cleanup [05/37] atp870u: Whitespace cleanup [06/37] aic7xxx,aic79xx: Whitespace cleanup [07/37] aic7xxx,aic79xx: kill pointless forward declarations [08/37] aic7xxx,aic79xxx: remove driver-defined SAM status definitions [09/37] bfa: drop driver-defined SCSI status codes [10/37] acornscsi: use standard defines [11/37] nsp32: fixup status handling [12/37] dc395: drop private SAM status code definitions [13/37] qla4xxx: use standard SAM status definitions [14/37] zfcp: do not set COMMAND_COMPLETE [15/37] aacraid: avoid setting message byte on completion [16/37] hpsa: do not set COMMAND_COMPLETE [17/37] stex: do not set COMMAND_COMPLETE [18/37] nsp_cs: drop internal SCSI message definition [19/37] aic7xxx,aic79xx: drop internal SCSI message definition [20/37] dc395x: drop internal SCSI message definitions [21/37] initio: drop internal SCSI message definition [22/37] scsi_debug: do not set COMMAND_COMPLETE [23/37] ufshcd: do not set COMMAND_COMPLETE [24/37] atp870u: use standard definitions [25/37] mac53c94: Do not set invalid command result [26/37] dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message [27/37] scsi: add 'set_status_byte()' accessor [28/37] esp_scsi: use host byte as last argument to esp_cmd_is_done() [29/37] esp_scsi: do not set SCSI message byte [30/37] wd33c93: use SCSI status [31/37] ips: use correct command completion on error [32/37] storvsc: Return DID_ERROR for invalid commands [33/37] qla2xxx: fc_remote_port_chkready() returns a SCSI result value [34/37] advansys: kill driver_defined status byte accessors [35/37] ncr53c8xx: Use SAM status values [36/37] dc395x: drop internal result accessors [37/37] scsi: use non-shifted status values

Commit Message

Hannes Reinecke Dec. 4, 2020, 10:01 a.m. UTC

COMMAND_COMPLETE is defined as '0', and it is a SCSI parallel message
to boot. So drop the call to set_msg_byte().

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/s390/scsi/zfcp_fc.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Benjamin Block Dec. 4, 2020, 1:09 p.m. UTC | #1

On Fri, Dec 04, 2020 at 11:01:17AM +0100, Hannes Reinecke wrote:
> COMMAND_COMPLETE is defined as '0', and it is a SCSI parallel message
> to boot. So drop the call to set_msg_byte().
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/s390/scsi/zfcp_fc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/s390/scsi/zfcp_fc.h b/drivers/s390/scsi/zfcp_fc.h
> index 6902ae1f8e4f..8aaf409ce9cb 100644
> --- a/drivers/s390/scsi/zfcp_fc.h
> +++ b/drivers/s390/scsi/zfcp_fc.h
> @@ -275,7 +275,6 @@ void zfcp_fc_eval_fcp_rsp(struct fcp_resp_with_ext *fcp_rsp,
>  	u32 sense_len, resid;
>  	u8 rsp_flags;
>  
> -	set_msg_byte(scsi, COMMAND_COMPLETE);
>  	scsi->result |= fcp_rsp->resp.fr_status;
>  
>  	rsp_flags = fcp_rsp->resp.fr_flags;
> -- 
> 2.16.4
> 

Thanks, Hannes.

Acked-by: Benjamin Block <bblock@linux.ibm.com>

diff mbox series

Patch

diff --git a/drivers/s390/scsi/zfcp_fc.h b/drivers/s390/scsi/zfcp_fc.h
index 6902ae1f8e4f..8aaf409ce9cb 100644
--- a/drivers/s390/scsi/zfcp_fc.h
+++ b/drivers/s390/scsi/zfcp_fc.h
@@ -275,7 +275,6 @@  void zfcp_fc_eval_fcp_rsp(struct fcp_resp_with_ext *fcp_rsp,
 	u32 sense_len, resid;
 	u8 rsp_flags;
 
-	set_msg_byte(scsi, COMMAND_COMPLETE);
 	scsi->result |= fcp_rsp->resp.fr_status;
 
 	rsp_flags = fcp_rsp->resp.fr_flags;