From patchwork Wed Mar 17 09:12:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 403087 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp294600jai; Wed, 17 Mar 2021 02:14:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysgisVaa4QoxstY70e12zIp2mZdwUzAQHr0+Bxr4saKlLkarmtDD65ORs/lk1DZ1aNMFGL X-Received: by 2002:a17:906:3b47:: with SMTP id h7mr33812588ejf.377.1615972444396; Wed, 17 Mar 2021 02:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615972444; cv=none; d=google.com; s=arc-20160816; b=hQqttsdvOuVzSWt9Qec9mVLJLIfTBcJDMAZ+7c3+q9gXBbt2P3Hdbd3ZGtkSX96o+V PUYkMQck52luqOxT3FO4+gwoJmBtUfxoehc6dbDY/IMbqRX7sRcmsWOEd2r7UdGDVB0h 5jn4ME891DvE6iG5D5kRqRxtHRcAmUsZO0DMDUCUDGe1ownq0+4QEGgzO0ZUVmh0Oosq MultbB6+2jrNnmXahZlS23xLXsJ8DSjHcTf/QJQ+7xB7y8clYapsoRnd95Q1L2X68JP5 aKrpRTiO5+K0t0ABl6q3rxuG6eR34kjBzgxLuzkNKKtnn7mQhtvoU4l+hnG0221HmhoX glQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X2jzyWxb6hZ16y5SB+2tveo3Hvk9XXLg4i7IoitMdEQ=; b=XjuEafQ86FOMY/DmTos4FEwZdYbgY6AcKy0CW/WYEDhf1+maYiPP82IALeWmZNy+Ku y6CQ1B0SLkWyOQhUTltaHXWaoA6SaZNERZoByrAZ9jenRxvh9aUwubC2aqRsf0qF6McN wKDWPk2GYNq8bCvEdOd53B/r+Fcl+gdE920c4YJK399XQp9vvCk/aAlXbdWNDn2O5jan pokzbMxcWH9GIyFnv6SqidIJx4L68DC5/Stn0T9KVT8cONbnikzm9/glO2JV41cgOBgC GPO+MVUyApdrlErUj2tNLf0bD3iRqvNYL4tyHKJrh9udg+K7Tdknvm5W2oKgV5NrhZ1H K7Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sz9BPNST; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si15461864edq.164.2021.03.17.02.14.04 for ; Wed, 17 Mar 2021 02:14:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sz9BPNST; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbhCQJNj (ORCPT ); Wed, 17 Mar 2021 05:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbhCQJNB (ORCPT ); Wed, 17 Mar 2021 05:13:01 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15697C0613E0 for ; Wed, 17 Mar 2021 02:13:01 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id 61so991673wrm.12 for ; Wed, 17 Mar 2021 02:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X2jzyWxb6hZ16y5SB+2tveo3Hvk9XXLg4i7IoitMdEQ=; b=Sz9BPNST98yr2QElSdpJAAY98v7AGIVUMHdqfE6cjKNe9TWa0JzeSbG0yXFBZPShMH m/9tK7TMTeul+K8w8OuGH8yBx85GmpognI5LZrubw7BgMLhdqnb2U2q0pg67TKV7+oI7 w3Xy+d/EhvwYX4EAKgUVr8wyabh9cHsAMXQdUiY7YihMP2XInKa6hS6le6bP2ek5arCj 7lEmjvi3kVmFHoEgZl3t+qkbgV+QZRLPeXM6lCEI31xVu7ilVDt/ep1SB/xsDYuRU2jQ rO+yf1zRtLBnWz9oqKSLeS7R0pvHQzBQIk8rho0zbZw2Y1ST/nbRdAOStpC2/LyYFFGb jJvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X2jzyWxb6hZ16y5SB+2tveo3Hvk9XXLg4i7IoitMdEQ=; b=oPeaNLOPwOpg9W3S0jpkhNL0SNqN5QqbcFON/FQKVNLjqvgu5zOmUuoukZyowO+eLz 4QMl6UwVJRhIFi7YR1tH7cU72eaof5Attv/BVo3saG17FJSlUpnn1idKZkPHmA9905Vg gULGFM4RS/V6UOhe1sxQ7OSIOlf9ADIdEElnkd7k+461weHU3hHk+Z6AYfaekm/4QQQX oEMUmVJrAVBar8cjaQfM+5Rkm6xAbown3jHfconWgNX310/lY/FghP69s4rX6GgCRViL Wa4I7iovt2SSxSdtVnihqjiJmvi4XNesGjFgJs3kixLsB6exkuVCoJSaDfWdwsb2P5qo BeyA== X-Gm-Message-State: AOAM5326CJpdyyPEp5bncmUo8/B+vWlXaE6ZFhyfsJl9/yEh9T8AC2K7 SK/l7o2fGuzjftfbW00YcuF9Fx9WDmmv5A== X-Received: by 2002:adf:8341:: with SMTP id 59mr3205254wrd.130.1615972379865; Wed, 17 Mar 2021 02:12:59 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id e18sm12695886wru.73.2021.03.17.02.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 02:12:59 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 19/36] scsi: isci: phy: Provide function name and demote non-conforming header Date: Wed, 17 Mar 2021 09:12:13 +0000 Message-Id: <20210317091230.2912389-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317091230.2912389-1-lee.jones@linaro.org> References: <20210317091230.2912389-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/isci/phy.c:354: warning: Function parameter or member 'iphy' not described in 'phy_get_non_dummy_port' drivers/scsi/isci/phy.c:354: warning: expecting prototype for If the phy is(). Prototype was for phy_get_non_dummy_port() instead drivers/scsi/isci/phy.c:371: warning: Function parameter or member 'iphy' not described in 'sci_phy_set_port' drivers/scsi/isci/phy.c:371: warning: Function parameter or member 'iport' not described in 'sci_phy_set_port' Cc: Artur Paszkiewicz Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/isci/phy.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) -- 2.27.0 diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c index 7ca7621f77479..aa8787343e831 100644 --- a/drivers/scsi/isci/phy.c +++ b/drivers/scsi/isci/phy.c @@ -339,10 +339,11 @@ static void phy_sata_timeout(struct timer_list *t) } /** - * This method returns the port currently containing this phy. If the phy is - * currently contained by the dummy port, then the phy is considered to not - * be part of a port. - * @sci_phy: This parameter specifies the phy for which to retrieve the + * phy_get_non_dummy_port() - This method returns the port currently containing + * this phy. If the phy is currently contained by the dummy port, then the phy + * is considered to not be part of a port. + * + * @iphy: This parameter specifies the phy for which to retrieve the * containing port. * * This method returns a handle to a port that contains the supplied phy. @@ -360,10 +361,8 @@ struct isci_port *phy_get_non_dummy_port(struct isci_phy *iphy) return iphy->owning_port; } -/** +/* * sci_phy_set_port() - This method will assign a port to the phy object. - * @out]: iphy This parameter specifies the phy for which to assign a port - * object. */ void sci_phy_set_port( struct isci_phy *iphy,