From patchwork Wed Mar 17 09:12:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 403097 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp294721jai; Wed, 17 Mar 2021 02:14:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZWHjWOkOUMECHafQRHVlmS8lNxqeizGGnza5hfDwpye5O6u+d/4ikxR0wENdfeDzGtScK X-Received: by 2002:a17:906:398a:: with SMTP id h10mr34762318eje.155.1615972453226; Wed, 17 Mar 2021 02:14:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615972453; cv=none; d=google.com; s=arc-20160816; b=dImhxYJkQmYMaxwBn2bwikDBVAmYueocvXnELNyH6nawrOWByqwruuI3C/BxN8P7Gw fWNEN/TonOHKcM01zwuUlcGgWVc/h+RVVTqFMbLXlKW/FSth7/7Eg3hggnYJcgyQFlRt nrxlgRCuCF55cg6kgTFVjnh6PGw58uD6vRS0dUcLty+ZTqtyJ3tYrYH3N9IihqNmFcPt ViuVS2Ceot3485fOpnSmvWm+ZoI1PJbfXW43dTwIhOorp0kHvEeu2IdFpwaCbpdFHe3P s7N5IvuTX5kg4PQ4KaDE/PKOK4IyoGkBV68I99LDySzYFJ5xgQfLLvSgVA2V9gX4zO45 X1Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OhnfyqYrE6nzlDYMaUSwKVkj3wHq5/inwlljmfMJr4g=; b=Ec8i85l+Vs1OMK2bcP6swITfqK2KnFmmF3yuJ7tz0pbRw/vvD7D+35jST0/TYMP4B4 /XSTt9nOWmmbIVcAChq6lxTPZiC1SczwfqOTV6ORiBjkcqlPfw2U+y9eLjGxHRfFqIf+ 6LXnxcoQMjAOQ69kWdS3BAnBSH5wqilm8YI2zgYK/sA9vsmHOxEKXXTYHeORERLwbAv+ KnKSiV4SUmoMJRieB7DmhB6D6bFVwDNI73bpgZHCGvrbwAnIyivoUfLgE4iUi409WoZ9 TWyvqOFXpBSphH7iCo/pAdkztdQPQFTXrdorqu4bpgBs3Egf5WHlPun9dZ9VckRVpFno 5DBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oq6gMGCp; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si15461864edq.164.2021.03.17.02.14.13 for ; Wed, 17 Mar 2021 02:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oq6gMGCp; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231168AbhCQJNq (ORCPT ); Wed, 17 Mar 2021 05:13:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbhCQJNI (ORCPT ); Wed, 17 Mar 2021 05:13:08 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00855C06175F for ; Wed, 17 Mar 2021 02:13:07 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id e9so997036wrw.10 for ; Wed, 17 Mar 2021 02:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OhnfyqYrE6nzlDYMaUSwKVkj3wHq5/inwlljmfMJr4g=; b=oq6gMGCp+1IVUkver2pNGwBGb3YllnTbfUJkhd4e/S22gLbOJfKgwWopVR7taYr4rY speAS2+XKik7crtgBRXoHF0u+v2DwNnbtwgE861pRWY0VYGyjasQymLvYB9XdXEK7BKy HFzh4j7v+6zEsMyFSaZXpGUORnP0BuOF848awJj8D0HXqFyPkrYAwVOHhtIvH4WsFbYE 2VKsw2+x+jGeOY3uPStF3ytb5FhKwNGK62JOhzozqwsZf9Z56lxNXVmamNVpWPkTFRge xh2Wq4UpZR8kP15BB7JsvuSULmWakv7A71/D9FvGhfJVHULDYo5XEF7MFm9sMIsYwGX5 fxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OhnfyqYrE6nzlDYMaUSwKVkj3wHq5/inwlljmfMJr4g=; b=efH+z1poCi0VJbR8yVYTDcfQEpv+7NH7KMwNjKtQFpdGjqIsGROQWNJdegAXKs8jsT 92KA15nDVwIVpBwnMKvncGrQHjWnQDwTi3iPvxSs6KyiBYF2KwnmEvrTKYSVXKmFg0j8 xfRVWpkra/eLFkxd8ysOi1ikaduWjeVhoOFvnRTScJJxSIwsHoDmzkx41XzSrMaxq9sY cFz2/kTT4BnIS4CaHcz2IGqpsGsUWtsTYIsmw6Dn7GjPf+Hdv6U08Y877eRmJOCEr+1J aqeQ/PkEq0HxJTdlGbrPdkTbbL13xoA/Ey4BqoSlT7jQ1ASsH5ntWv1tGRmZoec3vFRV Nnyg== X-Gm-Message-State: AOAM533nmgCcOBiDkCuVkp75McivR7Cd6p1njmjD8ZPqw57He4aKuTCa sneLuAUiCmzXPPig/x+wFCKpTA== X-Received: by 2002:adf:8341:: with SMTP id 59mr3205749wrd.130.1615972386718; Wed, 17 Mar 2021 02:13:06 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id e18sm12695886wru.73.2021.03.17.02.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 02:13:06 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 26/36] scsi: isci: remote_device: Fix a bunch of doc-rot issues Date: Wed, 17 Mar 2021 09:12:20 +0000 Message-Id: <20210317091230.2912389-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317091230.2912389-1-lee.jones@linaro.org> References: <20210317091230.2912389-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/isci/remote_device.c:299: warning: Function parameter or member 'ihost' not described in 'isci_remote_device_not_ready' drivers/scsi/isci/remote_device.c:299: warning: Function parameter or member 'idev' not described in 'isci_remote_device_not_ready' drivers/scsi/isci/remote_device.c:299: warning: Function parameter or member 'reason' not described in 'isci_remote_device_not_ready' drivers/scsi/isci/remote_device.c:299: warning: Excess function parameter 'isci_host' description in 'isci_remote_device_not_ready' drivers/scsi/isci/remote_device.c:299: warning: Excess function parameter 'isci_device' description in 'isci_remote_device_not_ready' drivers/scsi/isci/remote_device.c:1015: warning: Function parameter or member 'idev' not described in 'sci_remote_device_destruct' drivers/scsi/isci/remote_device.c:1015: warning: Excess function parameter 'remote_device' description in 'sci_remote_device_destruct' drivers/scsi/isci/remote_device.c:1249: warning: Function parameter or member 'iport' not described in 'sci_remote_device_construct' drivers/scsi/isci/remote_device.c:1249: warning: Function parameter or member 'idev' not described in 'sci_remote_device_construct' drivers/scsi/isci/remote_device.c:1249: warning: Excess function parameter 'sci_port' description in 'sci_remote_device_construct' drivers/scsi/isci/remote_device.c:1249: warning: Excess function parameter 'sci_dev' description in 'sci_remote_device_construct' drivers/scsi/isci/remote_device.c:1275: warning: Function parameter or member 'iport' not described in 'sci_remote_device_da_construct' drivers/scsi/isci/remote_device.c:1275: warning: Function parameter or member 'idev' not described in 'sci_remote_device_da_construct' drivers/scsi/isci/remote_device.c:1311: warning: Function parameter or member 'iport' not described in 'sci_remote_device_ea_construct' drivers/scsi/isci/remote_device.c:1311: warning: Function parameter or member 'idev' not described in 'sci_remote_device_ea_construct' drivers/scsi/isci/remote_device.c:1453: warning: Function parameter or member 'idev' not described in 'sci_remote_device_start' drivers/scsi/isci/remote_device.c:1453: warning: Excess function parameter 'remote_device' description in 'sci_remote_device_start' drivers/scsi/isci/remote_device.c:1513: warning: Function parameter or member 'ihost' not described in 'isci_remote_device_alloc' drivers/scsi/isci/remote_device.c:1513: warning: Function parameter or member 'iport' not described in 'isci_remote_device_alloc' drivers/scsi/isci/remote_device.c:1513: warning: expecting prototype for This function builds the isci_remote_device when a libsas dev_found message(). Prototype was for isci_remote_device_alloc() instead drivers/scsi/isci/remote_device.c:1558: warning: Function parameter or member 'ihost' not described in 'isci_remote_device_stop' drivers/scsi/isci/remote_device.c:1558: warning: Function parameter or member 'idev' not described in 'isci_remote_device_stop' drivers/scsi/isci/remote_device.c:1558: warning: Excess function parameter 'isci_host' description in 'isci_remote_device_stop' drivers/scsi/isci/remote_device.c:1558: warning: Excess function parameter 'isci_device' description in 'isci_remote_device_stop' drivers/scsi/isci/remote_device.c:1592: warning: Function parameter or member 'dev' not described in 'isci_remote_device_gone' drivers/scsi/isci/remote_device.c:1592: warning: Excess function parameter 'domain_device' description in 'isci_remote_device_gone' drivers/scsi/isci/remote_device.c:1614: warning: Function parameter or member 'dev' not described in 'isci_remote_device_found' drivers/scsi/isci/remote_device.c:1614: warning: Excess function parameter 'domain_device' description in 'isci_remote_device_found' Cc: Artur Paszkiewicz Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/isci/remote_device.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) -- 2.27.0 diff --git a/drivers/scsi/isci/remote_device.c b/drivers/scsi/isci/remote_device.c index b1276f7e49c89..866950a02965d 100644 --- a/drivers/scsi/isci/remote_device.c +++ b/drivers/scsi/isci/remote_device.c @@ -288,8 +288,9 @@ enum sci_status isci_remote_device_terminate_requests( * isci_remote_device_not_ready() - This function is called by the ihost when * the remote device is not ready. We mark the isci device as ready (not * "ready_for_io") and signal the waiting proccess. -* @isci_host: This parameter specifies the isci host object. -* @isci_device: This parameter specifies the remote device +* @ihost: This parameter specifies the isci host object. +* @idev: This parameter specifies the remote device +* @reason: Reason to switch on * * sci_lock is held on entrance to this function. */ @@ -1000,7 +1001,7 @@ static void sci_remote_device_initial_state_enter(struct sci_base_state_machine /** * sci_remote_device_destruct() - free remote node context and destruct - * @remote_device: This parameter specifies the remote device to be destructed. + * @idev: This parameter specifies the remote device to be destructed. * * Remote device objects are a limited resource. As such, they must be * protected. Thus calls to construct and destruct are mutually exclusive and @@ -1236,8 +1237,8 @@ static const struct sci_base_state sci_remote_device_state_table[] = { /** * sci_remote_device_construct() - common construction - * @sci_port: SAS/SATA port through which this device is accessed. - * @sci_dev: remote device to construct + * @iport: SAS/SATA port through which this device is accessed. + * @idev: remote device to construct * * This routine just performs benign initialization and does not * allocate the remote_node_context which is left to @@ -1256,7 +1257,7 @@ static void sci_remote_device_construct(struct isci_port *iport, SCIC_SDS_REMOTE_NODE_CONTEXT_INVALID_INDEX); } -/** +/* * sci_remote_device_da_construct() - construct direct attached device. * * The information (e.g. IAF, Signature FIS, etc.) necessary to build @@ -1294,7 +1295,7 @@ static enum sci_status sci_remote_device_da_construct(struct isci_port *iport, return SCI_SUCCESS; } -/** +/* * sci_remote_device_ea_construct() - construct expander attached device * * Remote node context(s) is/are a global resource allocated by this @@ -1439,7 +1440,7 @@ enum sci_status isci_remote_device_resume_from_abort( * sci_remote_device_start() - This method will start the supplied remote * device. This method enables normal IO requests to flow through to the * remote device. - * @remote_device: This parameter specifies the device to be started. + * @idev: This parameter specifies the device to be started. * @timeout: This parameter specifies the number of milliseconds in which the * start operation should complete. * @@ -1501,10 +1502,11 @@ static enum sci_status isci_remote_device_construct(struct isci_port *iport, } /** + * isci_remote_device_alloc() * This function builds the isci_remote_device when a libsas dev_found message * is received. - * @isci_host: This parameter specifies the isci host object. - * @port: This parameter specifies the isci_port connected to this device. + * @ihost: This parameter specifies the isci host object. + * @iport: This parameter specifies the isci_port connected to this device. * * pointer to new isci_remote_device. */ @@ -1549,8 +1551,8 @@ void isci_remote_device_release(struct kref *kref) /** * isci_remote_device_stop() - This function is called internally to stop the * remote device. - * @isci_host: This parameter specifies the isci host object. - * @isci_device: This parameter specifies the remote device. + * @ihost: This parameter specifies the isci host object. + * @idev: This parameter specifies the remote device. * * The status of the ihost request to stop. */ @@ -1585,8 +1587,7 @@ enum sci_status isci_remote_device_stop(struct isci_host *ihost, struct isci_rem /** * isci_remote_device_gone() - This function is called by libsas when a domain * device is removed. - * @domain_device: This parameter specifies the libsas domain device. - * + * @dev: This parameter specifies the libsas domain device. */ void isci_remote_device_gone(struct domain_device *dev) { @@ -1606,7 +1607,7 @@ void isci_remote_device_gone(struct domain_device *dev) * device is discovered. A remote device object is created and started. the * function then sleeps until the sci core device started message is * received. - * @domain_device: This parameter specifies the libsas domain device. + * @dev: This parameter specifies the libsas domain device. * * status, zero indicates success. */