From patchwork Mon Mar 22 08:10:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avri Altman X-Patchwork-Id: 406395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDAC3C433C1 for ; Mon, 22 Mar 2021 08:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABEC961970 for ; Mon, 22 Mar 2021 08:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229961AbhCVIL7 (ORCPT ); Mon, 22 Mar 2021 04:11:59 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:24257 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbhCVIL3 (ORCPT ); Mon, 22 Mar 2021 04:11:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1616400689; x=1647936689; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cUuagZOBZJTVnPCEIZ+z5bzLhZ86jR9wf7gjbHylvd0=; b=ISx+x0/zs2bRYK1nnom4Z1/jWwBjvgckiKu6LP7BV8rfyFpyJFQKyeEC CVTVWCqdnrPd80xNambihOHr++p1ZArx8+/RYDhP4cVRuugd3VrtlFeQM o5xqaG5BxhDttqV6BDBVhV2HgcwDfz/18k0TedbWnJOQicNaMHpUKwtHr aIYxBdzTY76SR6lUmwQqrQcl2TtF60RbocN8x543Cj3eDzCiozBzLc8Fp h41j6TEKoyPASv/9WdzcZlhSmoW5KTlG5FSh6Yufdn82ungNOGp6h+ltn N/JUp4LJvTPgbish634sSITSndPpoEFRv5sqwXA0dmihXe47fr5h1Jm8Q A==; IronPort-SDR: drpKmCwgfpZ7opZKNgXQhSPXZPXtV9H7IKiDmI5ftFhnT1fNDQe6hY6psv2KAxgExdf1Y4FC7W Dh8PnKTl5fy33S3fZXjAaSb1Jl6c/dBpqv0ljbDklT4YSv9vpIRyw/BEl4FDzRK36IEDEqBDv1 eqCbRNEaRee6Jtod/tIiiaBL3lft0uaaUSQG1xP1kT/mhuvYsiF9qvRtMHjzIzXXbUkUp751K0 bshI62EysR3hQXEyA8MtZC5ohVpQ3Frfn9VkRtuVQRYsn+ZGwlGvNp/3QKqTc0OhEDdAcgyPx2 EbU= X-IronPort-AV: E=Sophos;i="5.81,268,1610380800"; d="scan'208";a="167165904" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 22 Mar 2021 16:11:27 +0800 IronPort-SDR: 0F48OyzF6oQWcZ4pKakytDbLDZRflgFVFyyM4FXHZaEdFacoSaBfcOVyfDmT3sZSl7Anrd8lKY VQfTejt1DwR9ItpaFg35jIUKI3RTeO0ZMPrRy0Tc91uJMDHoz8loNLML5icSMXqYwvgzhTbvzs S1zz/DR2XzU49W5fnxGVfFhEXmMqfw7asCkRGoXks4KlnD1YVmpg5sL6Yweju6l0fuPMZe8yRi Pk6dQbdueXG3JUdVKIUQVXO4SndzyIb24BpYLV5ndeLWxRkloq4IAbJWMjeeQ+Gu39aW98GXzd LA1CrNTxlAM/eBjnanjxjEsn Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 00:53:36 -0700 IronPort-SDR: 3G26GwDqxP6EX3IEg97mXjnATDMJiJ6VA9oSEoCuSv/NhIqiocOuKKZ2d7sOCf/C3TROTVGVOE 9C4iOaNxwS7eVhE/pxh4r2q2k4trIpLnVGpAFu/b7cCmag2Gi/b+Jkg3+xH4ekh6cMupow/FSe 3Xhn2l6XmDrQkHWTRPtSZfT3Hv6Z7e3GLpPGhOpzZdKiFe8rBgnXK/4jN54GgIDKuhkoO7A+/u uZ6Mscwdi8EB+CZ0cRArMBVD915C8PZY+sGPR2hz/sTw+qKYCBCxQvciR0byWvko3QsxcWYxe+ fcM= WDCIronportException: Internal Received: from bxygm33.sdcorp.global.sandisk.com ([10.0.231.247]) by uls-op-cesaip01.wdc.com with ESMTP; 22 Mar 2021 01:11:23 -0700 From: Avri Altman To: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, Bart Van Assche , yongmyung lee , Daejun Park , alim.akhtar@samsung.com, asutoshd@codeaurora.org, Zang Leigang , Avi Shchislowski , Bean Huo , cang@codeaurora.org, stanley.chu@mediatek.com, Avri Altman Subject: [PATCH v6 02/10] scsi: ufshpb: Add host control mode support to rsp_upiu Date: Mon, 22 Mar 2021 10:10:36 +0200 Message-Id: <20210322081044.62003-3-avri.altman@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210322081044.62003-1-avri.altman@wdc.com> References: <20210322081044.62003-1-avri.altman@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org In device control mode, the device may recommend the host to either activate or inactivate a region, and the host should follow. Meaning those are not actually recommendations, but more of instructions. On the contrary, in host control mode, the recommendation protocol is slightly changed: a) The device may only recommend the host to update a subregion of an already-active region. And, b) The device may *not* recommend to inactivate a region. Furthermore, in host control mode, the host may choose not to follow any of the device's recommendations. However, in case of a recommendation to update an active and clean subregion, it is better to follow those recommendation because otherwise the host has no other way to know that some internal relocation took place. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshpb.c | 34 +++++++++++++++++++++++++++++++++- drivers/scsi/ufs/ufshpb.h | 2 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index fb10afcbb49f..d4f0bb6d8fa1 100644 --- a/drivers/scsi/ufs/ufshpb.c +++ b/drivers/scsi/ufs/ufshpb.c @@ -166,6 +166,8 @@ static void ufshpb_set_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx, else set_bit_len = cnt; + set_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); + if (rgn->rgn_state != HPB_RGN_INACTIVE && srgn->srgn_state == HPB_SRGN_VALID) bitmap_set(srgn->mctx->ppn_dirty, srgn_offset, set_bit_len); @@ -235,6 +237,11 @@ static bool ufshpb_test_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx, return false; } +static inline bool is_rgn_dirty(struct ufshpb_region *rgn) +{ + return test_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); +} + static int ufshpb_fill_ppn_from_page(struct ufshpb_lu *hpb, struct ufshpb_map_ctx *mctx, int pos, int len, u64 *ppn_buf) @@ -713,6 +720,7 @@ static void ufshpb_put_map_req(struct ufshpb_lu *hpb, static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb, struct ufshpb_subregion *srgn) { + struct ufshpb_region *rgn; u32 num_entries = hpb->entries_per_srgn; if (!srgn->mctx) { @@ -726,6 +734,10 @@ static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb, num_entries = hpb->last_srgn_entries; bitmap_zero(srgn->mctx->ppn_dirty, num_entries); + + rgn = hpb->rgn_tbl + srgn->rgn_idx; + clear_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); + return 0; } @@ -1245,6 +1257,18 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, srgn_i = be16_to_cpu(rsp_field->hpb_active_field[i].active_srgn); + rgn = hpb->rgn_tbl + rgn_i; + if (hpb->is_hcm && + (rgn->rgn_state != HPB_RGN_ACTIVE || is_rgn_dirty(rgn))) { + /* + * in host control mode, subregion activation + * recommendations are only allowed to active regions. + * Also, ignore recommendations for dirty regions - the + * host will make decisions concerning those by himself + */ + continue; + } + dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "activate(%d) region %d - %d\n", i, rgn_i, srgn_i); @@ -1252,7 +1276,6 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, ufshpb_update_active_info(hpb, rgn_i, srgn_i); spin_unlock(&hpb->rsp_list_lock); - rgn = hpb->rgn_tbl + rgn_i; srgn = rgn->srgn_tbl + srgn_i; /* blocking HPB_READ */ @@ -1263,6 +1286,14 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, hpb->stats.rb_active_cnt++; } + if (hpb->is_hcm) { + /* + * in host control mode the device is not allowed to inactivate + * regions + */ + goto out; + } + for (i = 0; i < rsp_field->inactive_rgn_cnt; i++) { rgn_i = be16_to_cpu(rsp_field->hpb_inactive_field[i]); dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, @@ -1287,6 +1318,7 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, hpb->stats.rb_inactive_cnt++; } +out: dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "Noti: #ACT %u #INACT %u\n", rsp_field->active_rgn_cnt, rsp_field->inactive_rgn_cnt); diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index 7df30340386a..032672114881 100644 --- a/drivers/scsi/ufs/ufshpb.h +++ b/drivers/scsi/ufs/ufshpb.h @@ -121,6 +121,8 @@ struct ufshpb_region { /* below information is used by lru */ struct list_head list_lru_rgn; + unsigned long rgn_flags; +#define RGN_FLAG_DIRTY 0 }; #define for_each_sub_region(rgn, i, srgn) \