From patchwork Tue May 11 19:54:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kashyap Desai X-Patchwork-Id: 434608 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MIME_HEADER_CTYPE_ONLY, SPF_HELO_NONE, SPF_PASS, T_TVD_MIME_NO_HEADERS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3644BC433ED for ; Tue, 11 May 2021 19:52:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 085DE617C9 for ; Tue, 11 May 2021 19:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbhEKTxQ (ORCPT ); Tue, 11 May 2021 15:53:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbhEKTxE (ORCPT ); Tue, 11 May 2021 15:53:04 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5772DC06175F for ; Tue, 11 May 2021 12:51:57 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id bo23-20020a17090b0917b029015cb1f2fd59so401774pjb.2 for ; Tue, 11 May 2021 12:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=y/KkjsPZo3bbGvDr7TwQ0xxgINzAQD/trOaUz6mKgBk=; b=fLl+lUTFDniVk4bUNH0F70QC1iUU7zAqE6pUOWkoWvxhjefHRaGSAjzZHGR7BHko6n mlX1h+CGCXC4Bg+v9ie5It3I5wHmZKdsKezFfFGZ77tkZK/xsr4RkLlJsaM8i6EIVXQM 1zyBQzSBalePgt3Q1zHjNKSlFHym7RMVofLJA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=y/KkjsPZo3bbGvDr7TwQ0xxgINzAQD/trOaUz6mKgBk=; b=E+ppgMIu7jGC2IEOGDmloBQNeO9XZQeBPiOGpJ/h9t9StHuy9VRy8wYV9Ky1FxrZWv DnewUVZjxm65I5jwG/Faq+i7yu8pvUoDLyORVOVXewefMoXPMgVVPME1q40+PegYpnnl /LmOdbM1DqvaUEmmD+irFXfsHPkcsQPypfuonnwQkCxoLgzd2RVIrZWK+KV35UwOJcJR kpqhcfLR5ttIm/J8eUrxpfI2F8tRNGC6oloIfUwePZBZm9C6qqQXW7+2VANYMfoZqkxO 1CrJT8KRFTD8NC1w1AXBonIp/tp6Zy8zqnhTcl6ZLq5MUlt/ZND1XWJCGn0/jX3U1uqI +ZZg== X-Gm-Message-State: AOAM531iINm49uuRpw2yjk8zT9N4Cll2DG9gQTCC+OYjllUXuIXn0K03 +xJ04JSQxw5vhU9qZftSMC3Y+D2N31ez0WKhLq3FGqvH5GHCz2VIruUyPrfESOzNevquav3TY6s xIsz0U1ioq4fjUuXyOlRue+mwXSaacCZuqYKlGVxVqOxhqFqKzLwQzoOnBxw6+MLYFgZ5xO1Ymf TuEOcHNA== X-Google-Smtp-Source: ABdhPJyBrry7aITSITBcyKYz9yABM46u2PJP8BrYLqZL8UJO3RlU88WGtLMXXmvLg7nVe/9X7NlLIw== X-Received: by 2002:a17:90a:17c5:: with SMTP id q63mr21080877pja.136.1620762716430; Tue, 11 May 2021 12:51:56 -0700 (PDT) Received: from drv-bst-rhel8.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id b3sm6317581pfv.61.2021.05.11.12.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 12:51:55 -0700 (PDT) From: Kashyap Desai To: linux-scsi@vger.kernel.org Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, steve.hagan@broadcom.com, peter.rivera@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, Kashyap Desai , sathya.prakash@broadcom.com Subject: [PATCH v4 15/24] mpi3mr: allow certain commands during pci-remove hook Date: Wed, 12 May 2021 01:24:14 +0530 Message-Id: <20210511195423.2134562-16-kashyap.desai@broadcom.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210511195423.2134562-1-kashyap.desai@broadcom.com> References: <20210511195423.2134562-1-kashyap.desai@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This patch allows SSU and Sync Cache commands to be sent to the controller instead of driver returning DID_NO_CONNECT during driver unload to flush any cached data from the drive. Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl Reviewed-by: Himanshu Madhani Cc: sathya.prakash@broadcom.com --- drivers/scsi/mpi3mr/mpi3mr_os.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c index 786128da1b54..992a0e4d37d1 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -2776,6 +2776,26 @@ static int mpi3mr_target_alloc(struct scsi_target *starget) return retval; } +/** + * mpi3mr_allow_scmd_to_fw - Command is allowed during shutdown + * @scmd: SCSI Command reference + * + * Checks whether a cdb is allowed during shutdown or not. + * + * Return: TRUE for allowed commands, FALSE otherwise. + */ + +inline bool mpi3mr_allow_scmd_to_fw(struct scsi_cmnd *scmd) +{ + switch (scmd->cmnd[0]) { + case SYNCHRONIZE_CACHE: + case START_STOP: + return true; + default: + return false; + } +} + /** * mpi3mr_qcmd - I/O request despatcher * @shost: SCSI Host reference @@ -2811,7 +2831,8 @@ static int mpi3mr_qcmd(struct Scsi_Host *shost, goto out; } - if (mrioc->stop_drv_processing) { + if (mrioc->stop_drv_processing && + !(mpi3mr_allow_scmd_to_fw(scmd))) { scmd->result = DID_NO_CONNECT << 16; scmd->scsi_done(scmd); goto out;