diff mbox series

[v2] scsi: zfcp: Fix a double put in zfcp_port_enqueue

Message ID 20230922074631.9408-1-dinghao.liu@zju.edu.cn
State New
Headers show
Series [v2] scsi: zfcp: Fix a double put in zfcp_port_enqueue | expand

Commit Message

Dinghao Liu Sept. 22, 2023, 7:46 a.m. UTC
When device_register() fails, zfcp_port_release() will be called
after put_device(). As a result, zfcp_ccw_adapter_put() will be
called twice: one in zfcp_port_release() and one in the error path
after device_register(). So the reference on the adapter object is
doubly put, which may lead to a premature free. Fix this by adjusting
the error tag after device_register().

Fixes: f3450c7b9172 ("[SCSI] zfcp: Replace local reference counting with common kref")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>


v2: -Improve the patch description.
    -Add a new label 'err_register' to unify code style.
 drivers/s390/scsi/zfcp_aux.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
index df782646e856..ad0ef9546501 100644
--- a/drivers/s390/scsi/zfcp_aux.c
+++ b/drivers/s390/scsi/zfcp_aux.c
@@ -552,7 +552,7 @@  struct zfcp_port *zfcp_port_enqueue(struct zfcp_adapter *adapter, u64 wwpn,
 	if (device_register(&port->dev)) {
-		goto err_out;
+		goto err_register;
@@ -565,5 +565,6 @@  struct zfcp_port *zfcp_port_enqueue(struct zfcp_adapter *adapter, u64 wwpn,
 	return ERR_PTR(retval);