From patchwork Mon Apr 12 03:47:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zev Weiss X-Patchwork-Id: 419785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E836C433B4 for ; Mon, 12 Apr 2021 03:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5791A6109E for ; Mon, 12 Apr 2021 03:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235386AbhDLDrp (ORCPT ); Sun, 11 Apr 2021 23:47:45 -0400 Received: from thorn.bewilderbeest.net ([71.19.156.171]:38967 "EHLO thorn.bewilderbeest.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235261AbhDLDrp (ORCPT ); Sun, 11 Apr 2021 23:47:45 -0400 Received: from hatter.bewilderbeest.net (unknown [IPv6:2600:6c44:7f:ba20::7c6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id 60AF24DC; Sun, 11 Apr 2021 20:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1618199247; bh=PchFdXcg+941tH+XkYeqz92HXenAc27JmxDyUQQKTdw=; h=From:To:Cc:Subject:Date:From; b=S3GeX56EyvZ0kf4dfQG1TfthRJG2RhWY4/aC4WQMzC4QioL2l3CYDLUl2+SD5Uwbx rPt/Gipv09iozsgYBpvOJjTBBOSq6bJrm+eCimGEZj0nxq8yccex/RJW5smHH1z8Qk AOzdcLdSlymvODJ3uxxYcMYFQnQ/8p1ALVLpdVXk= From: Zev Weiss To: Joel Stanley Cc: openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Andrew Jeffery , Zev Weiss , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , Rob Herring , devicetree@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v6 0/4] serial: 8250_aspeed_vuart: generalized DT properties Date: Sun, 11 Apr 2021 22:47:08 -0500 Message-Id: <20210412034712.16778-1-zev@bewilderbeest.net> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org This series generalizes the aspeed-vuart driver's device tree properties to cover all the attributes it currently exposes via sysfs. The aspeed,sirq-polarity-sense property was a bit of a design mistake in that it ties Aspeed VUART SIRQ polarity to SCU register bits that aren't really inherently related to it; the first patch in this series deprecates it (though we hope to eventually remove it). The rest of the series adds two new properties, aspeed,lpc-io-reg and aspeed,lpc-interrupts. The latter allows describing the SIRQ polarity (along with the interrupt number) directly, providing a simpler replacement for aspeed,sirq-polarity-sense. Changes since v5 [4]: - corrected stale DT property name in commit message - factored aspeed_vuart_map_irq_polarity() out of aspeed_vuart_probe() - fixed commit message subject line prefixes Changes since v4 [3]: - fixed commit reference formatting in commit message Changes since v3 [2]: - renamed properties to match aspeed,ast2400-kcs-bmc Changes since v2 [0]: - expanded to also handle sirq number and lpc address in addition to sirq polarity - added default settings if DT properties not specified - refactored existing sysfs code slightly, adding range checks - cleaned up 'make dt_binding_check' warnings Changes since v1 [1]: - deprecate and retain aspeed,sirq-polarity-sense instead of removing it - drop e3c246d4i dts addition from this series [0] https://lore.kernel.org/openbmc/20210401005702.28271-1-zev@bewilderbeest.net/ [1] https://lore.kernel.org/openbmc/20210330002338.335-1-zev@bewilderbeest.net/ [2] https://lore.kernel.org/openbmc/20210402004716.15961-1-zev@bewilderbeest.net/ [3] https://lore.kernel.org/openbmc/20210402182724.20848-1-zev@bewilderbeest.net/ [4] https://lore.kernel.org/openbmc/20210408011637.5361-1-zev@bewilderbeest.net/ Zev Weiss (4): dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense serial: 8250_aspeed_vuart: refactor sirq and lpc address setting code serial: 8250_aspeed_vuart: add aspeed,lpc-io-reg and aspeed,lpc-interrupts DT properties dt-bindings: serial: 8250: add aspeed,lpc-io-reg and aspeed,lpc-interrupts .../devicetree/bindings/serial/8250.yaml | 28 ++++- drivers/tty/serial/8250/8250_aspeed_vuart.c | 102 ++++++++++++++---- 2 files changed, 109 insertions(+), 21 deletions(-)