mbox series

[00/11] serial: pic32: cleanup

Message ID 20220503063122.20957-1-jslaby@suse.cz
Headers show
Series serial: pic32: cleanup | expand


Jiri Slaby May 3, 2022, 6:31 a.m. UTC
This series:
* ! re-enables disabled irqs in pic32_uart_startup() (*)
* removes unused/unneeded stuff
* merges a separate .h into .c
* avoids potentially broken macros
* performs other cleanups

(*) I'm not sure how this driver could work until now. Maybe there is
some coincidental enablement of irqs I don't see. A contact to people
from microchip would be highly appreciated to check with them.

Jiri Slaby (11):
  serial: pic32: remove unused items from the header
  serial: pic32: move header content to .c
  serial: pic32: remove constants from struct pic32_sport
  serial: pic32: simplify clk handling
  serial: pic32: simplify pic32_sport::enable_tx_irq handling
  serial: pic32: remove pic32_get_port() macro
  serial: pic32: convert to_pic32_sport() to an inline
  serial: pic32: don't assign pic32_sport::cts_gpio twice
  serial: pic32: don't zero members of kzalloc-ated structure
  serial: pic32: free up irq names correctly
  serial: pic32: restore disabled irqs in pic32_uart_startup()

 drivers/tty/serial/pic32_uart.c | 159 +++++++++++++++++++++++---------
 drivers/tty/serial/pic32_uart.h | 125 -------------------------
 2 files changed, 116 insertions(+), 168 deletions(-)
 delete mode 100644 drivers/tty/serial/pic32_uart.h