mbox series

[v4,0/7] Fixes and improvements for RS485

Message ID 20231018174840.28977-1-l.sanfilippo@kunbus.com
Headers show
Series Fixes and improvements for RS485 | expand

Message

Lino Sanfilippo Oct. 18, 2023, 5:48 p.m. UTC 
The following series includes some fixes and improvements around RS485 in
the serial core and UART drivers:

Patch 1: Do not hold the port lock when setting rx-during-tx GPIO
Patch 2: set missing supported flag for RX during TX GPIO
Patch 3: fix sanitizing check for RTS settings
Patch 4: make sure RS485 is cannot be enabled when it is not supported
Patch 5: imx: do not set RS485 enabled if it is not supported
Patch 6: omap: do not override settings for rs485 support
Patch 7: exar: set missing RS485 supported flag

Changes in v4:
- add comment for function uart_set_rs485_gpios after hint from Hugo
- correct commit message as pointed out by Hugo
- rephrase commit messages
- add patch 7 after discussion with Ilpo

Changes in v3
- Drop patch "Get rid of useless wrapper pl011_get_rs485_mode()" as
  requested by Greg

Changes in v2:
- add missing 'Fixes' tags as requested by Greg
- corrected a typo as pointed out by Hugo
- fix issue in imx driver in the serial core as suggested by Uwe
- partly rephrase some commit messages
- add patch 7

Lino Sanfilippo (7):
  serial: Do not hold the port lock when setting rx-during-tx GPIO
  serial: core: set missing supported flag for RX during TX GPIO
  serial: core: fix sanitizing check for RTS settings
  serial: core: make sure RS485 cannot be enabled when it is not
    supported
  serial: core, imx: do not set RS485 enabled if it is not supported
  serial: omap: do not override settings for RS485 support
  serial: 8250_exar: Set missing rs485_supported flag

 drivers/tty/serial/8250/8250_exar.c |  5 +--
 drivers/tty/serial/imx.c            |  8 -----
 drivers/tty/serial/omap-serial.c    |  8 ++---
 drivers/tty/serial/serial_core.c    | 53 +++++++++++++++++++++--------
 drivers/tty/serial/stm32-usart.c    |  5 +--
 5 files changed, 46 insertions(+), 33 deletions(-)


base-commit: 58720809f52779dc0f08e53e54b014209d13eebb

Comments

Greg KH Oct. 27, 2023, 11:03 a.m. UTC | #1 
On Wed, Oct 18, 2023 at 07:48:33PM +0200, Lino Sanfilippo wrote:
> The following series includes some fixes and improvements around RS485 in
> the serial core and UART drivers:
> 
> Patch 1: Do not hold the port lock when setting rx-during-tx GPIO
> Patch 2: set missing supported flag for RX during TX GPIO
> Patch 3: fix sanitizing check for RTS settings
> Patch 4: make sure RS485 is cannot be enabled when it is not supported
> Patch 5: imx: do not set RS485 enabled if it is not supported
> Patch 6: omap: do not override settings for rs485 support
> Patch 7: exar: set missing RS485 supported flag
> 
> Changes in v4:
> - add comment for function uart_set_rs485_gpios after hint from Hugo
> - correct commit message as pointed out by Hugo
> - rephrase commit messages
> - add patch 7 after discussion with Ilpo

There's a lot of fuzz for this series against my current tree, so much
so I don't feel comfortable taking it right now.  Can you resend it
after 6.7-rc1 is out and you have rebased it against that?  If these
really are all bugfixes, we can still get them into 6.7-final then.

thanks,

greg k-h