| Message ID | 20240418135737.3659498-1-rilian.la.te@ya.ru |
|---|---|
| Headers | show |
| Series | add support for EXAR XR20M1172 UART | expand |
On Thu, Apr 18, 2024 at 04:57:32PM +0300, Konstantin Pugin wrote: > From: Konstantin Pugin <ria.freelander@gmail.com> > > Hardware supports both modes, but after The hardware "both"? Please elaborate, like "The hardware supports both (A and B) modes, ..." > commit 4afeced55baa ("serial: core: fix sanitizing check for RTS settings") the commit > we always end up with SER_RS485_RTS_AFTER_SEND and always write in write to > register SC16IS7XX_EFCR_RTS_INVERT_BIT, the register > which breaks some hardware using these chips, Please, rewrap these lines to be approximately same width. Yes, you may split commit over the lines in the body of the commit message, but tags (like Fixes). Also it seems you forgot to add Vladimir's tags. It's your responsibility to do that if you send a new version with only cosmetic changes done.
From: Konstantin Pugin <ria.freelander@gmail.com> EXAR XR20M1172 UART is mostly SC16IS762-compatible, but it has additional register which can change UART multiplier to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this flag to guard access to its specific DLD register. It seems than other EXAR SPI UART modules also have this register, but I tested only XR20M1172. Changes in v2: use full name in git authorship Konstantin Pugin (3): serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND serial: sc16is7xx: Add bindings documentation for EXAR XR20M1172 UART serial: sc16is7xx: add support for EXAR XR20M1172 UART .../bindings/serial/nxp,sc16is7xx.yaml | 1 + drivers/tty/serial/sc16is7xx.c | 56 +++++++++++++++++-- 2 files changed, 53 insertions(+), 4 deletions(-)