| Message ID | 20240603152601.3689319-1-hugo@hugovil.com |
|---|---|
| Headers | show |
| Series | serial: sc16is7xx: Kconfig fixes after I2C/SPI driver split | expand |
Hi Hugo, On Mon, Jun 3, 2024 at 5:26 PM Hugo Villeneuve <hugo@hugovil.com> wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Commit d49216438139 > ("serial: sc16is7xx: split into core and I2C/SPI parts (core)") > removed Kconfig SPI_MASTER or I2C dependency for SERIAL_SC16IS7XX (core). > This removal was done because I inadvertently misinterpreted some review > comments. > > Because of that, the driver question now pops up if both I2C and > SPI_MASTER are disabled. > > Re-add Kconfig SPI_MASTER or I2C dependency to fix the problem. > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: d49216438139 ("serial: sc16is7xx: split into core and I2C/SPI parts (core)") > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Thanks for your patch! > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1025,6 +1025,7 @@ config SERIAL_SCCNXP_CONSOLE > > config SERIAL_SC16IS7XX > tristate "NXP SC16IS7xx UART support" > + depends on SPI_MASTER || I2C You may want to add "|| COMPILE_TEST". > select SERIAL_CORE > select SERIAL_SC16IS7XX_SPI if SPI_MASTER > select SERIAL_SC16IS7XX_I2C if I2C Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Tue, 4 Jun 2024 09:09:12 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Hugo, > > On Mon, Jun 3, 2024 at 5:26 PM Hugo Villeneuve <hugo@hugovil.com> wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Commit d49216438139 > > ("serial: sc16is7xx: split into core and I2C/SPI parts (core)") > > removed Kconfig SPI_MASTER or I2C dependency for SERIAL_SC16IS7XX (core). > > This removal was done because I inadvertently misinterpreted some review > > comments. > > > > Because of that, the driver question now pops up if both I2C and > > SPI_MASTER are disabled. > > > > Re-add Kconfig SPI_MASTER or I2C dependency to fix the problem. > > > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Fixes: d49216438139 ("serial: sc16is7xx: split into core and I2C/SPI parts (core)") > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Thanks for your patch! > > > --- a/drivers/tty/serial/Kconfig > > +++ b/drivers/tty/serial/Kconfig > > @@ -1025,6 +1025,7 @@ config SERIAL_SCCNXP_CONSOLE > > > > config SERIAL_SC16IS7XX > > tristate "NXP SC16IS7xx UART support" > > + depends on SPI_MASTER || I2C > > You may want to add "|| COMPILE_TEST". Hi Geert, I will add this to my TODO list, since this patch series is already in Greg's tty tree. Hugo > > > select SERIAL_CORE > > select SERIAL_SC16IS7XX_SPI if SPI_MASTER > > select SERIAL_SC16IS7XX_I2C if I2C > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Hello, this patch series brings some Kconfig fixes to the sc16is7xx driver. These fixes are related to the I2C/SPI driver split: https://lore.kernel.org/all/20240430090333.5c5f029553cabcdf699310cb@hugovil.com/ I have tested the changes on a custom board with two SC16IS752 DUART over a SPI interface using a Variscite IMX8MN NANO SOM. The four UARTs are configured in RS-485 mode. I did not test the change on a SC16is7xx using I2C interface, as my custom board is only using SPI. Thank you. Hugo Villeneuve (2): serial: sc16is7xx: rename Kconfig CONFIG_SERIAL_SC16IS7XX_CORE serial: sc16is7xx: re-add Kconfig SPI or I2C dependency drivers/tty/serial/Kconfig | 3 ++- drivers/tty/serial/Makefile | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) base-commit: c3f38fa61af77b49866b006939479069cd451173