Message ID | 20241001125033.10625-1-johan+linaro@kernel.org |
---|---|
Headers | show |
Series | serial: qcom-geni: fix receiver enable | expand |
On Tue, Oct 01, 2024 at 03:36:57PM +0200, Bartosz Golaszewski wrote: > On Tue, Oct 1, 2024 at 2:51 PM Johan Hovold <johan+linaro@kernel.org> wrote: > > > > A commit adding back the stopping of tx on port shutdown failed to add > > back the locking which had also been removed by commit e83766334f96 > > ("tty: serial: qcom_geni_serial: No need to stop tx/rx on UART > > shutdown"). > > > > Holding the port lock is needed to serialise against the console code, > > which may update the interrupt enable register and access the port > > state. > > > > Fixes: d8aca2f96813 ("tty: serial: qcom-geni-serial: stop operations in progress at shutdown") > > Fixes: 947cc4ecc06c ("serial: qcom-geni: fix soft lockup on sw flow control and suspend") > > Cc: stable@vger.kernel.org # 6.3 > > Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > I already reviewed this[1]. I suggest using b4 for automated tag pickup. There were changes in v2 so I dropped your tag on purpose. Johan