mbox series

[RFC,0/2] serial: kgdboc: convert to the faux device interface

Message ID 20250506125133.108786-1-nicolescu.roxana@protonmail.com
Headers show
Series serial: kgdboc: convert to the faux device interface | expand

Message

Roxana Nicolescu May 6, 2025, 12:51 p.m. UTC 
The kgdboc uses a "fake" platform device to handle tty drivers showing
up late. In case the tty device is not detected during probe, it will
return EPROBE_DEFER which means the probe will be called later when the
tty device might be there. Before this, the kgdboc driver
would be initialized early in the process (useful for early boot
debugging) but then the tty device wouldn't be there, and retry wouldn't be
done later. For a better explanation, see commit
'68e55f61c138: ("kgdboc: Use a platform device to handle tty drivers
showing up late")'.

This replaces the platform_device usage with faux_device which was
introduced recently for scenarios like this, where there is not real
platform device needed. Moreover, it makes the code cleaner than before.

To acomodate this, I had to change the faux_device implementation. When
the device is created, if probe failed and the driver did not bind to the
device, it will be destroyed, therefore probe won't be retried later in
case of EPROBE_DEFER. Now, the faux device is destroyed only if probe
failed with something other than -EPROBE_DEFER.

I am kindly asking for your advice here, because I am not sure this is
100% the intended usage of faux_device. In the kgdboc driver, the
platform device is for sure fake, but if we're gonna use it for deferred
probe, isn't it defeating the purpose of a faux device not being
attached to real hardware? I also checked the previous discussions when
the faux device was introduced and some people even argue than having
probe and remove functions is also a bit contradictory.
Let me know what you think.

Roxana Nicolescu (2):
  driver core: faux: create the device if probe() is deferred too
  serial: kgdboc: convert to use faux_device

 drivers/base/faux.c         | 10 +++++---
 drivers/tty/serial/kgdboc.c | 50 +++++++++++--------------------------
 2 files changed, 21 insertions(+), 39 deletions(-)