diff mbox series

[15/26] serial: mpc52xx_uart: drop low-latency workaround

Message ID 20210421095509.3024-16-johan@kernel.org
State New
Headers show
Series tty: drop low-latency workarounds | expand

Commit Message

Johan Hovold April 21, 2021, 9:54 a.m. UTC
Commit fbe543b412ce ("Fix a potential issue in mpc52xx uart driver")
worked around the infamous low_latency behaviour of
tty_flip_buffer_push() by simply dropping and reacquiring the port lock
in the interrupt handler.

Since commit a9c3f68f3cd8 ("tty: Fix low_latency BUG"),
tty_flip_buffer_push() always schedules a work item to push data to the
line discipline and there's no need to keep any low_latency hacks around.

Signed-off-by: Johan Hovold <johan@kernel.org>
 drivers/tty/serial/mpc52xx_uart.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series


diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c
index af1700445251..2704dc988e4a 100644
--- a/drivers/tty/serial/mpc52xx_uart.c
+++ b/drivers/tty/serial/mpc52xx_uart.c
@@ -1421,9 +1421,7 @@  mpc52xx_uart_int_rx_chars(struct uart_port *port)
-	spin_unlock(&port->lock);
-	spin_lock(&port->lock);
 	return psc_ops->raw_rx_rdy(port);