From patchwork Mon Aug 26 15:42:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 822620 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.85.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583CA189509 for ; Mon, 26 Aug 2024 15:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.85.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724686928; cv=none; b=szqnsQllWlriavrAk/pe99h0Do4UjNrn5SDxS2kLP+S/grOp+LLpvj/5zNsCb3qr9SK/XevRCvb0lk+XPptn2kr4lAQWjm09yC+JGjZKKgDVQjHBonzPrqlw93XZWk/a8CfwpT+AJN+nrWDlc9g3wKNrzDUBM+k08VvyGbMwm9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724686928; c=relaxed/simple; bh=xlivHA5ql1it85zYsrc8TIQfQPV0ClIQCYh3/vL6HX4=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=EE1Zq2x8lQcfd3cUKDUcW8rQpj5a4w5RQR2LtXiTbHPUk0dE/K5Cq5MFoj0Da+YpNwhY1KvIYQ1vCt+KrdnyIXrKFbZb3CaZzYZJWM5+aR9p5TYnb9j3z+8TbF/5Qh/aWf/zTrXewbwWY47OCYxDgvDbVbbxYSLK6Rz+VRg9BIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=jYvB0l4T; arc=none smtp.client-ip=185.58.85.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="jYvB0l4T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1724686925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c728VZv6v7K8l+pge5+f5HkAlqnOFc8OqhDpJIZ4pus=; b=jYvB0l4TCns0hEy25y3gM2LNnOYAd5tJnRUVgMXvKwD7HdiarcdaR+9cPP+NxYlwFQeA62 jbuVoKkQhvZJmcXN5atpv7mUVvxEzgYvV/drWF8oIkgTtlwEbuQphiSzIqsUUMsIyhV/gQ oJz/+YfrxZ5+i3TLhVj1Q3a13hVJl8U= Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01lp2045.outbound.protection.outlook.com [104.47.85.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-306-2Ks6rO9TN5CismZe_a-SOg-2; Mon, 26 Aug 2024 16:42:04 +0100 X-MC-Unique: 2Ks6rO9TN5CismZe_a-SOg-2 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) by CWXP123MB6192.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1aa::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.24; Mon, 26 Aug 2024 15:42:03 +0000 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f]) by CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f%4]) with mapi id 15.20.7897.021; Mon, 26 Aug 2024 15:42:03 +0000 Message-ID: <2986a485-935d-4ab2-9a16-4a85288aa15a@camlingroup.com> Date: Mon, 26 Aug 2024 17:42:01 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants From: Lech Perczak To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , Pawel Lenkow , Kirill Yatsenko References: <9c1f8fd4-a2a5-4f92-9e86-2cf0103b1908@camlingroup.com> In-Reply-To: <9c1f8fd4-a2a5-4f92-9e86-2cf0103b1908@camlingroup.com> X-ClientProxiedBy: WA2P291CA0007.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::10) To CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWXP123MB5267:EE_|CWXP123MB6192:EE_ X-MS-Office365-Filtering-Correlation-Id: 01ebb7e1-55b0-4366-f868-08dcc5e5a1ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014 X-Microsoft-Antispam-Message-Info: =?utf-8?q?+gldsdAE3ZEsSM3lBdasVtNaTKiMaEx?= =?utf-8?q?ZpRtRqLFjCTvlPrVaru+e71wNtHeIHjZ1CC1dHIQ92ILqIoes/azyhZpfHAx+6Q1j?= =?utf-8?q?jsdt7foZHSK5+4ZVL6HREDj2AOAAlBSjoPQ/g+VlkAN+3NiZNv0CBFh8FHcpTGKAg?= =?utf-8?q?P+7oNp1aCYiORB8coHMh+M7lqEcGTKsZOYZ9eC9zEs9WdW84fc7WF2QngjGrRqw3D?= =?utf-8?q?YoZeJY2YCRbkSe24SYyigtwtKHoARX3ehJ7DAef4l2p4JiJrAiiTip4E2ww2wjzFH?= =?utf-8?q?/dyQC+T5da1ZU/Wsece8vjW6QXza/52BDr4QIS6xEh91GKR2MDwWvWZc5Ims9If24?= =?utf-8?q?9PseUhnGOFD35Fl3FJlwLFHJ3m1Xzo/iTKnXw1fPATzGNUymhpIeORKTpPZrwT0Fn?= =?utf-8?q?jNyq93QUCLFU0xBh6Fox+3qD4oYojFxc6LoNPN6f222TApULwawoOkfch7GWqPfNC?= =?utf-8?q?dw+K06lkLoNvgIg4cFiENv5N2tEMVdmezmiR89nYIoMLKbXR8bf6bFCHWTi7PglUn?= =?utf-8?q?WZ4QrIa+7x+IZe2mXwjzXsf3g56pGFIby7aldlSAZZDMG6W2CcERar1sgRAg0f2yJ?= =?utf-8?q?XeF9jkC7MFsKLTqRNX8+vUKP99L4KqgaZmMVKvRo5/07VFDXfFPSGpOAEwPCbZEw2?= =?utf-8?q?92gwt9/f8VTAqcaH2D39GsjlYSUMMGX7ssXl/aTUUhS/+Q+74TWLFzl6NcqRs2rLG?= =?utf-8?q?2StFJ/T8tTh8dfRXGO4Vvt1jkqqF7M6QMh7nbdW85MjvyxgANzHS3qJgeyKsD5vo5?= =?utf-8?q?SucCCfu+rXOyB6IBsgsR5gbEAt1lX1OJrfJAEHJuAja8CwFJLCl/VHFNE+pDNaAhm?= =?utf-8?q?mUIcq3OsGWdj1JKTOmgbIayiEqLKBHagCtFq62tVMRK6gS84zqSLbjcYnxtrgdNki?= =?utf-8?q?SABeNo8Xw1sn5a3qtipYbN+TUmtmSbjcY+96Ow7uqvPhUjkDksNL1IcfmWH5iFHrN?= =?utf-8?q?w//MteYfUMHSTKn0JrDkAMklwp3ZaJOCrt5/yBrZst4boYn6FgdUoOJIJruEHPvSH?= =?utf-8?q?zQ4o6jd6d2GhVoCYxqmC/+DmTBR736iM6UQWhzeVWbk358PwouvPIjdz5lxMR7BF/?= =?utf-8?q?oNr0/m6u3vXp7kT9t2fadgWtYN3siqEdAQsTFCxpjTL7kin+ywftFETThiApiOzqQ?= =?utf-8?q?KZpvAi0/WQ4KycNCFJ2brE6pTqTFYEAMRxlP6krD55/AptCaTlAXnOaqDMdYsJ0P/?= =?utf-8?q?wcBOsBFSSqQM1mjnRF4gtOp/wDPHOwqd/fvAJA3pea9i/hG9y96MKRCNIGBDopM0g?= =?utf-8?q?K9pUVX7iSJ+lxlVN3xO5Fu/3TlEja444O8g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NcsuFbmXqKPuggp5WZ207HTzWI53?= =?utf-8?q?RsHggPW0Ab+6AnXTM9lPO6BkByJ5YyHmnfBj0tFf46oAcsNYgNv9/lVMK2kFq9VlH?= =?utf-8?q?3W1H845Pe5zH/NIRQKAj3+Kh1w+wjMtPTSJAdHu5YxlxVkPYATCPZ6yBTz+Ehcieg?= =?utf-8?q?o4cjrUTiwivUgRXU4+3ZObZJtFmup8KzGZQoQPw2h+l3XXgNI+Eekl+oIwYHU0zFL?= =?utf-8?q?6/Tk4tzwahABoF6UYiZUAHydsJwzGsNsA29MAV+sxdvUoD7WYnTbnUBvfvephdtNM?= =?utf-8?q?gPJXrLfMa9jmSAobpw65zEHxOCwYXX2T8wKGK2OXJp2qq+HHxrVoqqnVr1ohVBR14?= =?utf-8?q?IFQbbnTTHk/qxzsz3bfdI66OmbMkjX5euqkxcapG41m01qydIZkhcBz0K3pgt1XpE?= =?utf-8?q?d64zzu9DTrK+3yWasmxszWpe33NMaiBG6SH7CQXTVO4Objnt8/FaDmxUj1y9Zmn9Z?= =?utf-8?q?aEHyWQ9I7VhgghJ/XyAXDR8qGf3WeEmvqxsr+ObFAFbqncbHys9yfODShHYIhd5Dj?= =?utf-8?q?BZI7nFGVS6It2klluQmp+VMOdImM5pWleN2Z3UtgOJYY6590PFpFmCEYHOgB1TSNu?= =?utf-8?q?6adLYcOPcom+nMX5y7XrlMQhoMrqCA3hTaP4OF3qo3um6DmXVzc4ca0QBXzOoUJ2R?= =?utf-8?q?0odz0lG5kZzmGe96jlrXyjEyuvNwv0Cbvl5wJo99roL8zoPd9dD8coYLoUZoYsmaP?= =?utf-8?q?AZV/PZFnCjA3njwHmhgYhmeQeR8djIy1TSjoRoiKkFLpirtia5vU/PKhct0tquSPD?= =?utf-8?q?rKTBNz9edzQIJAqDzgdk9Periho1vUEpiWv6K613IMY76Z3NxKs5ZpQwCW5BP3uMB?= =?utf-8?q?pSTbb8MfdL9Kfq22yPKMuBr8YXooZa6Nqy2aCYBaWozuqynTLQoNxVPkJlg7F7p7L?= =?utf-8?q?Tt0nJ1JlOlcloZP+d9K0tmO+SSenI4bf3Yh3gUbYl17nvroUQESMDjMvtqw6Z0u/7?= =?utf-8?q?XYtBQ1erBO8i4indCtYGyn5BVo9+jkAjHVXnnDzWcYRqVZRO1tB20SUa8o9Mpv87k?= =?utf-8?q?9qAI42MRO2MI5tiMK+7K0KVapy8fcGYjDD8sUdAHbf7Kb1pZ26OdGKuaVOqoEZ99X?= =?utf-8?q?c4CCMUXITI3+KfIC0vXvQiV/+Jp2HSbAfKo5ofDox4xE33NkCITSKoZeIMWM/GJj4?= =?utf-8?q?wEzyfPSEB+VHl+D78XtJQSkSGQDxVZS6piSQRA4xXEOV2XfIcuGryamRDklt0YJjb?= =?utf-8?q?pUOEDg5XRJnmkWeDxrAI0speIiCC6mUq12MNd0Fw+whKcLD5CZCgI9mh+/9+rid2l?= =?utf-8?q?EkPOrnYGPdvMWOif/PYc7GNvth/QLoWrP58Qxgif2dn82EiPq0Aejs3ArSSBvWBtN?= =?utf-8?q?Zl5XeXkNGe8ulwgiak9btjSbNqeHTt/bmuUkWSR4ECKYJ3l2LGfWBKhZ80bK74z/z?= =?utf-8?q?YRIS6Elxd2HdpBi255l+4jeBWv8LBLX9gqe6FkdlYSfdFOW0p8H+KRjII6UDqsD48?= =?utf-8?q?Lln2AynnYum2xyUoIp+ir5E0y8BkfmlgQDc4A+VoaNg4GVz3LuIIXKZaN9p6m4mdc?= =?utf-8?q?h0hHQebi/eSN4BiaarG+QGB8FbB32Tvrjw=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01ebb7e1-55b0-4366-f868-08dcc5e5a1ff X-MS-Exchange-CrossTenant-AuthSource: CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2024 15:42:03.7075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: morkmiD8PkL+XwU91Tn8GwrGwhgy+LbnHsLts5x0sZ3m+i8hG6frkS2JQIQMYUN6Gh+wlQ2cgjyyj0Qzhtrio/f2s039JzDXevHZ4GvfYWM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB6192 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which don't match the datasheet - fix them. At the same time remove comments for individual constants, as they add nothing to the definitions themselves. Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8a2020f9930e..36b7c682ae94 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -266,9 +266,9 @@ * and writing to IER[7:4], * FCR[5:4], MCR[7:5] */ -#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) /* SWFLOW bit 3 */ -#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) /* SWFLOW bit 2 - * +#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) +#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) + /* * SWFLOW bits 3 & 2 table: * 00 -> no transmitter flow * control @@ -280,10 +280,10 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */ -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3 - * - * SWFLOW bits 3 & 2 table: +#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) +#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) + /* + * SWFLOW bits 1 & 0 table: * 00 -> no received flow * control * 01 -> receiver compares