From patchwork Thu Aug 8 16:00:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 817994 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.85.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D5DD8003F for ; Thu, 8 Aug 2024 16:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.85.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723132812; cv=none; b=ny2+vgNI9ws8xF6hEHB5UIE6d5dPwIC6jilm8eLx/+8tQ9SArC1jh9ZWE9DtbqzXeSmdPVfcvzsGKKkVDdqyDU7Haan9zFDvmLizqM3mHnw+ZaehMsdFNxuUcE4Z6BkWHKpn0MyXX8E/OG677FZIVISXRmZmH1cWFjV/1vg1brw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723132812; c=relaxed/simple; bh=xwHM+2jEJSRymGKmUvstfzDr/HlHog80byhRbKRnSk4=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=KsVehdo4vAW/QM67+x4zgUOybYDlDLEc701NT+n43ytLJ/cWoRH9v4X12ErxPR46uWo2korj1uJuqieL4j1rpV/e8mzyU7P9+ZZ+Bd0INqTzoCAddaV5eA1RROhXZv2+jNUrpUqaRnnpLTwz8a9qhBV3W5kpZO9fRaxwPFTBkJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=FJ9p/EoL; arc=none smtp.client-ip=185.58.85.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="FJ9p/EoL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1723132809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YfnnNoTR8wZkzAeozP6Z1sB7CMSAZQbY0yn1Z/xP9r8=; b=FJ9p/EoLI8AlRP4lp0Pmz6PwrHi7RwOGK0y/Dg98PPvtnnqqnoYAkYfTZ9jO3YVV3nP5Bi MGFnGdA02DSCPA3MQ5wi6rN8IG8qWIgQLvpfpxQfRRYqCSUGm/8zSEdl0JDe6W5B8wB8k2 es9vGkFizEgQ/VU6Cikj5cpNf2DXFHw= Received: from GBR01-LO4-obe.outbound.protection.outlook.com (mail-lo4gbr01lp2105.outbound.protection.outlook.com [104.47.85.105]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-232-ZPA-JwDsM9WO7q7c-FJ81g-1; Thu, 08 Aug 2024 17:00:08 +0100 X-MC-Unique: ZPA-JwDsM9WO7q7c-FJ81g-1 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) by LOYP123MB2816.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.15; Thu, 8 Aug 2024 16:00:07 +0000 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f]) by CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f%6]) with mapi id 15.20.7849.014; Thu, 8 Aug 2024 16:00:07 +0000 Message-ID: Date: Thu, 8 Aug 2024 18:00:05 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/2] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT macros From: Lech Perczak To: linux-serial@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko References: <6bfb7abc-0264-440d-b0d6-6dd6a8b64b5e@camlingroup.com> In-Reply-To: <6bfb7abc-0264-440d-b0d6-6dd6a8b64b5e@camlingroup.com> X-ClientProxiedBy: WA2P291CA0001.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::20) To CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWXP123MB5267:EE_|LOYP123MB2816:EE_ X-MS-Office365-Filtering-Correlation-Id: c71f1961-8fd4-42b7-41f2-08dcb7c32c4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024 X-Microsoft-Antispam-Message-Info: =?utf-8?q?iBIywWCzbZ4BsgGsSc39NdSmbH7xZXr?= =?utf-8?q?lqGzt3Z6xY4J59WcIqtD5iFz5D3/nVQ6FCTZJDmfKzk4cIQTOzcLxUx5IgFtL7Iqa?= =?utf-8?q?zaafko5J3OuxVNJK6D3IzzjyFNW1zNsqkJ1Ff2hNFcrjIMz/YpJJc6UfHYYW7+7nz?= =?utf-8?q?6ejpV6LND+dS4e6gh5KNTsJCg9cSjc+snXSyc0WxryMcKh2ZOqO8HPSKOQ67unTwp?= =?utf-8?q?OGX8lgy2yT3B1os4YzPSrMx7IRwr+Kb/Rs4lKFuL5ewD3lSGk9Z/PAD/KMUZr8btj?= =?utf-8?q?1cTO1CUqEzFHGIwf4hHVWt0HIJ0oqEW97Dyoz2BQQTqiuufVTtLRKx4PTO4E8B0QH?= =?utf-8?q?IV5Bob6pcaOcyY6r0cUP5mCNrTpMvN97KYLl7Iw038uk2aNtnHy6aMBpsQt83LkJ6?= =?utf-8?q?I3kgStwx1me5gPMbb4ax5NHcIBppT0P3eyCG5GOO4T2YTogylc5PyxLcUAJ//CH9V?= =?utf-8?q?6tXZ7pyUlLV9VoSKPcGCKV9JQJmxeqfkN2mfaXr91QCc0PpvF51KDdZ48X6+50MZI?= =?utf-8?q?9xc4H2NaZgjQ9DQSxc7VOfBjTMa6b0KFiOD8lm9ZbrhTHaDYYhd+il8VV1C/pdlu9?= =?utf-8?q?nReexpLEZiLTPqQ0mo3dpdsFaVO+iuCtJl1amt1m53hko0oY5zbbD3hrdOkD+uxFz?= =?utf-8?q?xTT6kXDQIxIC6m1XOYrCkzDrPxlR9MGYPIUSBd/lhJb2/BgwNkcoeeXOTqLWp/RTl?= =?utf-8?q?3JABwLBtLOHqN3CGWF4706oh1nsHkkbxlFLVD0QENSVcQimIJSEqtxI0FvfqjpGgp?= =?utf-8?q?3zpYNy+d5l34r3UzBTUre/TxG1mR0zqgPACgb/wfuUXP2YH/xD2e6DciqMKkE0ySi?= =?utf-8?q?OfhHr30qnMBDunWMLy7wQeHHHwfBNdGgOHjFaSdFvVh/yGGurcS04Nkn53V8HLzo4?= =?utf-8?q?ouB4wCqGsJmfzAxzlW0dBs97fPj2+IwLogq9i3oHcgdlhCG3PoOGNAVLmu4DbE8IE?= =?utf-8?q?GMsOaA66Ya1KOFShUQQmCyx2yXmfJ9cU661NO7W55O2RUn2ZRKGLjf11msUXTTqfX?= =?utf-8?q?PuhRGIbJIj6KIeQSKaqROBuYMsx6pCcQ+W6Txv+GYtXTWtyaLutyPhC4GjxjAMNOO?= =?utf-8?q?f64nnMUeGX/+wvk3J34UhwU3O39KV+u80BhD5mxlykkDTDqUfU1qmzoDtNJb2JuQ2?= =?utf-8?q?Nyel8P15sJ44lRpIjlO++DQorF9ZeVWWJRcq/U3fMp0298cx9CUIMS3CDjxPG0SSO?= =?utf-8?q?h2/nnSEb8xLhMgOgbp1nJ/leAcUwq0K750LZYEqZAWlWUg+hAw3ZSHdB+Vid4L3fC?= =?utf-8?q?YLE5TQpuYq7WbzJ3lrgmDs5vYoD5AM9V7DA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?G6TlS27pM9MJVdyV+x+/QIrxgsHf?= =?utf-8?q?i8ubcnOZj03T92SiiJN5pNTMo2gUgT5sJYf+21ckWjApbl6vw3jOCnJ91o4LgHrwf?= =?utf-8?q?2cEUZSmcP0w18S81BG6lKK4IEYGTisp12o8noWkPyJz6GFrQotNunDsr6azxD8raJ?= =?utf-8?q?3IdsGoVWc2I+P1mlAwn1cLnljPLxZBfkoT+vRcnz7omDD7T9ejLBQK6Stgb8PsmWd?= =?utf-8?q?+PeEI2zLtp+aa9zUa4ThgXJHsnooh2WrNmeMHPZkDPJRxQzWHXJJS+Mz/jiKoHuYk?= =?utf-8?q?0QSUMbEB6M/2BttmRl5oJcq5E0GRpO1s9lGdqChetnz+WsMylMQohqYmrvRNjhUdm?= =?utf-8?q?N1KFYI1qeaYXHIUZnX75JUDzo9ca+ni6ljYnwVhCvSczUKtZ38/ZK0jSyhfJu1iB0?= =?utf-8?q?mS0YkjOEWoLoSWX1IJ4owj7a/+pVCwwh+vQ2OXzfAK+zUAEnCfOAypShV/701iiOL?= =?utf-8?q?Vg44oDxeekng/AYBoYigpqEcdlePLy6MLbQWIDediBBixsT8LRsFckrzNZqtWu/Wo?= =?utf-8?q?oR/pOVBMbuBgLWafFhzxTQpO66MM7fURrkzP4zL4nPE/kbIErbDIymaUFilouGWf9?= =?utf-8?q?jPZMZBcKNv6q+U+jS4Ai0VLybaqJeABH6CKfN2X8eKhrgdMda/aQTEpjY80nAYYUt?= =?utf-8?q?HQiz65X28rNtpe1yk8YOqP++Mlmv4DaFbIlm3FJ1C1JVgufOfPO1zF9KE9QFyGl8S?= =?utf-8?q?WULcovAJheTiFfpnCCREl5vwJ4LQevUbhZzHQkQzp6pd9BzyUvO/mhRTAOvcUx8XS?= =?utf-8?q?1zPgGc06e+B3YU1Dryr+BeaDb+dARRaB3ig/5Ye5rjYoVJ0EGWLeiE/9kRmA1l6HT?= =?utf-8?q?T9un79YQcU7db3xmbrqcSzY7Jc4fp9TwdOGJeJ63yE0/MXc9hTYbDV8IM8MFZwTiy?= =?utf-8?q?26Zyr7aCJ3iWD3btVN8vUnBtrE4WktTIHzsM6YquyeifYzuYoLIeJky8LaxusXvNV?= =?utf-8?q?Is2T9W5To08+u2tZolga1a5JOqlL939RjhUnawIYzCdUy4qwp5MyO/pwbcLJ730QE?= =?utf-8?q?iYnowSEpiOo+kLxfuz1eKiEuZmoPUfh7Fe1qAD0BeLU85Y7yxHe1IyFV+K36MqIxf?= =?utf-8?q?AgWFUTjnEs7Szi7KqHHukXP7rl5ROAJs1/l+GE6MlFufMRtd+XG5R1C4xje+YfCfM?= =?utf-8?q?v1vHzPXjGFj3ORPoCsY1YaMeMmJ9wq85toHLU4CM072VHhlTSKV45PN8L17xbgxzC?= =?utf-8?q?ItYpbkNPGHdeSeKRNinvZkNRA00rXug34EGuCi9MiOCsW9yzt8K0fNiUdapGpDrdW?= =?utf-8?q?Wl4Gf15aquyCAgRqEw2NQjLenu2YQqeZjXCi5tP5kYO8vNyTbLpbgXNo/DURuLyt9?= =?utf-8?q?lRq6jc0c9Dm2TOdIVH4nBmhbEJ2tYMPgdSRW8D5LANPdxq+RecHMRBHZiVJBIL816?= =?utf-8?q?VBvTA1Q3s/kTLzC9d1iJWNZtMQgZP3970hyXklXYdAHZiqgyTBsLXBNFUJTXbuJal?= =?utf-8?q?2srJzbt1E4GnwC/Phfhorur52joC3sh71THJxYNNSEV+rdhCmF9FtvarJ9B4JOn4y?= =?utf-8?q?H3a6kBGXQay/Z/bNQ/7BQ9Twm5ZCsLM/VMVlkqAdhTCI8i+02iZyjL4ruYrjLeDc8?= =?utf-8?q?j8iAgmfn5AP0weKXNngEpFyIGmYEry97A=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: c71f1961-8fd4-42b7-41f2-08dcb7c32c4e X-MS-Exchange-CrossTenant-AuthSource: CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2024 16:00:07.1070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nkt7Y3dC0bPEj8OiWHudG9S92+9SDoIMk+CjdA0UX2gV8Fj3ffnUqyMpK+Z8X625TGMecwMZT2YRqt4Aq7Mcs77FvBdH3H41KzokN4OD+Zw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP123MB2816 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which doesn't match the datasheet. Fix them Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko Signed-off-by: Lech Perczak --- drivers/tty/serial/sc16is7xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8a2020f9930e..c9695a3fd193 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -280,10 +280,10 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */ -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3 +#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 1 */ +#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 0 * - * SWFLOW bits 3 & 2 table: + * SWFLOW bits 1 & 0 table: * 00 -> no received flow * control * 01 -> receiver compares