mbox series

[v7,0/2] spi-geni-qcom: Add SPI device mode support for GENI based QuPv3

Message ID 20230714042203.14251-1-quic_ptalari@quicinc.com
Headers show
Series spi-geni-qcom: Add SPI device mode support for GENI based QuPv3 | expand

Message

Praveen Talari July 14, 2023, 4:22 a.m. UTC
This series adds spi device mode functionality to geni based Qupv3.
The common header file contains spi slave related registers and masks.

Praveen Talari (2):
  soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
  spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
---
v6 -> v7:
- Corrected author mail

v5 -> v6:
- Added code comments
- Dropped get_spi_master api

v4 -> v5:
- Addressed review comments in driver

v3 -> v4:
- Used existing property spi-slave
- Hence dropped dt-binding changes

v2 -> v3:
- Modified commit message
- Addressed comment on dt-binding

v1 -> v2:
- Added dt-binding change for spi slave
- Modified commit message
- Addressed review comments in driver

 drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
 include/linux/soc/qcom/geni-se.h |  9 ++++++
 2 files changed, 56 insertions(+), 6 deletions(-)

Comments

Vijaya Krishna Nivarthi July 18, 2023, 10:37 a.m. UTC | #1
Hi,

LGTM...


On 7/14/2023 9:52 AM, Praveen Talari wrote:
> This series adds spi device mode functionality to geni based Qupv3.
> The common header file contains spi slave related registers and masks.
>
> Praveen Talari (2):
>    soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
>    spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
> ---
> v6 -> v7:
> - Corrected author mail
>
> v5 -> v6:
> - Added code comments
> - Dropped get_spi_master api
>
> v4 -> v5:
> - Addressed review comments in driver
>
> v3 -> v4:
> - Used existing property spi-slave
> - Hence dropped dt-binding changes
>
> v2 -> v3:
> - Modified commit message
> - Addressed comment on dt-binding
>
> v1 -> v2:
> - Added dt-binding change for spi slave
> - Modified commit message
> - Addressed review comments in driver
>
>   drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
>   include/linux/soc/qcom/geni-se.h |  9 ++++++
>   2 files changed, 56 insertions(+), 6 deletions(-)


Reviewed-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Mark Brown July 31, 2023, 9:16 p.m. UTC | #2
On Fri, 14 Jul 2023 09:52:01 +0530, Praveen Talari wrote:
> This series adds spi device mode functionality to geni based Qupv3.
> The common header file contains spi slave related registers and masks.
> 
> Praveen Talari (2):
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
      commit: 59bbe86bb212b618ec2b50434f54bb4cfc704f44
[2/2] spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
      commit: d7f74cc31a89a45d4c7deaa5f759661a07a183d6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark