mbox series

[0/6] spi: stm32: add support for stm32mp25

Message ID 20231218155721.359198-1-alain.volmat@foss.st.com
Headers show
Series spi: stm32: add support for stm32mp25 | expand

Message

Alain Volmat Dec. 18, 2023, 3:57 p.m. UTC
This series adds support for spi bus found on the stm32mp25 and add
all instances within device-trees.

Alain Volmat (4):
  spi: stm32: use dma_get_slave_caps prior to configuring dma channel
  arm64: dts: st: add all 8 spi nodes on stm32mp251
  arm64: dts: st: add spi3/spi8 pins for stm32mp25
  arm64: dts: st: add spi3 / spi8 properties on stm32mp257f-ev1

Valentin Caron (2):
  dt-bindings: spi: stm32: add st,stm32mp25-spi compatible
  spi: stm32: add st,stm32mp25-spi compatible supporting STM32MP25 soc

 .../devicetree/bindings/spi/st,stm32-spi.yaml |   1 +
 arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi |  46 ++++++
 arch/arm64/boot/dts/st/stm32mp251.dtsi        |  88 +++++++++++
 arch/arm64/boot/dts/st/stm32mp257f-ev1.dts    |  14 ++
 drivers/spi/spi-stm32.c                       | 145 ++++++++++++++++--
 5 files changed, 280 insertions(+), 14 deletions(-)

Comments

Fabrice Gasnier Dec. 18, 2023, 4:58 p.m. UTC | #1
On 12/18/23 16:57, Alain Volmat wrote:
> From: Valentin Caron <valentin.caron@foss.st.com>
> 
> Add st,stm32mp25-spi compatible in dt-bindings.  STM32MP25 spi is similar

Hi Alain,
In case you re-submit,
Nitpicking, extra space here could be removed    ^
Capital letters for SPI could also be used here             ^

Appart from that, you can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Best Regards,
Fabrice

> to the STM32H7 except for the following two points:
>   - Burst should not be enabled with the new DMA used on STM32MP25.
>   - STM32MP25 SPI8 has a limited feature set, it can only send words of
>     8 or 16 bits and with a maximum words number of 1024.
> 
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
>  Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index 5754d603f34f..4bd9aeb81208 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -25,6 +25,7 @@ properties:
>        - st,stm32f4-spi
>        - st,stm32f7-spi
>        - st,stm32h7-spi
> +      - st,stm32mp25-spi
>  
>    reg:
>      maxItems: 1
Conor Dooley Dec. 19, 2023, 4:39 p.m. UTC | #2
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Mark Brown Dec. 22, 2023, 1:30 p.m. UTC | #3
On Mon, 18 Dec 2023 16:57:12 +0100, Alain Volmat wrote:
> This series adds support for spi bus found on the stm32mp25 and add
> all instances within device-trees.
> 
> Alain Volmat (4):
>   spi: stm32: use dma_get_slave_caps prior to configuring dma channel
>   arm64: dts: st: add all 8 spi nodes on stm32mp251
>   arm64: dts: st: add spi3/spi8 pins for stm32mp25
>   arm64: dts: st: add spi3 / spi8 properties on stm32mp257f-ev1
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/6] spi: stm32: use dma_get_slave_caps prior to configuring dma channel
      commit: 6f98f25247b7ef03fb89030a3af6c0eb08132104
[2/6] dt-bindings: spi: stm32: add st,stm32mp25-spi compatible
      commit: f034a151059a84cecaae68f5a72ee5d815e94625
[3/6] spi: stm32: add st,stm32mp25-spi compatible supporting STM32MP25 soc
      commit: f6cd66231aa58599526584ff4df1bdde8d86eac8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Alexandre TORGUE April 25, 2024, 8:21 a.m. UTC | #4
Hi Alain

On 12/18/23 16:57, Alain Volmat wrote:
> This series adds support for spi bus found on the stm32mp25 and add
> all instances within device-trees.
> 
> Alain Volmat (4):
>    spi: stm32: use dma_get_slave_caps prior to configuring dma channel
>    arm64: dts: st: add all 8 spi nodes on stm32mp251
>    arm64: dts: st: add spi3/spi8 pins for stm32mp25
>    arm64: dts: st: add spi3 / spi8 properties on stm32mp257f-ev1
> 
> Valentin Caron (2):
>    dt-bindings: spi: stm32: add st,stm32mp25-spi compatible
>    spi: stm32: add st,stm32mp25-spi compatible supporting STM32MP25 soc
> 
>   .../devicetree/bindings/spi/st,stm32-spi.yaml |   1 +
>   arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi |  46 ++++++
>   arch/arm64/boot/dts/st/stm32mp251.dtsi        |  88 +++++++++++
>   arch/arm64/boot/dts/st/stm32mp257f-ev1.dts    |  14 ++
>   drivers/spi/spi-stm32.c                       | 145 ++++++++++++++++--
>   5 files changed, 280 insertions(+), 14 deletions(-)
> 

DT patches applied on stm32-next.
I added "access-controller" bindings for all SPI nodes.

Cheers
Alex