Message ID | 20240517195344.813032-1-andriy.shevchenko@linux.intel.com |
---|---|
Headers | show |
Series | spi: pxa2xx: Get rid of an additional layer in PCI driver | expand |
On Fri, May 17, 2024 at 10:47:43PM +0300, Andy Shevchenko wrote: > The spi-pxa2xx.c is bloated with a platform driver code while > pretending to provide a core functionality. Make it real core > library by splitting out the platform driver to a separate file. ... > @@ -1597,8 +1485,9 @@ static int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp) > pxa_ssp_free(ssp); Looking at this leftover, namely this patch should remove the above line, I realised that there is a problem with the original code as well as it may drop a reference count in pxa/ssp.c before cleaning up other things which might have unexpected behaviour. > return status; > } > +EXPORT_SYMBOL_NS_GPL(pxa2xx_spi_probe, SPI_PXA2xx); I will rework this one along with providing a fix for the above mentioned issue. Meanwhile I will wait for other comments for the rest of the series.