mbox series

[v3,0/3] spi: geni-qcom: Undo runtime PM changes at driver exit time

Message ID 20240909073141.951494-1-ruanjinjie@huawei.com
Headers show
Series spi: geni-qcom: Undo runtime PM changes at driver exit time | expand

Message

Jinjie Ruan Sept. 9, 2024, 7:31 a.m. UTC 
Fix two bugs for geni-qcom and use dev managed function
to simplify code.

Changes in v3:
- Adjust the runtime PM patch to be the first.
- Use devm_pm_runtime_enable() to undo runtime PM changes.
- Land the rest of the cleanups afterwards.
- Update the commit message.

Changes in v2:
- Split out the device managed cleanup patch.
- PATCH -next -> PATCH
- Also fix the incorrect free_irq() sequence.

Jinjie Ruan (3):
  spi: geni-qcom: Undo runtime PM changes at driver exit time
  spi: geni-qcom: Fix incorrect free_irq() sequence
  spi: geni-qcom: Use devm functions to simplify code

 drivers/spi/spi-geni-qcom.c | 50 ++++++++++++++-----------------------
 1 file changed, 19 insertions(+), 31 deletions(-)

Comments

Dmitry Baryshkov Sept. 9, 2024, 9:47 a.m. UTC | #1 
On Mon, Sep 09, 2024 at 03:31:40PM GMT, Jinjie Ruan wrote:
> In spi_geni_remove(), the free_irq() sequence is different from that
> on the probe error path. And the IRQ will still remain and it's interrupt
> handler may use the dma channel after release dma channel and before free
> irq, which is not secure, fix it.
> 
> Fixes: b59c122484ec ("spi: spi-geni-qcom: Add support for GPI dma")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> v3:
> - Rebased on the devm_pm_runtime_enable() patch.
> - Update the commit message.
> ---
>  drivers/spi/spi-geni-qcom.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This matches the code in spi_geni_probe().


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mark Brown Sept. 9, 2024, 5:43 p.m. UTC | #2 
On Mon, 09 Sep 2024 15:31:38 +0800, Jinjie Ruan wrote:
> Fix two bugs for geni-qcom and use dev managed function
> to simplify code.
> 
> Changes in v3:
> - Adjust the runtime PM patch to be the first.
> - Use devm_pm_runtime_enable() to undo runtime PM changes.
> - Land the rest of the cleanups afterwards.
> - Update the commit message.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] spi: geni-qcom: Undo runtime PM changes at driver exit time
      commit: 89e362c883c65ff94b76b9862285f63545fb5274
[2/3] spi: geni-qcom: Fix incorrect free_irq() sequence
      commit: b787a33864121a565aeb0e88561bf6062a19f99c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark