| Message ID | 20240913-airoha-spi-fixes-v1-0-de2e74ed4664@kernel.org |
|---|---|
| Headers | show |
| Series | spi: airoha: Fix errors reported by mtd_test kernel modules | expand |
On Fri, 13 Sep 2024 23:07:12 +0200, Lorenzo Bianconi wrote: > Fix errors detected running mtd_test kernel test modules. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/4] spi: airoha: fix dirmap_{read,write} operations commit: 2e6bbfe7b0c0607001b784082c2685b134174fac [2/4] spi: airoha: fix airoha_snand_{write,read}_data data_len estimation commit: 0e58637eb968c636725dcd6c7055249b4e5326fb All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
> On Fri, 13 Sep 2024 23:07:12 +0200, Lorenzo Bianconi wrote: > > Fix errors detected running mtd_test kernel test modules. > > > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next > > Thanks! > > [1/4] spi: airoha: fix dirmap_{read,write} operations > commit: 2e6bbfe7b0c0607001b784082c2685b134174fac > [2/4] spi: airoha: fix airoha_snand_{write,read}_data data_len estimation > commit: 0e58637eb968c636725dcd6c7055249b4e5326fb > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark > Hi Mark, I think we should include even patch 3/4 since it fixes some errors in mtd_oobtest kernel test module (and even some ubifs reported errors). Regards, Lorenzo
On Thu, Sep 19, 2024 at 10:59:20AM +0200, Lorenzo Bianconi wrote: > I think we should include even patch 3/4 since it fixes some errors in > mtd_oobtest kernel test module (and even some ubifs reported errors). Your changelog doesn't actually describe what might be fixed there and it's not obvious from the change itself.
> On Thu, Sep 19, 2024 at 10:59:20AM +0200, Lorenzo Bianconi wrote: > > > I think we should include even patch 3/4 since it fixes some errors in > > mtd_oobtest kernel test module (and even some ubifs reported errors). > > Your changelog doesn't actually describe what might be fixed there and > it's not obvious from the change itself. sorry to be no clear on it. Patches 1/4, 2/4 and 3/4 are fixing outstanding issues while patch 4/4 is an optimization and we can apply it later on, up to you. Regards, Lorenzo
On Thu, Sep 19, 2024 at 11:16:22AM +0200, Lorenzo Bianconi wrote: > > On Thu, Sep 19, 2024 at 10:59:20AM +0200, Lorenzo Bianconi wrote: > > Your changelog doesn't actually describe what might be fixed there and > > it's not obvious from the change itself. > sorry to be no clear on it. Patches 1/4, 2/4 and 3/4 are fixing outstanding > issues while patch 4/4 is an optimization and we can apply it later on, up to > you. Yes, what I'm saying is that I can't tell what those issues might be for patch 3. The changelog for the patch should describe what it's supposed to fix.
> On Thu, Sep 19, 2024 at 11:16:22AM +0200, Lorenzo Bianconi wrote: > > > On Thu, Sep 19, 2024 at 10:59:20AM +0200, Lorenzo Bianconi wrote: > > > > Your changelog doesn't actually describe what might be fixed there and > > > it's not obvious from the change itself. > > > sorry to be no clear on it. Patches 1/4, 2/4 and 3/4 are fixing outstanding > > issues while patch 4/4 is an optimization and we can apply it later on, up to > > you. > > Yes, what I'm saying is that I can't tell what those issues might be for > patch 3. The changelog for the patch should describe what it's supposed > to fix. ack. The issue is the 'read cache' logic present in the vendor sdk codebase I added in the upstream driver is buggy and it is introducing errors reported by mtd_oobtest kernel test module. Since we do not get any read/write speed improvement using the cache, in order to fix the mtd_oobtest test, I decided to get rid of the 'read cache' since it is not useful. Now the driver is passing all the tests available in mtd_test suite. Do you want me to repost just this patch updating the commit log? Regards, Lorenzo
On Thu, Sep 19, 2024 at 01:18:09PM +0200, Lorenzo Bianconi wrote: > ack. The issue is the 'read cache' logic present in the vendor sdk codebase I > added in the upstream driver is buggy and it is introducing errors reported > by mtd_oobtest kernel test module. Since we do not get any read/write speed > improvement using the cache, in order to fix the mtd_oobtest test, I decided > to get rid of the 'read cache' since it is not useful. Now the driver is passing > all the tests available in mtd_test suite. > Do you want me to repost just this patch updating the commit log? It'd be a bit easier to resend this and patch 4 but yes. Please mention exactly what the errors that mtd_oobtest finds are and ideally why removing the cache fixes them in the changelog.
On Sep 19, Mark Brown wrote: > On Thu, Sep 19, 2024 at 01:18:09PM +0200, Lorenzo Bianconi wrote: > > > ack. The issue is the 'read cache' logic present in the vendor sdk codebase I > > added in the upstream driver is buggy and it is introducing errors reported > > by mtd_oobtest kernel test module. Since we do not get any read/write speed > > improvement using the cache, in order to fix the mtd_oobtest test, I decided > > to get rid of the 'read cache' since it is not useful. Now the driver is passing > > all the tests available in mtd_test suite. > > Do you want me to repost just this patch updating the commit log? > > It'd be a bit easier to resend this and patch 4 but yes. Please mention > exactly what the errors that mtd_oobtest finds are and ideally why > removing the cache fixes them in the changelog. ack, I will do. Regards, Lorenzo
Fix errors detected running mtd_test kernel test modules. --- Lorenzo Bianconi (4): spi: airoha: fix dirmap_{read,write} operations spi: airoha: fix airoha_snand_{write,read}_data data_len estimation spi: airoha: remove read cache in airoha_snand_dirmap_read spi: airoha: do not keep {tx,rx} dma buffer always mapped drivers/spi/spi-airoha-snfi.c | 199 ++++++++++++++++++------------------------ 1 file changed, 87 insertions(+), 112 deletions(-) --- base-commit: 58be528df758d3f00c10d6d381d9e02d5c68f23d change-id: 20240913-airoha-spi-fixes-56bb430fb99f Best regards,