| Message ID | 20250207-dlech-mainline-spi-engine-offload-2-v8-0-e48a489be48c@baylibre.com |
|---|---|
| Headers | show |
| Series | spi: axi-spi-engine: add offload support | expand |
On Fri, Feb 07, 2025 at 02:08:57PM -0600, David Lechner wrote: > Only very minor fixes in this revision. > > Also, now that trees are rebased on v6.14-rc1 we no longer have > dependencies for the IIO patches. So Mark can pick up all of the > patches if we want to go that way. In any case though, Jonathan will > need an immutable branch since we have other IIO patches in-flight > building on top of this series. The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b: Linux 6.14-rc1 (2025-02-02 15:39:26 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-offload for you to fetch changes up to 700a281905f2a4ccf6f3b2d3cd6985e034b4b021: spi: add offload TX/RX streaming APIs (2025-02-07 20:17:11 +0000) ---------------------------------------------------------------- spi: Add offload APIs This series adds support for offloading complete SPI transactions, including the initiation, to the hardware. ---------------------------------------------------------------- David Lechner (5): spi: add basic support for SPI offloading spi: offload: add support for hardware triggers dt-bindings: trigger-source: add generic PWM trigger source spi: offload-trigger: add PWM trigger driver spi: add offload TX/RX streaming APIs .../bindings/trigger-source/pwm-trigger.yaml | 37 ++ MAINTAINERS | 12 + drivers/spi/Kconfig | 15 + drivers/spi/Makefile | 4 + drivers/spi/spi-offload-trigger-pwm.c | 162 +++++++ drivers/spi/spi-offload.c | 465 +++++++++++++++++++++ drivers/spi/spi.c | 10 + include/linux/spi/offload/consumer.h | 39 ++ include/linux/spi/offload/provider.h | 47 +++ include/linux/spi/offload/types.h | 99 +++++ include/linux/spi/spi.h | 20 + 11 files changed, 910 insertions(+) create mode 100644 Documentation/devicetree/bindings/trigger-source/pwm-trigger.yaml create mode 100644 drivers/spi/spi-offload-trigger-pwm.c create mode 100644 drivers/spi/spi-offload.c create mode 100644 include/linux/spi/offload/consumer.h create mode 100644 include/linux/spi/offload/provider.h create mode 100644 include/linux/spi/offload/types.h
On Fri, 07 Feb 2025 14:08:57 -0600, David Lechner wrote: > Only very minor fixes in this revision. > > Also, now that trees are rebased on v6.14-rc1 we no longer have > dependencies for the IIO patches. So Mark can pick up all of the > patches if we want to go that way. In any case though, Jonathan will > need an immutable branch since we have other IIO patches in-flight > building on top of this series. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [01/17] spi: add basic support for SPI offloading commit: 8e02d188698851436f76038ea998b726193d1b10 [02/17] spi: offload: add support for hardware triggers commit: d7231be4b4657e5f922a4c6dc11e8dffc71fee87 [03/17] dt-bindings: trigger-source: add generic PWM trigger source commit: 83f37ba7b76ab17e029ab4127ec64ccccce64c00 [04/17] spi: offload-trigger: add PWM trigger driver commit: ebb398ae1e052c4245b7bcea679fe073111db2ce [05/17] spi: add offload TX/RX streaming APIs commit: 700a281905f2a4ccf6f3b2d3cd6985e034b4b021 [06/17] spi: dt-bindings: axi-spi-engine: add SPI offload properties commit: e1101373df5cd7672d988bb4e9cdd5eb97003165 [07/17] spi: axi-spi-engine: implement offload support commit: 5a19e1985d014fab9892348f6175a19143cec810 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Only very minor fixes in this revision. Also, now that trees are rebased on v6.14-rc1 we no longer have dependencies for the IIO patches. So Mark can pick up all of the patches if we want to go that way. In any case though, Jonathan will need an immutable branch since we have other IIO patches in-flight building on top of this series. [1]: https://lore.kernel.org/all/20241124125206.1ffd6e6c@jic23-huawei/ --- Changes in v8: - Added missing include to fix CI build error in spi-axi-spi-engine. - Fixed a wrong register cleared in ad4695 driver. - Link to v7: https://lore.kernel.org/r/20250113-dlech-mainline-spi-engine-offload-2-v7-0-e0860c81caae@baylibre.com Changes in v7: - Addressed some very minor feedback. - Link to v6: https://lore.kernel.org/r/20241211-dlech-mainline-spi-engine-offload-2-v6-0-88ee574d5d03@baylibre.com Changes in v6: - Dropped the "spi: dt-bindings: add trigger-source.yaml" patch. It was reworked and merged into dt-schema in https://github.com/devicetree-org/dt-schema/pull/147 - Adjusted other dt-bindings patches to account for above change. - Dropped one iio patch that was already applied to iio tree. - Added a DAC patch to make use of the TX DMA stream API. - Minor fixes and improvements to other patches based on feedback. - Link to v5: https://lore.kernel.org/r/20241115-dlech-mainline-spi-engine-offload-2-v5-0-bea815bd5ea5@baylibre.com Changes in v5: - Dropped pwm patch. A variant of this patch has been picked up in the pwm tree. - Addressed review comments (see details in individual patches). - Added some polish, like MAINTAINERS entries and updating ADC docs. - Link to v4: https://lore.kernel.org/r/20241023-dlech-mainline-spi-engine-offload-2-v4-0-f8125b99f5a1@baylibre.com Changes in v4: - Dropped #spi-offload-cells and spi-offload properties from DT bindings. - Made an attempt at a more generic trigger interface instead of using clk framework. This also includes a new driver for a generic PWM trigger. - Addressed IIO review comments. - Added new patches for iio/adc/ad4695 as 2nd user of SPI offload. - Link to v3: https://lore.kernel.org/r/20240722-dlech-mainline-spi-engine-offload-2-v3-0-7420e45df69b@baylibre.com Changes in v3: - Reworked DT bindings to have things physically connected to the SPI controller be properties of the SPI controller and use more conventional provider/consumer properties. - Added more SPI APIs for peripheral drivers to use to get auxillary offload resources, like triggers. - Link to v2: https://lore.kernel.org/r/20240510-dlech-mainline-spi-engine-offload-2-v2-0-8707a870c435@baylibre.com Individual patches have more details on these changes and earlier revisions too. --- As a recap, here is the background and end goal of this series: The AXI SPI Engine is a SPI controller that has the ability to record a series of SPI transactions and then play them back using a hardware trigger. This allows operations to be performed, repeating many times, without any CPU intervention. This is needed for achieving high data rates (millions of samples per second) from ADCs and DACs that are connected via a SPI bus. The offload hardware interface consists of a trigger input and a data output for the RX data. These are connected to other hardware external to the SPI controller. To record one or more transactions, commands and TX data are written to memories in the controller (RX buffer is not used since RX data gets streamed to an external sink). This sequence of transactions can then be played back when the trigger input is asserted. This series includes core SPI support along with the first SPI controller (AXI SPI Engine) and SPI peripheral (AD7944 ADC) that use them. This enables capturing analog data at 2 million samples per second. The hardware setup looks like this: +-------------------------------+ +------------------+ | | | | | SOC/FPGA | | AD7944 ADC | | +---------------------+ | | | | | AXI SPI Engine | | | | | | SPI Bus ============ SPI Bus | | | | | | | | | +---------------+ | | | | | | | Offload 0 | | | +------------------+ | | | RX DATA OUT > > > > | | | | TRIGGER IN < < < v | | | +---------------+ | ^ v | | +---------------------+ ^ v | | | AXI PWM | ^ v | | | CH0 > ^ v | | +---------------------+ v | | | AXI DMA | v | | | CH0 < < < | | +---------------------+ | | | +-------------------------------+ --- Axel Haslam (1): iio: dac: ad5791: Add offload support David Lechner (16): spi: add basic support for SPI offloading spi: offload: add support for hardware triggers dt-bindings: trigger-source: add generic PWM trigger source spi: offload-trigger: add PWM trigger driver spi: add offload TX/RX streaming APIs spi: dt-bindings: axi-spi-engine: add SPI offload properties spi: axi-spi-engine: implement offload support iio: buffer-dmaengine: split requesting DMA channel from allocating buffer iio: buffer-dmaengine: add devm_iio_dmaengine_buffer_setup_with_handle() iio: adc: ad7944: don't use storagebits for sizing iio: adc: ad7944: add support for SPI offload doc: iio: ad7944: describe offload support dt-bindings: iio: adc: adi,ad4695: add SPI offload properties iio: adc: ad4695: Add support for SPI offload doc: iio: ad4695: add SPI offload support iio: dac: ad5791: sort include directives .../devicetree/bindings/iio/adc/adi,ad4695.yaml | 13 + .../bindings/spi/adi,axi-spi-engine.yaml | 24 ++ .../bindings/trigger-source/pwm-trigger.yaml | 37 ++ Documentation/iio/ad4695.rst | 68 +++ Documentation/iio/ad7944.rst | 24 +- MAINTAINERS | 12 + drivers/iio/adc/Kconfig | 2 + drivers/iio/adc/ad4695.c | 445 +++++++++++++++++++- drivers/iio/adc/ad7944.c | 307 +++++++++++++- drivers/iio/adc/adi-axi-adc.c | 2 +- drivers/iio/buffer/industrialio-buffer-dmaengine.c | 144 +++++-- drivers/iio/dac/Kconfig | 3 + drivers/iio/dac/ad5791.c | 179 +++++++- drivers/iio/dac/adi-axi-dac.c | 2 +- drivers/spi/Kconfig | 16 + drivers/spi/Makefile | 4 + drivers/spi/spi-axi-spi-engine.c | 315 +++++++++++++- drivers/spi/spi-offload-trigger-pwm.c | 162 +++++++ drivers/spi/spi-offload.c | 465 +++++++++++++++++++++ drivers/spi/spi.c | 10 + include/dt-bindings/iio/adc/adi,ad4695.h | 7 + include/linux/iio/buffer-dmaengine.h | 7 +- include/linux/spi/offload/consumer.h | 39 ++ include/linux/spi/offload/provider.h | 47 +++ include/linux/spi/offload/types.h | 99 +++++ include/linux/spi/spi.h | 20 + 26 files changed, 2350 insertions(+), 103 deletions(-) --- base-commit: 884697cc74d9fea0a8628c2794d0b80065ac95d1 change-id: 20240510-dlech-mainline-spi-engine-offload-2-afce3790b5ab Best regards,