| Message ID | 20201013160845.1772-3-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | fix all errors except one reported by dt_binding_check | expand |
On 2020/10/14 1:53, Dan Murphy wrote: > Zhen > > On 10/13/20 11:08 AM, Zhen Lei wrote: >> There are so many properties have not been described in this yaml file, >> and a lot of errors will be reported. Especially, some yaml files such as >> google,cros-ec-typec.yaml, extcon-usbc-cros-ec.yaml can not pass the >> self-check, because of the examples. So temporarily allow additional >> properties to keep the comprehensive dt_binding_check result clean. > > My preference is to fix the binding to pass the checks and not just work around the issues. Working around the issues may mean the issues never get fixed. I agree with your first sentenceļ¼don't just work around the issues. But these errors are so annoying. Hope someone can add the description of the missing properties. I'm not familiar with this module anyway. And I don't fully agree with your last sentence. After all, the main properties are listed, and the ones that are not listed should be minor ones. > > Dan > > > . >
On Wed, Oct 14, 2020 at 12:08:41AM +0800, Zhen Lei wrote: > There are so many properties have not been described in this yaml file, > and a lot of errors will be reported. Especially, some yaml files such as > google,cros-ec-typec.yaml, extcon-usbc-cros-ec.yaml can not pass the > self-check, because of the examples. So temporarily allow additional > properties to keep the comprehensive dt_binding_check result clean. > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) There's proper fixes for these under review. Rob
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index f49c0d5d31ad20e..e18047583a0c8fa 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -87,7 +87,7 @@ then: google,cros-ec-spi-msg-delay: false spi-max-frequency: false -additionalProperties: false +additionalProperties: true examples: # Example for I2C
There are so many properties have not been described in this yaml file, and a lot of errors will be reported. Especially, some yaml files such as google,cros-ec-typec.yaml, extcon-usbc-cros-ec.yaml can not pass the self-check, because of the examples. So temporarily allow additional properties to keep the comprehensive dt_binding_check result clean. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)