diff mbox series

[v2,3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

Message ID 20240719111210.1287783-3-festevam@gmail.com
State Superseded
Headers show
Series [v2,1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 | expand

Commit Message

Fabio Estevam July 19, 2024, 11:12 a.m. UTC
There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.

There is a JG10309-01 LCD controlled via SPI though.

Properly describe it by adding the "elgin,jg10309-01" compatible
string.

Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use a more specific compatible string. (Conor)

 arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heiko Stübner Aug. 10, 2024, 9:23 p.m. UTC | #1
Am Freitag, 19. Juli 2024, 13:12:10 CEST schrieb Fabio Estevam:
> There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> 
> There is a JG10309-01 LCD controlled via SPI though.
> 
> Properly describe it by adding the "elgin,jg10309-01" compatible
> string.
> 
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

Mark, do you want to take all 3 patches (fine by me) or just the
first two?


Heiko
Fabio Estevam Aug. 29, 2024, 5:31 p.m. UTC | #2
Hi Heiko,

On Sat, Aug 10, 2024 at 6:23 PM Heiko Stübner <heiko@sntech.de> wrote:

> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
> Mark, do you want to take all 3 patches (fine by me) or just the
> first two?

Mark has applied the spidev patch on his for-6.11 branch:

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-6.11&id=5f3eee1eef5d0edd23d8ac0974f56283649a1512

Could you please apply the other two to your tree?

Thanks
Heiko Stübner Aug. 29, 2024, 5:40 p.m. UTC | #3
Hi Fabio,

Am Donnerstag, 29. August 2024, 19:31:58 CEST schrieb Fabio Estevam:
> On Sat, Aug 10, 2024 at 6:23 PM Heiko Stübner <heiko@sntech.de> wrote:
> 
> > Acked-by: Heiko Stuebner <heiko@sntech.de>
> >
> > Mark, do you want to take all 3 patches (fine by me) or just the
> > first two?
> 
> Mark has applied the spidev patch on his for-6.11 branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-6.11&id=5f3eee1eef5d0edd23d8ac0974f56283649a1512
> 
> Could you please apply the other two to your tree?

Actually Mark has applied patches 1+2 from v4 it seems, so I grabbed the
dts patch from there too :-)

Heiko
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..971bb617e845 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -168,8 +168,8 @@  &spi {
 	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
 	status = "okay";
 
-	dh2228fv: dac@0 {
-		compatible = "rohm,dh2228fv";
+	display: display@0 {
+		compatible = "elgin,jg10309-01";
 		reg = <0>;
 		spi-max-frequency = <24000000>;
 		spi-cpha;