From patchwork Wed Apr 23 06:11:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bough Chen X-Patchwork-Id: 883719 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011067.outbound.protection.outlook.com [52.101.65.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A672267393; Wed, 23 Apr 2025 06:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745388636; cv=fail; b=cqyZsoxiHdCOH496o2XwUw9HRt6YQPZ9ckKP12ZqMSt6Xn7wukXsNCuRWWOA01cuHaC0e7yLic4KVBMrv2CMWLfpW1FOuve1R/jJdrvOHDLb4+5vTz6xxt6IHFwY9Ijk3h1hUBPsZjdp4DmD0NCuK4anvUZDGLmispuFwwAK0bY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745388636; c=relaxed/simple; bh=8iYNp+JFHipH+AmfWSTSMxP+/1DcYqPBlnLSaPPHCzE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mZNPLCovK7FoUgeykobi2JxN7RR/9ANvPHP/T6CzBKQKw+Ub7wTc2HrOhrvrKTMwwP6VZY61FVRCj84oHE7WQFKHKlmktU72XOqr1bQExewlnsVVPZ0z6bhY4IoTZ2HFCYqveNshEfJvbYLC/QdjsY/pBhG/7d4OODmhvMSANUM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Wh1qHvOJ; arc=fail smtp.client-ip=52.101.65.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Wh1qHvOJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AEpxfnyD8Vflzxsw6l4+FNjSuyucYD4rIf57K7qcTaKh503Ol16+rKn0Ui11oXJPXafsJ15gZrr4OFE8GKE9Kf+BATaEdCG59W8MK+KCBth2F+4j7gDBsgBMjLJpG7Imj0CmzDsjeuzTaNQCLgZJGzzlhGeN5qcRvX3uXe00UXoJ+DGfL1DmdeagCv+gwGnyzIu2+acR9gmM0NdYNI4n5jt0JBshwLNvfzFruTG3RSV6ENiuq3Db1XNn/wH4PfkgvcNLz5vq8XS3F8EvA1ucwuq6tKmvJfxY1++fmE63jOqzZll4YLIr2Rsa4p8M51stvtp8tdngfGvddEncqUoBbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sDLmNpfz/hy42XF8b2IbGlwahZ8EdIc7PMUiHEmp+58=; b=PIR8GxZjxU6B8IjbsS+kWP5w3mj3voNx/jFpsA1ze98uDG7lcVb5yyeuzgxbc3QdzHfKXjNhKtcR/MVvdfzdha7h3pH5Gn19Pcmr9HWv8IOdyMXTSYTUzasMF0bYPWq67aWO6Z6ARcZ/1g4Jmr2Y8rnZVWT1fcbkPDbMD0QMuhQ04QjZDw2AsUD5cy1Hz2DT8d37MiBNkS7ND5Ut6rTdL/5Q78wFPW8f3n6VkX9KvmIVLodXYZ70Df1pFuPomFGPeTJoxL9Xj7elLKX3f5nyjYQt1zAItbLSM8e+iYLY84onoEA4F7cBFD6+/zQOZKs6RSnKthmRGdK/b/7z+6ftOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDLmNpfz/hy42XF8b2IbGlwahZ8EdIc7PMUiHEmp+58=; b=Wh1qHvOJ++pMNfHKBT55bm+MkhRf79hpZMmsZulv9LqMGtBlF+J6+6z1/NXf03DVW9iCgeLT4alYK6tCkV7565ymvLGB4fXEwCsGlnw2huWNh3rjaZCBKKsi18peoec8XjwpyLHUYnmZKLUl+d11zIKugpzwB2WvlW0GjbgTYFSwYprsfqJiDhL8xPttiEbUm8AxUmVG7O6+VHJZIuvRc0VcKpTgn4O8R6y0zcpFgCWiubYmcqMIkD8Ne+PuIWy1mqzIT409dVaMa3eX70tptjgTS+6sCRDhKJiEuUp/COniBi9HLeNdIl+536mLea55a0JhxNla25Fyf91o4DxRCA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAXPR04MB8734.eurprd04.prod.outlook.com (2603:10a6:102:21e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.35; Wed, 23 Apr 2025 06:10:30 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8655.033; Wed, 23 Apr 2025 06:10:30 +0000 From: Haibo Chen Date: Wed, 23 Apr 2025 14:11:39 +0800 Subject: [PATCH v1 2/5] spi: spi-nxp-fspi: enable runtime pm for fspi Message-Id: <20250423-flexspipatch-v1-2-292e530509d3@nxp.com> References: <20250423-flexspipatch-v1-0-292e530509d3@nxp.com> In-Reply-To: <20250423-flexspipatch-v1-0-292e530509d3@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745388747; l=5783; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=8iYNp+JFHipH+AmfWSTSMxP+/1DcYqPBlnLSaPPHCzE=; b=cRlsdgCxNPUMiUSVGiGSzOpzZB76wHT3K4qNe5xRXmd2rHquNKpbta9BUlpBe+g/6EL4Ux6Ua qKo3TyIKORSDrTGE7V3jWmVPFDSFL2rIKNxfZ2ve3f1kJLHMEdin9t9 X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: SI2PR04CA0007.apcprd04.prod.outlook.com (2603:1096:4:197::19) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAXPR04MB8734:EE_ X-MS-Office365-Filtering-Correlation-Id: 505b9f54-f894-4c47-68be-08dd822d8cdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?s0WcRSTGZ4fUwnOZLbFmyS7hT7N/Tuo?= =?utf-8?q?KBPTmeSW9tM+9olvci7g0W1c6owC8LCn2o6IxRq3SiHAS4p3RnxwUmexBrGY9+jYY?= =?utf-8?q?FqGZxQAa6GGLGB949MFKRdurWIwuoaKWNl/gpHXcRyYX4GD4a9X65/Gnmwkv+m/aG?= =?utf-8?q?xhtpYwfhG7e+1eYd0LvEGmGd7H5ykZuStk6ngogvBrBIkgDsqQNXsd7qzJcLxLZWI?= =?utf-8?q?8cQYuxfbAaGNBh8wfiHUMwbQbWDvmUbvh8LKsnUAhAMTjyeByZzXLoXP6fRomWFtK?= =?utf-8?q?MQQh7IBQYKyLo1HuNYQVEpIEm/dsPLU1h8To9GfiYWrDcDXQt+z3cpaMzEZVBEH3d?= =?utf-8?q?9wnlCjnGIg3+8wnog1CJuktW6coWXVVGikqr4CONwfex4zf8CgFKMW2/iC4Xpgfzz?= =?utf-8?q?hdTApJK5xQ+ZwWMECJy8WyHNfvEGI8eP4HnDIQ6X8oHexISQu/CaeF+5kxDVIOMFo?= =?utf-8?q?N9EWeFvOEcm/tDIqgHYygWmkx7BGVmdOfxaNvua+KO4QLOPIH/4a742wel+7tbPDk?= =?utf-8?q?1QBG4/FmOqTZ8ETk0iaVS0r0FSdlXcSvw9Zl2bdTjRJ3kRJEo3IyJVZLmfnveY8hy?= =?utf-8?q?nlYO31A8g8XDZfMsVMp/V0iOyrl4jrzEGPcsvtOPuGSlwBYZIGv1qLWsQXKm2Qy4i?= =?utf-8?q?TYWLHMtnnm2ebCr+iGFAodqntWQQt/E8ybznsLtE/6FNkNNJLPzATZpp7hf03gt2I?= =?utf-8?q?BKUuHya7IoEdjZAST0D/tcqF65GPWlrX9DFA/5rwsfTzijT9e5q0xXmKSi7Z+R3g0?= =?utf-8?q?vrdz/DZiiyEXPSGVyAwxCKVctwxkhxMu7XFPqKR7lNpxAux1MsQKOyj1w0cJFjG1s?= =?utf-8?q?mb9zQk/JGhkBwbMDmBKLRE7EMG8Zw1cWv8j/L+34bNoZF1tkIv4cAxXSmyT85xMPU?= =?utf-8?q?TEtY0rqv1H6/BHH0tBK6WvvNuXXIUJPmNpdl7vZuLlrhGftUb4gtW8eiw9HgeJTkD?= =?utf-8?q?g7ICmS0n8PNU4u9x/kCmfQ0gJJFdVSt4Zk41VyFDVEttc7jnT4nQwU2fNLOk0zOt4?= =?utf-8?q?bQBlYTxdGnSU7PJvazzjqVAQFX9pexad1OKxV74G10B5vynLlW15CmVbtT64R9E4N?= =?utf-8?q?IdOpALVJEzdxPFGdY9H52i0EpdVyuKhRauX+MMd279UBCDPrCciotEDROCUEMHgwa?= =?utf-8?q?HyJpvYgs7tmwuUvMzc3/FeSeGyyK7rjSA3EuUsX8hgvWOO6aL2buPAI3Cao/s8sfy?= =?utf-8?q?Aem6TxqQAZUzr60delmbQOwlck64IPRdJuB26X50/LAG7GOXwUysLhq3w1631HSjg?= =?utf-8?q?IApPxCEZHOTdRH8ArbkflVDP7KG9jTsBbNJk6Z6u+sKVMG5TkEZORUZe3gjWIX6+0?= =?utf-8?q?ZeYTf/lhkyz8C5RAVBn0Ev6ED7WtGwq0usGZirQGo4FyH1RJ2Q+Ct7TRDwsuCrIxt?= =?utf-8?q?Zcv+dhULBNidjT3VOOd3PwtG4eyFPokyA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9496.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dL/iiuZwBAY13/97+vy04pYmIK4s?= =?utf-8?q?KmodzhTFV37XlnLGTDaKwQGTB92viqY0ADalviH7kBsGLHLggUjVQIgbwF0hV3Lt1?= =?utf-8?q?sqwHPPHdGbm7vkJ1EIPBwLixyvvbEZ15Ye+oGk2bqMfHceFkuT9i6cty6CN33te//?= =?utf-8?q?1k8V1R/EZRrTusXWP6se7PpB3GdKXZ9jvbgnbPrMwiKJlD6uEsdZ1Jmr8dD/m5yl4?= =?utf-8?q?iUEahkmIvMGKVH/8YGkdTYiY4K0Jm1lwQyXb81cnW9FKPO+0qqFORGuP9gvq7HZu6?= =?utf-8?q?XTm59WmIEbgUr8Yr6UaP4nYTRjnLdcdlHKL4BQHxhpiBL839CRGrJ4YrdcOt7Jf9E?= =?utf-8?q?cncu1frkLioSWsrQui7Ikqnfypxks/x4+Bw3r8cqbtQbZeshGcTfa1QeaDgN92jec?= =?utf-8?q?2jMY9hhq4CR3GRyp5R2iQ6z3bFn9taIw3aQ63NgqKE4F5pIhHA7qW8tt8V9o/nWIw?= =?utf-8?q?10PR063PLJMAn1Ltk0k+Fovu+bxRu1tH38zMZwMG+PGDXYwi6yBF0iRor9Rk9zxZz?= =?utf-8?q?2wzBmZC0Q0VJk590AiN3sqQuNDIsYSMmxmUI54oHVOrOo0DqpT2vdHFlGvm7tvBDY?= =?utf-8?q?Wn88uRn3QE79eBT0TlPLrJn6wWtABv9SpYgqqoaGdWedcFtbBorwOJy/kAXv4kf4Y?= =?utf-8?q?vXLLaRKAkJdGzh1Gjhq3bG2fVUiJR/ERKuczfFUP8MzE5SZ5Kk3CrAbhmRn7ChAF7?= =?utf-8?q?6FgxTEHGzdSRYWy9L+W8OaFUCAnbKwY/hf3P7MkNb7ZzHSs7LBcx8AxXCPwd/VnfP?= =?utf-8?q?rXH9xRdrUZcyLoXxKfvwFha6ZK0r+J7MJJZD4SZhhb3tzxXywfkqFjvVOBEW860ZX?= =?utf-8?q?Tmj8QTQ2QAKxc1yZ28/QdMzfGRK4yXPrJX6jDGfh48XDNv+RrKZN6VX5dslrnHhdc?= =?utf-8?q?iWYWOZfe95IxXKXPDDL42+0ymI2sxkKlP0WyOzmOZkJJ4/MfSgZji0H4GvPfCtuK0?= =?utf-8?q?3mZ4u/h04kObs3JtIsTE6CFhwhOrXpeMirKppoNZd3MECOSkK+UVenvR1/XrsGIbM?= =?utf-8?q?e+Aq89zsRd9BKmOcNtqvyy68w+aR/7DeTNW7PEczllLb5izZg98TNYxjNqhCExB8q?= =?utf-8?q?afAga0xMKW+efhcPhZz2wxFn4DFaPxTH5aQEb22UTSoLdjdQ9qUokWErvBb6j+hpD?= =?utf-8?q?s3Oj6EXp8hs/A98TXf8LWiAjRArKNMmaZQhl/V4KOCS+1rc1ibFUJAVaM6KS/GawS?= =?utf-8?q?Bue81CryB87IiXzKsU3nzjE3PFgq1/Ro1EwZv1IHzQxB0IHr8dJE4xl7cMjed9Z5/?= =?utf-8?q?mQuUgce9etR4URWoKxMwMa26gJQcu+KcIVVs11IOAGLCRGcL02j3PF6qr3+YnkaIW?= =?utf-8?q?fBbXqFv8U9FEqioZR9Q/7DEwpavzBzb42IhAiHk213B7exsP5GqLLkW4rEZ30r6xy?= =?utf-8?q?G7kijvOOC8imJ4v3GeIW/yCHo67XX7/uJUgQMzECZOxYGLCgCUSFwrVDxXs9Yv9+i?= =?utf-8?q?9eQQpKaQGylNQ+Rx+qnyM4Iby8iGx9M437r0jSNaBH1aBHDlYzr6BJH6/DD36wI3i?= =?utf-8?q?gBG0g6iZuY2o?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 505b9f54-f894-4c47-68be-08dd822d8cdc X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2025 06:10:30.8202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vua7amjUyZcBW48hVwSoJEDdlVjaX/g7OsnVO/u8Do/tci8MlkKPIwwe85Uo81oWHyht+7HdTDtSsKoN4qLzeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8734 Enable the runtime PM in fspi driver. Also for system PM, On some board like i.MX8ULP-EVK board, after system suspend, IOMUX module will lost power, so all the pinctrl setting will lost when system resume back, need driver to save/restore the pinctrl setting. Signed-off-by: Han Xu Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 93 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 77 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 00da184be88a026bf562c9808e18e2335a0959e9..23099e60b6fb7e899f95fa0427208b33bc5522ac 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -48,6 +48,8 @@ #include #include #include +#include +#include #include #include #include @@ -57,6 +59,9 @@ #include #include +/* runtime pm timeout */ +#define FSPI_RPM_TIMEOUT 50 /* 50ms */ + /* Registers used by the driver */ #define FSPI_MCR0 0x00 #define FSPI_MCR0_AHB_TIMEOUT(x) ((x) << 24) @@ -394,6 +399,8 @@ struct nxp_fspi { struct mutex lock; struct pm_qos_request pm_qos_req; int selected; +#define FSPI_NEED_INIT (1 << 0) + int flags; }; static inline int needs_ip_only(struct nxp_fspi *f) @@ -927,6 +934,13 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) mutex_lock(&f->lock); + err = pm_runtime_get_sync(f->dev); + if (err < 0) { + mutex_unlock(&f->lock); + dev_err(f->dev, "Failed to enable clock %d\n", __LINE__); + return err; + } + /* Wait for controller being ready. */ err = fspi_readl_poll_tout(f, f->iobase + FSPI_STS0, FSPI_STS0_ARB_IDLE, 1, POLL_TOUT, true); @@ -955,8 +969,10 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) /* Invalidate the data in the AHB buffer. */ nxp_fspi_invalid(f); - mutex_unlock(&f->lock); + pm_runtime_mark_last_busy(f->dev); + pm_runtime_put_autosuspend(f->dev); + mutex_unlock(&f->lock); return err; } @@ -1216,9 +1232,14 @@ static int nxp_fspi_probe(struct platform_device *pdev) if (irq < 0) return dev_err_probe(dev, irq, "Failed to get irq source"); - ret = nxp_fspi_clk_prep_enable(f); - if (ret) - return dev_err_probe(dev, ret, "Can't enable the clock\n"); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, FSPI_RPM_TIMEOUT); + pm_runtime_use_autosuspend(dev); + + /* enable clock */ + ret = pm_runtime_get_sync(f->dev); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to enable clock"); /* Clear potential interrupts */ reg = fspi_readl(f, f->iobase + FSPI_INTR); @@ -1227,12 +1248,14 @@ static int nxp_fspi_probe(struct platform_device *pdev) nxp_fspi_default_setup(f); + ret = pm_runtime_put_sync(dev); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to disable clock"); + ret = devm_request_irq(dev, irq, nxp_fspi_irq_handler, 0, pdev->name, f); - if (ret) { - nxp_fspi_clk_disable_unprep(f); + if (ret) return dev_err_probe(dev, ret, "Failed to request irq\n"); - } devm_mutex_init(dev, &f->lock); @@ -1249,29 +1272,72 @@ static void nxp_fspi_remove(struct platform_device *pdev) { struct nxp_fspi *f = platform_get_drvdata(pdev); + /* enable clock first since there is reigster access */ + pm_runtime_get_sync(f->dev); + /* disable the hardware */ fspi_writel(f, FSPI_MCR0_MDIS, f->iobase + FSPI_MCR0); + pm_runtime_disable(f->dev); + pm_runtime_put_noidle(f->dev); nxp_fspi_clk_disable_unprep(f); if (f->ahb_addr) iounmap(f->ahb_addr); } -static int nxp_fspi_suspend(struct device *dev) +#ifdef CONFIG_PM +static int nxp_fspi_runtime_suspend(struct device *dev) { + struct nxp_fspi *f = dev_get_drvdata(dev); + + nxp_fspi_clk_disable_unprep(f); + return 0; } -static int nxp_fspi_resume(struct device *dev) +static int nxp_fspi_runtime_resume(struct device *dev) { struct nxp_fspi *f = dev_get_drvdata(dev); + int ret; - nxp_fspi_default_setup(f); + ret = nxp_fspi_clk_prep_enable(f); + if (ret) + return ret; - return 0; + if (f->flags & FSPI_NEED_INIT) { + nxp_fspi_default_setup(f); + ret = pinctrl_pm_select_default_state(dev); + if (ret) + dev_err(dev, "select flexspi default pinctrl failed!\n"); + f->flags &= ~FSPI_NEED_INIT; + } + + return ret; } +static int nxp_fspi_suspend(struct device *dev) +{ + struct nxp_fspi *f = dev_get_drvdata(dev); + int ret; + + ret = pinctrl_pm_select_sleep_state(dev); + if (ret) { + dev_err(dev, "select flexspi sleep pinctrl failed!\n"); + return ret; + } + + f->flags |= FSPI_NEED_INIT; + + return pm_runtime_force_suspend(dev); +} +#endif /* CONFIG_PM */ + +static const struct dev_pm_ops nxp_fspi_pm_ops = { + SET_RUNTIME_PM_OPS(nxp_fspi_runtime_suspend, nxp_fspi_runtime_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(nxp_fspi_suspend, pm_runtime_force_resume) +}; + static const struct of_device_id nxp_fspi_dt_ids[] = { { .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, }, { .compatible = "nxp,imx8mm-fspi", .data = (void *)&imx8mm_data, }, @@ -1291,11 +1357,6 @@ static const struct acpi_device_id nxp_fspi_acpi_ids[] = { MODULE_DEVICE_TABLE(acpi, nxp_fspi_acpi_ids); #endif -static const struct dev_pm_ops nxp_fspi_pm_ops = { - .suspend = nxp_fspi_suspend, - .resume = nxp_fspi_resume, -}; - static struct platform_driver nxp_fspi_driver = { .driver = { .name = "nxp-fspi",