From patchwork Wed Apr 23 06:11:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bough Chen X-Patchwork-Id: 884282 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011067.outbound.protection.outlook.com [52.101.65.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 121D72676E6; Wed, 23 Apr 2025 06:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745388638; cv=fail; b=ooQxgocTCTMXqlrWj7RNRSbqphzoF5nlmW5bvwxus1T/P6VT6ANTDNW7vQtVytZxvndsi7NYQynDo1K8xvxpxfccRJRgaShOfO9W244IeytWksiNukDeTXCN9QlAA6EBWGpuVGkq6R+r506epNOsglsw0tvrxnRURxprdFSW9vU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745388638; c=relaxed/simple; bh=cFeaoFNjKwmU5hGpWchyxAfTmDsLy1lX4PKmxseUalI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=U+B7tkxwl0IALvqfQytFIFpY7iBEy4oAZJG0qopo5DgQT1B8I3P+HV/50NsP678JToFwLqXJjOIru4u2DfT/ia1bNHseVPM4yQasGPh19KSt3jmgkLtQ1xqZN6p7GRpuKLGh1Cy12m7X/9OfZviWlImnvcnDw+Y6aGBHFnfOQPU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=f+8pPvW1; arc=fail smtp.client-ip=52.101.65.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="f+8pPvW1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T2d30l7HT+G8UTYPbV51RSZ4xhnkBWUd8QXuE7A4UL2Hj9G6fkQbVvbHNhSDmkigGAtabZ48TltBfOVCFA0ApcoP6D0LR9t+Z1gRNj+rpoGT4zkxGbz0AMfn/Mw5k2huCTbMZIyVjPGU6LNwEidKaFBLg8whzWpQi35ysDF+CalQbSdufwMNOzxMp0fd4iOIu7T6KBPbT4wt0ZbqPtz3seRuTFiLvxwk1gaDiWZZMy+1bcoDQfHysFHoe1MTghgXYUVS2Hpj/HCOgSozefIE67xeBn/x3ZmDP19fosWURDhwhT5P3iSKeniX22aK231Q535Ox7KUyAmcIq6kyWIL5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cbAp8vCutNlLewUj11P0p3ODGShz2QoawscXWAYxCRI=; b=NoiQmXsrXgj91wR73VY+WU2Zork6bOpSLG02uz1apocCFs/8J55c9PZ30bratqA/PP3cOpiKYuC8yyhNMc808KddTRoKD1lv2ZL0rt8gwDNG7n20TdQ3i6/yPOvBCYoXPR1hh7G7mjngqLhh7kiIG3gGtAUmH5oS3a8nP5KTFUiFfArVtlBM6PTxZ8EmlkdFVDrXMjjOcyqZHZ/CAruhXSJVEd0AwddEZgvs37A/2tzfAQ82lcM46bzIWTSyl4mjvnxPjOk826qoCD/81xmvckp2z4mjLfq3iLRDTa3inmMi2JLXERrWewLiNiDvAUwGLcC/ldGBJFmqKb/RG004+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbAp8vCutNlLewUj11P0p3ODGShz2QoawscXWAYxCRI=; b=f+8pPvW12wZAVSJQu4fp5I2gR3Jwr3kG7r/sPKPOCn6zRekxjC7C+bSgqhY23BOZ16ZlsMhKYs5r2BsogQpDhTuu9gWLTElA+3ikfSorQwUJUW7Fl6eyHyYmOa+KGapvHAR2+iEbuTBclANuv4eMs1fkb7pqIX/SNSgUREjBb28oZGLBGGawl+MH8Z8CeD4nYJohqwDpwWD7clMqMUFU9b474dJwwecIj47DPSPr1+KH90d72bLN8BgRAurCwC19xNIaitgc7MoUy6OF2ePKJ0fbXhUVfysXk/DOONLlfK0dZHWd83grrcLPSsVIBYHyJcMHMPJZR2mzQvtbf5oHEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAXPR04MB8734.eurprd04.prod.outlook.com (2603:10a6:102:21e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.35; Wed, 23 Apr 2025 06:10:34 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8655.033; Wed, 23 Apr 2025 06:10:34 +0000 From: Haibo Chen Date: Wed, 23 Apr 2025 14:11:40 +0800 Subject: [PATCH v1 3/5] spi: spi-nxp-fspi: use guard(mutex) to simplify the code Message-Id: <20250423-flexspipatch-v1-3-292e530509d3@nxp.com> References: <20250423-flexspipatch-v1-0-292e530509d3@nxp.com> In-Reply-To: <20250423-flexspipatch-v1-0-292e530509d3@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745388747; l=1084; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=cFeaoFNjKwmU5hGpWchyxAfTmDsLy1lX4PKmxseUalI=; b=AV1OoL3ZN64HadpACvaQZvxF5DiVrswwhStTwJQ99VZlPpPDjN+uAyXKVEWNkV0wJiyTgq6MH r6GHYWtfuhNBejx5D9Cof97qopCObmWqa3WVAhtI6eihqECa5wTZ5aX X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: SI2PR04CA0007.apcprd04.prod.outlook.com (2603:1096:4:197::19) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAXPR04MB8734:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a7a6ddd-b748-4c09-06cc-08dd822d8f26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?SQV1WiUFYXbx4GscIyUzBJ3eJYxooNM?= =?utf-8?q?KLKFeFelS+3+TKmIUX/yaRDmKafRzhpdP/MAWOgEYn+Av0kNNdxEcK3qTFcHpEp1p?= =?utf-8?q?4wlHrTwOfUbLVSv9F3tqKHKr56FEzSmZDUcwY72RPtPFeXUE1m2RsYmSerMOlCkFO?= =?utf-8?q?PUwvosNlhUUn8xcdkjTGSZmrVcxXNbOnjYrvu5A8DSN3ET888vmlTiWEeiQdphqiy?= =?utf-8?q?jsSrQu11T8F+r1RRHTEQMLDiR/AIjRY3oxeFlPdaN0zV2LHtLREf1KTnc8HU4iMIt?= =?utf-8?q?SqmvuYSONQIO6aICxHd1GahPJ+7pUueJitLeo2oi/rgyjE0hknjAZg8HW57O7HUaP?= =?utf-8?q?xRtAadiu28RMokIW++XtERQCUNc+Z4AHyVAFEIQXNHBzqmgpkLSMvLE9PafzL2h8m?= =?utf-8?q?TaOYwp/3hp9ucz8eHwM5HUX1YM8B17MJMqIVE1MmWlPSegjyAEfop33ppX64I2X0/?= =?utf-8?q?6ZaHakqC4YxMk0KC4J6i/GPTjbL6nvQPc/Ut0LK9CEYFeZ/lLem+EXUR3ybucYe8o?= =?utf-8?q?gRFCshE9U0C47SvIagSPJ0Ns8ZZNgFH8f17/DFKPaxXH01QWTLrNFWDxA8g6VyQnL?= =?utf-8?q?KxdkAjhvNaP+7BtqHA9roiBclipyRd3dcbp4nI33uIf987LwsJlNOYc8BBAsYH1/F?= =?utf-8?q?yVTxcULjvViv0QFHCuqLxpIEC2C6TCqKaer1z9A7HulQl6frk6fpAG4PnEWVbNY8R?= =?utf-8?q?tlt3MbcKXwq+1b7zl3YrZfn+TCfbontuwqPRjhlbB6BYeg71F3SFDJLHKbmFQF8EY?= =?utf-8?q?wG15PEEngVeFGrOGYJkDi2ThYVl10byKAD+aHnyJuJgt6AbQEN7VRLAzti/y+gEqg?= =?utf-8?q?k8x8bMfKhDjLtAR6C5cpkHTNJb/sxNeFUz0l6WkhbDtKDleltG2xEfV2XyOXWFW3H?= =?utf-8?q?E+hbcKgCA1foc1/AQyLQiQotS/m+hovtyrj2YqiyD6nOF5mKzk2EiVkwRYfLT6iT2?= =?utf-8?q?edz1zBC128uk9Xs8e2r2DuubW3rDpvrmL5MpoTkgcSfksbzARBv9g9rAIESZLmQ0l?= =?utf-8?q?ZEbiXwUbR4zP3l0a2u2SWWZuzNV2oenvGQfMxCzjKn2Zn7IsSafS6wQvvB1fSppUC?= =?utf-8?q?RM5yboC37fnp677VGzLmOtwVEqRkb9bNlFHf0Vc5LAmBAcKKyGAcF+srtoHQf2dr9?= =?utf-8?q?xhs/HFRmwEHYWTxDdgcVmTuFzssJxjSLnnaHph1se0+sMEUMXjGiheenob9yg0sHC?= =?utf-8?q?FsQXlhrXyfQobxI6YMGNe7cn64D1H4ndKvu6zQtXAmxGFohnDvxMceQbx5NxmnHX0?= =?utf-8?q?U83RufKOJi/ixBgng2e9b1fpiAvjt5V9qYD7WXcMr0fgPyirOyEfaIU35GE5l1y8M?= =?utf-8?q?OKr7HavRHmM0jGBRH81Dv2cWZnUq1PKRyUB2i0SNYSBaw/l7A7tkG+x2/aQC5y+TA?= =?utf-8?q?ikXfHrkqo1Yw0wU8iOXlV3IGPRLadgf+g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9496.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0kXSVjtgYCUAkzuxGZTVVDUwsRoz?= =?utf-8?q?s5ayQS0yqvYvuAf+p1WUyen7GpZpbgcYFOB2toPR3F7vAilQP+H+ixtIQw5hMJSCR?= =?utf-8?q?DRg/wNxTtz4uC3L4x8rKpYUl5dUa5EN25/CTbCKhDDxZqU40qica48Et7EAW5Y5cN?= =?utf-8?q?cWevXCeaMWAoSePM8A7tMHWqeVehA/Z1hYPNTkROWSbnhHcHHzmfpOz1wQtPMtT8A?= =?utf-8?q?sdsdnAxnK65YU2X97+avTGTWmkr9wgN3MMTeZ8LQ+/5J4eWW+hoWei3OHGr8YSpqy?= =?utf-8?q?WuCUSWrLxQSBGE2pMm0h/4jKKbnebStmitRmrCqCgUdeaDAHJGJifiJOcu5Xo9GAp?= =?utf-8?q?2+YSvxY7ZsKbsZQ+FkX/V5Af4vCU+yZYGSEun9L8LKja7Tm8w2/EAFuNA5GElqx38?= =?utf-8?q?3xL3q5p7chZF+MPjvZWmq5qK3k60O7pAHUq2zE0HhnXWEPj8xOjodboZwt+xHOGYL?= =?utf-8?q?nd2KWA+BORDR/c/atA8bOeauIoZqv1vXpqqwpNQJlRTUVUHCRelXP/HEnDdCLPZ2h?= =?utf-8?q?xRqROjWggE4M46TpwKM4yGc5ohmEIqK0hlPh9kLOtEbg2HYPelw8e02Zm3J7TI2/C?= =?utf-8?q?ORMQ92AJv5tp76BbNIuUrI0UP6VJiBHvSE/0XQGX0nNh7WsCVYBw8jajEbnnQIGq3?= =?utf-8?q?BzfAMevsljgFRMbzkRxermYGUpM5l35Y00sojauUnct33+owXolbvJsc9YaEu73+a?= =?utf-8?q?9jfAyPo1pTH5oi2P+FS8Xz0ynK4wuZBh1PJwQk1ZUpYhzIbihX9sk2fMrJCs1f8S/?= =?utf-8?q?gcGgOYlweAVIdV/1uS2k1FFpTDNjwR90KM8LagazlWl8WYIdYF2dwLI0VUKMZjRFQ?= =?utf-8?q?b+BNQyNv/pTqt7DOux0Ort7/yCGdNfp1Vsxal5nz2uFmKt+IgeYZNoIJp08fQWcYn?= =?utf-8?q?s+bIa0dlOrKSM9iD7fMWBy2XMkSLbpaCBcO2CAZzQ3A5zUJd5vCoHZL4sQzfi7MKd?= =?utf-8?q?tno8ftuv9Q7D+bSw+crj3m2pNksZe3XLtsjCJdPaXhLmujGfq1m0mmCi/L0iKfi0G?= =?utf-8?q?M9RjoHTsworbnqGTBFYCMGpemzI+k47P3KNYmG4bSKy+g9lfyU6qD59X29TjskfDm?= =?utf-8?q?19yKn00zqBWxSGF04uzpPPc+9HXifwtrUGtxLpNHXjyjXaIYly8+MdrQI2wB2ufbh?= =?utf-8?q?/ruat8FHFLQplqmzey+O1yjRlpMIfNXFCa0zN0YBAgJjHEYx47lxKvdIBHaAuABK5?= =?utf-8?q?NcTGp3KbZih9LcjOfOXE2afEwt6uPtVgkoDZcvYr+Dt68q0wHES4EKyN4Hb+7ySdo?= =?utf-8?q?DPw5A6hyidbXTdOGVrB8XlGXTBsrjNUkhTvYpewj8XV3oKrMQuL8gcMMMC9zDAFJ0?= =?utf-8?q?zpZGKMGEU6B6BgGB8X1jqcWOwl7KhmGwtqOcjU5TZdOaEyY4rzkA9hFaxOVN6EnIg?= =?utf-8?q?M3xjOdTF/RXB/UQlcQPmQx/6Q7puk7+pVW7HvDNGUMmpj6Rvy9XIrY7KV434YO8zi?= =?utf-8?q?nYQw/QqQDEaibXbKlLYR3jaiwhslCSF0K6WHwLPF5FJ/6MC5VCA042/ue9ArXFE7g?= =?utf-8?q?aKQc89gyykci?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a7a6ddd-b748-4c09-06cc-08dd822d8f26 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2025 06:10:34.5040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qi30jiljJrsMZv15Qw7H6FPMA6qkl8bKtqFJemjcjRSBb98C9TO/RkLkorBjXGA76LOVxX6tCee+mO25X0PM+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8734 Use guard(mutex) to simplify the code logic. Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 23099e60b6fb7e899f95fa0427208b33bc5522ac..2eafd6bb819165740f7eeddaf5d2e90fc5682b6c 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -932,11 +932,10 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) struct nxp_fspi *f = spi_controller_get_devdata(mem->spi->controller); int err = 0; - mutex_lock(&f->lock); + guard(mutex)(&f->lock); err = pm_runtime_get_sync(f->dev); if (err < 0) { - mutex_unlock(&f->lock); dev_err(f->dev, "Failed to enable clock %d\n", __LINE__); return err; } @@ -972,7 +971,6 @@ static int nxp_fspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) pm_runtime_mark_last_busy(f->dev); pm_runtime_put_autosuspend(f->dev); - mutex_unlock(&f->lock); return err; }