From patchwork Mon Apr 28 10:06:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bough Chen X-Patchwork-Id: 886014 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012040.outbound.protection.outlook.com [52.101.66.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180F62627F9; Mon, 28 Apr 2025 10:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834719; cv=fail; b=BM6y6ddCXXS5B/SWcOfi3++lYYaoKHOrGZDFKMDU5n/ocGv0qMV6vrVim8uIAMQNzfUSCiBu5+b+AiKRzCXLpcc0kMIerYEiqXb+YI1ePqX16u+UhXZj0XkPjqjrWgMftYYvn+4AqMhCft62LL8ps45wA29oP/IvbiY36dDcgzI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745834719; c=relaxed/simple; bh=krpq9nhBfLy4zLPhr+UXTcOoYRwPWSk58aZ25kSzJU4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TrsK/YUNGzth2xwf3U5yPoxLtvqcirwepji8nfXpEh6hbXLYCWXP6IvaXUzDtFsXRBCZoxFQfH1C6joP4SIONh8tP1w5VoMX38ccrY2Fgqlf7Y6g5+fyAKiYWxZIFHsX/hjR3dx8i3u0qwrNjK9x4e5EN3Xt7UjuQ6MF2+sRTJI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FjmBLcAI; arc=fail smtp.client-ip=52.101.66.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FjmBLcAI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jymGuuV9PI2vv+XiWJMx9w8CdtStvhOi+rYhdQj+/DYfHW4rIPtjQ5YtzAz2vLo333GYBM4Km1Wk1AZWAUgKkGqGCg5m4htzajDxkxQA8GDeaLFRz4f9dGSM9w58ecBmbfdoR5ztXTF7BoofhzFdL0+JQ/7p2bi50tFQek3HwjhiJdC9mlZKm69PqeIx2amG9zRxtyImiBaGaLdzSWmOgP212wwpLwwyjVSSlphTb44QvA4il3O+z+ra/XTAff5NRzQBLj+xbXTzXXCBik2fR9H0BkO6wyBACHKhqKKUXBExlNbBkbXywErHzM6nlN+3f3dEX8WWuGePxG5NsZPrqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2FR9ammIYrrwyCJlXxuYqT6sm/P/vU4f/u5CjUy3df8=; b=G/8/Ut235GDXea1My+fTQfCsAvz3I36abJu2E7wLiVKQo7npRNh6aJUbivt0TOvLdxPyEW2tGfxNwF1NV5mkHX+Kyu9CSfomO3eTWGv4JNnKcQANvjDUkuSuwcrVGQR9xj6usSSa/fU8wVnyRhH+oiQECF3zVc38NUF9ZFBQaSMF6rLHNDNHdp7ZdO5mpp0d1zZpH/pigF7qCTjnhWSShF50jnAj8kB4VpjqhP8E+UAzgB9nHgRsc+Wg7nqSxVrQiER0YWVkGm/6S4/KAdMlpqkDn1Sxiqm9W3McDdYbXype8eoDnrmZZS+rujR1HpzuXh2/ffRr71etSRbzz6ktxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2FR9ammIYrrwyCJlXxuYqT6sm/P/vU4f/u5CjUy3df8=; b=FjmBLcAIaCHG1Jc6qne+Hl1ebQTbBer2VYsyoV0OUOvsy1d7foSAhwzADmA8+pY5wZIf71Sc6e9+JNet5ft55viM3dgulSmF7fZiD8vrD025/M6ZG4LfE6acX7gpHBDT++K7yX5YhC++EIOckfg/wsaQxkeFS/g5Idi+e7ev1newNiCCFwV+RKj7wwZyICoDIRt/EeX1sL7u4zPtG5COTV0CTuXkAIG+HJktvhGQQZtgubvX+/RHp+zcWaVOxKtqgRZbjRqi5oBwVfPiiXgCnheS6qidIce5eOuSTjenqmlBzEJzzpsUCMoCjPWEvUV//gykBlMvpRfVfbAjvMjhfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PAWPR04MB9862.eurprd04.prod.outlook.com (2603:10a6:102:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.33; Mon, 28 Apr 2025 10:05:14 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%5]) with mapi id 15.20.8678.027; Mon, 28 Apr 2025 10:05:14 +0000 From: Haibo Chen Date: Mon, 28 Apr 2025 18:06:46 +0800 Subject: [PATCH v3 4/5] spi: spi-nxp-fspi: remove the unchecked return value for nxp_fspi_clk_disable_unprep Message-Id: <20250428-flexspipatch-v3-4-61d5e8f591bc@nxp.com> References: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> In-Reply-To: <20250428-flexspipatch-v3-0-61d5e8f591bc@nxp.com> To: Haibo Chen , Han Xu , Yogesh Gaur , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1745834827; l=966; i=haibo.chen@nxp.com; s=20250421; h=from:subject:message-id; bh=krpq9nhBfLy4zLPhr+UXTcOoYRwPWSk58aZ25kSzJU4=; b=BMS1sYs/om34v1q537xQSzogKrQAWdMdLtaFp1/hQSeJtgPYMaZUXXbBKObC2zN3XIRBe02Zi 9xzd1OMlnBCAmQzUzum76VZ7y4grNYBZHPhwJNfAz6Q0rB6f6Dy8eWj X-Developer-Key: i=haibo.chen@nxp.com; a=ed25519; pk=HR9LLTuVOg3BUNeAf4/FNOIkMaZvuwVJdNrGpvKDKaI= X-ClientProxiedBy: MA0PR01CA0011.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:80::9) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PAWPR04MB9862:EE_ X-MS-Office365-Filtering-Correlation-Id: 24761bdb-ca6a-4963-ad24-08dd863c2b5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?qv4cN6LYU9nbXhb8WzSBDV8voSQsPxm?= =?utf-8?q?4ueVaHmCOGRbaGJBVzcu8tTHMkegl2NDCI234jJM6E7DwgTV0LCl/xjic1BuSKw3U?= =?utf-8?q?ow2Yx/SRrGCFOmAcanqVtu/RER6Epyq71FcFE5cEJu3zOhI9TBiML1nyKcRAHy4xK?= =?utf-8?q?l/pJYSZpnNvD63/5o1FzxQHHSbGIicepHAloTcKGLCLbUIYI4t97kAOBIMwNWzVeW?= =?utf-8?q?OcAT9K+jk65P8zGv0SmXj+yT20gkXo1hi7hSEGwL8Nch/2l8EUEZywhC0Vs8B4lr8?= =?utf-8?q?bwPIS1DeR0ZI5V+CJkyUrwmd0IUFDoU6Oy4e4aWs8tT55GzyT49mJ9GHepuDDvLyo?= =?utf-8?q?7GrRJrnQsHWBIlXNG498MMCD8of5HRaXltCY6F5ndMHdVoNGoZGvTFQX+xGcDx5ec?= =?utf-8?q?/hZw1iO0alI9+QBk2TI+i2kkGT3wdgdasSSWKYRdcG9tDZ7DUJ54qEHizQCatK93Q?= =?utf-8?q?mxP6UGSZA8FmeEFlxA9dLi4Yh+a9RpboVjWLD9sYF/wOzSrnIARiGj9CDF29xLDJ9?= =?utf-8?q?RsjOv2n5cfjtflKG6nLe66yHmYY+o7TuyVeK4wq0vXVVitCe5oejEfXVI9GqaQnvJ?= =?utf-8?q?9CVV4UmGmz/EfX9xp17/EkIHShLQ6jkPkG1w10owVfVAsapxM2zyvTg40INzat0A7?= =?utf-8?q?HzlX+6iziVOWcVeWxSgnA+t5cQKB5Jm4SWkhBPoUi+4u0yFKYwgHCChthYBm2jnRy?= =?utf-8?q?uqjmj3eh+31qMZLYPCqf+rXuTR8PEJTpYc2a3vpvUbdGLBe6WVFqteyaaiTUowTjF?= =?utf-8?q?KZUHbMXtysfeMM48oy02/KhOv2D+vRkKMZSgsApBUq33afN1+6qayi+epuHrSzY6K?= =?utf-8?q?iCGQaB1Esl6+LjmftKuy5XGcnXZaLZe7ZDarunUbczjZ1yOhZ+ng1QHFEW9CqFnmb?= =?utf-8?q?2fq9kt6Ov3QtOHYvoTXM8OMX9TAUWMBgimFFGkDkpUOP0JEO84CCPBJhdWeNlQte4?= =?utf-8?q?4lc8tncW6MBv0ExTQxjL8gJxygpHyPLo9oqL1gDikw5TUFNEEkjYetcSYQekE9oHA?= =?utf-8?q?Ox62Yec33j0tKpRG2V/XiUSV60G4AtCY5tPpzvVN4C/GsazJNcXL6iIf652G5aQFp?= =?utf-8?q?uQwFhxLWMBvLLS7ru6xTlBWsYiHFQ/decLAug1mh43eO9wyquWQzbX4Q2F086YM2i?= =?utf-8?q?W3HSJPgQVpcZ/a9ShSimKAW0FuqxkC83CVKOh4Wj2lsYKqO9tzC0HBWhVnLj9Fvre?= =?utf-8?q?SAifWi/up09H4RdsDBd+n502vA2T7jrFOuOaQ2yZhSVkqJ1KPNtVRkCePVRa+psbg?= =?utf-8?q?4ItNbss3eOlhofm5augivYeUeCr8WIWtdqsV2ooNvC0Qpf7hyTS34iI9xnjwb/LQ5?= =?utf-8?q?kUVsdp+rPUAcKuxPmudP+gP63wgkP8Q6OBeXWfqeFgY13B6ngSGVLfmt4rvxvLA5i?= =?utf-8?q?EZFCZGsZvEYIm9f/sIWzuHKjrnVi5IarA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9496.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?q9VqCEWkjQHLG8vixZ8nboGbaBQG?= =?utf-8?q?DUpnqZFF7Vj91hXbiedFXoerg8cR4prKuoRifpSTIasOW76vUVS2DWobZUINM+/Pn?= =?utf-8?q?WUhA8stqCRpemjeTDJh9clLWk/lEGbb2RffOmt1RJ8zgiuFtTxHZZsvwJZ9Z1Cb2b?= =?utf-8?q?EDzcHNtUA3p4WTLNeijCV6fzUIzsZ67buixgof8jEljD9Giu04nyxfnlszXRQeYc7?= =?utf-8?q?6eMXLMwAZBxyKiZEl5/6vqAmZ+MWVzyX7Hk0FSsNS/NOuNABB78m93VxTW+ImB7wP?= =?utf-8?q?j7TVa0RZzBGgp0LHrHrgkcvE+bevSxYf28lQqic0kI9imLi4spf2kEKwEe0tdwh5c?= =?utf-8?q?gCTTqq47jRriFmQghpywGPN4H3B1m4FQctzQ7/HA+Mt27KCneYh3PvMjzK/cVjdi4?= =?utf-8?q?177yzWY1T/NMSY4XAp/Qp5SnYUJjgE9Abt0ugyxheGtteJmbqFTEJ8bHyFiFT8VL1?= =?utf-8?q?P1Ded1YpfXN23rDGam1Z+9g7DdQYIhc4F2HYHUuRt40MRQbLIb2ofdYd2MwKIOjAW?= =?utf-8?q?PmqjJvQ8gimluCKxLKServaMZyYZVfkJnSs7Xe4rP5lSvbS7wiVlYk7cF89mRFhmk?= =?utf-8?q?XGZzmtuzOqTShkgzi8BGxObe3uaV/9M6sCYQtswQ9W5lLTHhWjYVEcrVEzjMfJyqD?= =?utf-8?q?RPdfVEOKB39pvTU8NFxwoWu8OYCE9b6MP3b5/vTlWKQpq0Eeu9dXCqWVb8Lz1g9nu?= =?utf-8?q?6PXJYr3NAC20gnz1vKlbVYbSswwzx2SUCyMLMdtufbE9hR/3mlpVVsS+m1A6v2nvn?= =?utf-8?q?3bLkAb/JUUjYBeLKgoMh/aigExnzDwwxuBbH3Tff9iqwAeA3BbxhFbUyiDPpbuMnn?= =?utf-8?q?G+uw+znQ8NDzqV3WgXenCpOZ0VVMwdMsb/kK6Es6OTNo3YQ6FsUqSHOqyuQhbTTC6?= =?utf-8?q?oS7hAJQvNvbMi7gawPGvZZ39fKLPzbXWRKi06n4leWtfE+mfWW8Ig/fYIWQ5onGRC?= =?utf-8?q?wqPEWBgyPInnYJL+Qxzc/3+X2Js+OXjNlW1yLu80vUDCuRmJrno9RCv1XBnoqh7mR?= =?utf-8?q?npzrEuMNLzRruyZIo40jWtP5RfPfmoB0Kga8FdOt2BqF5RE7U1kJCDDRP1nnhneep?= =?utf-8?q?Cw7+aUGGeDfKD7W0FEnm/vfD9EKc0MC4TrABWipC7XDDWyEuCoTnUzmkhIwmlg7g6?= =?utf-8?q?3Zwbl+5ZbSiT6ibnhxkEpWrPCeC6pTquktWjyCKpNpfsEZc8mAtP3cnQzro18SIHE?= =?utf-8?q?LHbdDxmMPg5pf1c4DkrfmaAycZFxMVP7cY8oZYiWa256EJbXCTvOV3vpC0d2NCxMj?= =?utf-8?q?Ik97/uSUOjPzvLteYu5iKiycQ3GtRqYrS6QPo8wXbZRc2jhXAARrh+joTahnK19j1?= =?utf-8?q?kGLRB1ljeAr/WobSOU6ALhPyildP0xRFA75ydd5IzSe/fB4MmBzWL5g+W8Qlj1vtN?= =?utf-8?q?ORlPEVMuuayG9LXMrILc/RNQ35Sn/4gO4OTvPgiSfBRd3JO59Ck5GK9qtglFXPmC8?= =?utf-8?q?v8tqaqjSAkvApStkroTGwiLIQ5rWaC/qWvyaHLSyialBNas8grIew08v5mx1961UD?= =?utf-8?q?cv1i2JsLWcjv?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24761bdb-ca6a-4963-ad24-08dd863c2b5e X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2025 10:05:14.3921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qID5QG3vR40RpjJDUw619pH+XFAAaC/d4xjXL3YHxi3fyoIxfpNcpQD6MPOUuCgamHek2bcIfb/t7jnkcZijpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9862 For nxp_fspi_clk_disable_unprep(), no caller check the return value, so remove the unchecked return value. Signed-off-by: Haibo Chen --- drivers/spi/spi-nxp-fspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index ca0b51a254c15f45a9e91907900d94d77f1d5dff..0ea04e77a968b9c8dbd73a76984022a8f9e9b178 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -634,15 +634,15 @@ static int nxp_fspi_clk_prep_enable(struct nxp_fspi *f) return 0; } -static int nxp_fspi_clk_disable_unprep(struct nxp_fspi *f) +static void nxp_fspi_clk_disable_unprep(struct nxp_fspi *f) { if (is_acpi_node(dev_fwnode(f->dev))) - return 0; + return; clk_disable_unprepare(f->clk); clk_disable_unprepare(f->clk_en); - return 0; + return; } static void nxp_fspi_dll_calibration(struct nxp_fspi *f)