From patchwork Sat May 3 11:10:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viken Dadhaniya X-Patchwork-Id: 887723 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F761E5711; Sat, 3 May 2025 11:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746270651; cv=none; b=Z2gEUt1eTwoqcytdWV6zOQR3YaCiQA1YGRHFFCDc93nkR39P4f7jF7AdEwtBc7eFRzFPZcpw+/MZF8zUuukB8Nyc/8T8UXEg/vzQQ7F6AUQbVDWrrudImqkON5wNu240iPfBAgYeBcjCFeF1PUpbEMQHoFrWLAG4R5ggAjdnULQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746270651; c=relaxed/simple; bh=hb1OYbOycAABCf2zaLLfH4evg2uP0Ka45QGAgVuQy0Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tIomWdwwqzL5HMMwOE9WuIKWLVTSSaXtGib+13jt9uOPNnZiJ0thILwarJaJ8Yjha3QhAwCwowUyeSshz/CGgsnVB5Z/ketnkpSmpwgpEkFItR7rLvVBE2E5s7W2pIpwOWZMXkWU4pSswecgn3VqIMUOOn36xo2J3TdyHLoLRb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=LivuNdkE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="LivuNdkE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5438oYwn021902; Sat, 3 May 2025 11:10:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=X27MaEDNARL nmj9qcTeqGQIgmiKIwXyYS0p3H+X6Uw8=; b=LivuNdkEvsLLwvjCozWmQXTJs4c e1Xw6zyv03SQBdjtTHt4kPspQYpNlK43awo/BnneiN/Y0NjRzgh7XR3871/USrJc HrEnff3Dh0Hq915sS35UDBgZF05PmsOWCATHPGGJs0LzNRLdPQ/nkxCEzIwDOPLN yzSjvrm5EzZrf0994scVMUsd4lCGvT/ZKTxjcJcdReuaOcvHKXVhWMu0+nzkRGQx /Nm7mMbx5IycyF710NevcmzWUU/GcS+lv1eJGySjcGdzWOFB6tOfZ24KDLF3sGaH 5bnK4F4wHSHBmrX7wWZHk65ZRSuTFmU0ssNCJbaA/WuOD7jxw4eo/kNI9NA== Received: from apblrppmta02.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46dafg0j84-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 03 May 2025 11:10:38 +0000 (GMT) Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTP id 543BAZRG023642; Sat, 3 May 2025 11:10:35 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 46dc7kjmsr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 03 May 2025 11:10:35 +0000 Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 543BAYgD023624; Sat, 3 May 2025 11:10:34 GMT Received: from hu-devc-hyd-u22-c.qualcomm.com ([10.213.97.252]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 543BAY4T023633 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 03 May 2025 11:10:34 +0000 Received: by hu-devc-hyd-u22-c.qualcomm.com (Postfix, from userid 4047106) id F247753B; Sat, 3 May 2025 16:40:33 +0530 (+0530) From: Viken Dadhaniya To: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, broonie@kernel.or, andersson@kernel.org, konradybcio@kernel.org, johan+linaro@kernel.org, dianders@chromium.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org Cc: quic_msavaliy@quicinc.com, quic_anupkulk@quicinc.com, Viken Dadhaniya Subject: [PATCH v4 5/5] serial: qcom-geni: Load UART qup Firmware from linux side Date: Sat, 3 May 2025 16:40:29 +0530 Message-Id: <20250503111029.3583807-6-quic_vdadhani@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250503111029.3583807-1-quic_vdadhani@quicinc.com> References: <20250503111029.3583807-1-quic_vdadhani@quicinc.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: YqL1zhZkjC8mB1Hg0SA7f4yYxK7sVcfs X-Proofpoint-ORIG-GUID: YqL1zhZkjC8mB1Hg0SA7f4yYxK7sVcfs X-Authority-Analysis: v=2.4 cv=atqyCTZV c=1 sm=1 tr=0 ts=6815f9ae cx=c_pps a=Ou0eQOY4+eZoSc0qltEV5Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=zIdmu9zckVospZd7ahEA:9 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAzMDA5OSBTYWx0ZWRfX7lEcruIXbpk2 M/WvJN+g338UOzP7P6weYaRKdxnchf+pLJEXIWNW2C0agla2ToA97xvn03+fuu3ohU4GpcLtolE uY6H8zeg7zd99JkKhCcYtxImt4bDG3y3OGgUhzo6vvxKxf+y3ta6EdWMyafJUBjmLTxWJ3Bwciq zqnKFnzb3/qs7AJB5Dm3imJ0w5VRAlbTiaQpRadgGArX8Aq0UlbfFMx8a2ZJcggU+8IGV9ImHP7 fKlX584oJB4GAGvmJfBusP6RmIdzgvHz/LjTM1PNKzO1PMBUy5+VLd6A4ThbT4sDwQwDXUkkafV fLrw/E8sbspwo/N5Ko/OkaR4j2CJrbwez1MQVgd4JPj+otEAqXPVB2/hbzY2uQBUeHewSLE59xt DxSJpuTP2SFJDc/nbzjST7loi12A3C/3HeyUtD80itrnNp7HAvJZl3xlNfOU452BFel4g43z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-03_05,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 adultscore=0 clxscore=1011 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505030099 Add provision to load firmware of Serial engine for UART protocol from Linux Execution Environment on running on APPS processor. Co-developed-by: Mukesh Kumar Savaliya Signed-off-by: Mukesh Kumar Savaliya Signed-off-by: Viken Dadhaniya --- Dependencies: This patch depends on patch 2 of this series. v3 -> v4: - Add a patch dependency note. v3 Link: https://lore.kernel.org/linux-arm-msm/20250303124349.3474185-10-quic_vdadhani@quicinc.com/ v2 -> v3: - Load firmware only if the protocol is invalid. v2 Link: https://lore.kernel.org/linux-arm-msm/20250124105309.295769-9-quic_vdadhani@quicinc.com/ v1 -> v2: - No change. v1 Link: https://lore.kernel.org/linux-arm-msm/20241204150326.1470749-8-quic_vdadhani@quicinc.com/ --- --- drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 0293b6210aa6..9f905ae3c127 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1161,7 +1161,13 @@ static int qcom_geni_serial_port_setup(struct uart_port *uport) int ret; proto = geni_se_read_proto(&port->se); - if (proto != GENI_SE_UART) { + if (proto == GENI_SE_INVALID_PROTO) { + ret = geni_load_se_firmware(&port->se, GENI_SE_UART); + if (ret) { + dev_err(uport->dev, "UART firmware load failed ret: %d\n", ret); + return ret; + } + } else if (proto != GENI_SE_UART) { dev_err(uport->dev, "Invalid FW loaded, proto: %d\n", proto); return -ENXIO; }