| Message ID | 20250506152350.3370291-1-va@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND,1/3] spi: tegra210-quad: Add iommus property to DT bindings | expand |
On 06/05/2025 17:23, Vishwaroop A wrote: > The Tegra210 Quad SPI controller uses internal DMA engines to > efficiently transfer data between system memory and the SPI bus. > On platforms with an IOMMU, such as Tegra234, DMA transactions > must be properly mapped and protected to ensure system security > and functional correctness. Does this mean this is not valid for other platforms? Then in allOf:if:then: disallow it (iommus: false) for hardware this is invalid. > > This patch adds the iommus property to the device tree binding. Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > This property is required to associate the SPI controller with > the system IOMMU, specifying the correct stream ID for address > translation and access protection. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Missing: dt-bindings Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml index 48e97e240265..522efbe62010 100644 --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml @@ -47,6 +47,9 @@ properties: - const: rx - const: tx + iommus: + maxItems: 1 + patternProperties: "@[0-9a-f]+$": type: object
The Tegra210 Quad SPI controller uses internal DMA engines to efficiently transfer data between system memory and the SPI bus. On platforms with an IOMMU, such as Tegra234, DMA transactions must be properly mapped and protected to ensure system security and functional correctness. This patch adds the iommus property to the device tree binding. This property is required to associate the SPI controller with the system IOMMU, specifying the correct stream ID for address translation and access protection. Signed-off-by: Vishwaroop A <va@nvidia.com> --- .../devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 3 +++ 1 file changed, 3 insertions(+)