From patchwork Mon Dec 22 15:20:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 42525 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D701125BA1 for ; Mon, 22 Dec 2014 15:21:23 +0000 (UTC) Received: by mail-lb0-f198.google.com with SMTP id p9sf3015724lbv.1 for ; Mon, 22 Dec 2014 07:21:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=lW9EtLj3K1/NLWqcevPNjUDy2/ePKccpwL4WgBZKkKc=; b=d/uMbf4O1zwNa4oUyAaDEJ1iQT/FL6MvAy1mZyp5Ml91VFXlTfAXOeO1h6blC9kluc ho/ny3t2Nj7lrlOkbv5nVSDIyHO2b5rGFXW1Vu4ebF4N+bmYxPEyl8fbGTj0JRd5NOfZ LPJj1u9xKvAWPzflcnMS6yBEzDhvoOk+eJeG8Kgq3Cp5QG6xIc8QncwZbEN8r7nfqZjU Ucy/0IK+8vaZOv4h71PNZCsTHrwPBEycne+2IGqw/al7/5ADNCRL/5/UvZqifpOcKrE8 zFGcE7r+Ggb4Lxq+WDS2INMEDawDDAfyfDJSqJeEftX4M6TWqvgdofS8Au/g/T4RkPQ+ jZig== X-Gm-Message-State: ALoCoQnR56h3ZacB9MhInmMZfp77c+Tq8tPoJqwOprqpz2mQFlJ2H6C7oLlFfqjwNAup2YGahimp X-Received: by 10.112.154.232 with SMTP id vr8mr329092lbb.10.1419261682124; Mon, 22 Dec 2014 07:21:22 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.130 with SMTP id f2ls1441673lae.21.gmail; Mon, 22 Dec 2014 07:21:21 -0800 (PST) X-Received: by 10.152.27.228 with SMTP id w4mr22474574lag.75.1419261681750; Mon, 22 Dec 2014 07:21:21 -0800 (PST) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com. [209.85.217.178]) by mx.google.com with ESMTPS id n3si13507870lan.14.2014.12.22.07.21.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 22 Dec 2014 07:21:21 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by mail-lb0-f178.google.com with SMTP id f15so4567131lbj.9 for ; Mon, 22 Dec 2014 07:21:21 -0800 (PST) X-Received: by 10.152.23.38 with SMTP id j6mr22595868laf.81.1419261681635; Mon, 22 Dec 2014 07:21:21 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp1057800lbb; Mon, 22 Dec 2014 07:21:20 -0800 (PST) X-Received: by 10.68.163.196 with SMTP id yk4mr35768846pbb.143.1419261679760; Mon, 22 Dec 2014 07:21:19 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cn10si16165858pad.229.2014.12.22.07.21.18; Mon, 22 Dec 2014 07:21:19 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932071AbaLVPVF (ORCPT + 27 others); Mon, 22 Dec 2014 10:21:05 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:59479 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754768AbaLVPVC (ORCPT ); Mon, 22 Dec 2014 10:21:02 -0500 Received: by mail-pd0-f169.google.com with SMTP id z10so6057973pdj.0 for ; Mon, 22 Dec 2014 07:21:01 -0800 (PST) X-Received: by 10.66.157.4 with SMTP id wi4mr35313049pab.63.1419261661117; Mon, 22 Dec 2014 07:21:01 -0800 (PST) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [70.73.24.112]) by mx.google.com with ESMTPSA id fk2sm10045055pab.10.2014.12.22.07.21.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Dec 2014 07:21:00 -0800 (PST) From: mathieu.poirier@linaro.org To: jason@lakedaemon.net, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v2 2/2] staging: skein: Fixing single statement macro checkpatch warning Date: Mon, 22 Dec 2014 08:20:39 -0700 Message-Id: <1419261639-17157-3-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1419261639-17157-1-git-send-email-mathieu.poirier@linaro.org> References: <1419261639-17157-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mathieu.poirier@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mathieu Poirier WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Mathieu Poirier --- drivers/staging/skein/skein_block.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 66261ab25c88..9bd69ce3be00 100644 --- a/drivers/staging/skein/skein_block.c +++ b/drivers/staging/skein/skein_block.c @@ -82,10 +82,7 @@ do { \ } while (0) #else /* looping version */ -#define R256(p0, p1, p2, p3, ROT, r_num) \ -do { \ - ROUND256(p0, p1, p2, p3, ROT, r_num); \ -} while (0) +#define R256(p0, p1, p2, p3, ROT, r_num) ROUND256(p0, p1, p2, p3, ROT, r_num) #define I256(R) \ do { \ @@ -174,9 +171,7 @@ do { \ #else /* looping version */ #define R512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num) \ -do { \ - ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num); \ -} while (0) + ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num) \ #define I512(R) \ do { \ @@ -263,10 +258,8 @@ do { \ #if SKEIN_UNROLL_1024 == 0 #define R1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, pF, \ ROT, rn) \ -do { \ ROUND1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, \ - pF, ROT, rn); \ -} while (0) + pF, ROT, rn) \ #define I1024(R) \ do { \ @@ -291,10 +284,8 @@ do { \ #else /* looping version */ #define R1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, pF, \ ROT, rn) \ -do { \ ROUND1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, \ - pF, ROT, rn); \ -} while (0) + pF, ROT, rn) \ #define I1024(R) \ do { \