From patchwork Mon Mar 13 18:24:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elson Serrao X-Patchwork-Id: 662971 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4E0C6FD19 for ; Mon, 13 Mar 2023 18:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbjCMSZV (ORCPT ); Mon, 13 Mar 2023 14:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbjCMSZO (ORCPT ); Mon, 13 Mar 2023 14:25:14 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD47776AA; Mon, 13 Mar 2023 11:25:07 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32DGauM3020717; Mon, 13 Mar 2023 18:25:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id; s=qcppdkim1; bh=ktqm5LsqmsOcVIt04QDk44pqyaFYpngkHFMXkO0ASUE=; b=STXKla0PQVhtQZB3v4R/Cm9eRAn9iI9pRaos7ZSyp/C4/vLlba4wTj6hCw46bIVN7sew Fpycd4n2NuCZUpC26LnQeyxhB6mEoVhkVBVwTQYn6NZkWQdR7rTQomwiXmmMVBUzQODI 8UyhYfjN0oUjoqTtx/bNHm+ylQvsolVMseIKZdlVN4gz8BgFz9QrlE+qbmAd7wK1KRPm UNVnmrQPFrIG4q07bamPIF7s5u6ARwjPEwxdLEk3wqGhcmRljvCAIVjvsbmwdeJS4Uzt tEZvcIvYIuRHYAgRb0/CkMit7hT9Viu9TrLVnyqrt35L9XYrpcBqY4oPxN2tPETcfeqW EA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pa40pgxp4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Mar 2023 18:25:02 +0000 Received: from pps.filterd (NALASPPMTA02.qualcomm.com [127.0.0.1]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 32DIP1Gf001551; Mon, 13 Mar 2023 18:25:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA02.qualcomm.com (PPS) with ESMTP id 3p8jqkm8ay-1; Mon, 13 Mar 2023 18:25:01 +0000 Received: from NALASPPMTA02.qualcomm.com (NALASPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 32DIP1Fa001530; Mon, 13 Mar 2023 18:25:01 GMT Received: from hu-devc-lv-c.qualcomm.com (hu-eserrao-lv.qualcomm.com [10.47.235.164]) by NALASPPMTA02.qualcomm.com (PPS) with ESMTP id 32DIP1qA001518; Mon, 13 Mar 2023 18:25:01 +0000 Received: by hu-devc-lv-c.qualcomm.com (Postfix, from userid 464172) id 05F4720D95; Mon, 13 Mar 2023 11:25:01 -0700 (PDT) From: Elson Roy Serrao To: gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, balbi@kernel.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, quic_wcheng@quicinc.com, quic_jackp@quicinc.com, Elson Roy Serrao Subject: [PATCH v8 0/5] Add function suspend/resume and remote wakeup support Date: Mon, 13 Mar 2023 11:24:47 -0700 Message-Id: <1678731892-20503-1-git-send-email-quic_eserrao@quicinc.com> X-Mailer: git-send-email 2.7.4 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: bCqI4mACdHrhZl0SO2ewyjcHvqLaHLQI X-Proofpoint-GUID: bCqI4mACdHrhZl0SO2ewyjcHvqLaHLQI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-13_09,2023-03-13_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=795 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303130143 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Changes in v8 - Added else case to return error value while setting remote wakeup feature selector so that device will respond with a protocl stall Changes in v7 - Added a check to set device remote wakeup feature selector in ep0.c based on whether the device is configured for remote wakeup. - Commit message and usb_func_wakeup documentation changes. Changes in v6 - Combined usb_gadget_func_wakeup API with usb_func_wakeup API in composite layer so that there is only 1 API for triggering function remote wakeup for better error handling. Since function suspend is something specific to usb functions, better to keep the related APIs in composite layer and above. Also documented the usage and applicability of the usb_func_wakeup API. Changes in v5 - Add wakeup_armed check in patch2 in the link status change event handler so that resume gets triggeed only in the remote wakeup context. - Costmetic changes in patch3 and patch4 Changes in v4 - Moved the wakeup bit check to bind function for warning the user at an early stage itself. - Added the remote wakeup configured check to gadget_wakeup() and func_wakeup() routines so that wakeup can be triggered only if user has configured it. - Cosmetic changes with respect to renaming the variables to reflect the operation better. Changes in v3 - Modified rw_capable flag to reflect the gadgets capability for wakeup signalling. - Added a check to configure wakeup bit in bmAttributes only if gadget is capable of triggering wakeup. - Implemented a gadget op for composite layer to inform UDC whether device is configured for remote wakeup. - Added a check in __usb_gadget_wakeup() API to trigger wakeup only if the device is configured for it. - Cosmetic changes in dwc3_gadget_func_wakeup() API. Changes in v2 - Added a flag to indicate whether the device is remote wakeup capable. - Added an async parameter to _dwc3_gadget_wakeup() API and few cosmetic changes. - Added flags to reflect the state of function suspend and function remote wakeup to usb_function struct rather than function specific struct (f_ecm). - Changed the dwc3_gadget_func__wakeup() API to run synchronously by first checking the link state and then sending the device notification. Also added debug log for DEVICE_NOTIFICATION generic cmd. - Added changes to arm the device for remotewakeup/function remotewakeup only if device is capable. An usb device can initate a remote wakeup and bring the link out of suspend as dictated by the DEVICE_REMOTE_WAKEUP feature selector. To achieve this an interface can invoke gadget_wakeup op and wait for the device to come out of LPM. But the current polling based implementation fails if the host takes a long time to drive the resume signaling specially in high speed capable devices. Switching to an interrupt based approach is more robust and efficient. This can be leveraged by enabling link status change events and triggering a gadget resume when the link comes to active state. If the device is enhanced super-speed capable, individual interfaces can also be put into suspend state. An interface can be in function suspend state even when the device is not in suspend state. Function suspend state is retained throughout the device suspend entry and exit process. A function can be put to function suspend through FUNCTION_SUSPEND feature selector sent by the host. This setup packet also decides whether that function is capable of initiating a function remote wakeup. When the function sends a wakeup notification to the host the link must be first brought to a non-U0 state and then this notification is sent. This change adds the infrastructure needed to support the above functionalities. Elson Roy Serrao (5): usb: gadget: Properly configure the device for remote wakeup usb: dwc3: Add remote wakeup handling usb: gadget: Add function wakeup support usb: dwc3: Add function suspend and function wakeup support usb: gadget: f_ecm: Add suspend/resume and remote wakeup support drivers/usb/dwc3/core.h | 5 ++ drivers/usb/dwc3/debug.h | 2 + drivers/usb/dwc3/ep0.c | 19 +++--- drivers/usb/dwc3/gadget.c | 118 ++++++++++++++++++++++++++++++++-- drivers/usb/gadget/composite.c | 58 +++++++++++++++++ drivers/usb/gadget/configfs.c | 3 + drivers/usb/gadget/function/f_ecm.c | 68 ++++++++++++++++++++ drivers/usb/gadget/function/u_ether.c | 63 ++++++++++++++++++ drivers/usb/gadget/function/u_ether.h | 4 ++ drivers/usb/gadget/udc/core.c | 27 ++++++++ drivers/usb/gadget/udc/trace.h | 5 ++ include/linux/usb/composite.h | 8 +++ include/linux/usb/gadget.h | 9 +++ 13 files changed, 375 insertions(+), 14 deletions(-)