| Message ID | 20200901025927.3596190-1-badhri@google.com |
|---|---|
| Headers | show |
| Series | TCPM support for FRS and AutoDischarge Disconnect | expand |
On Mon, Aug 31, 2020 at 07:59:13PM -0700, Badhri Jagan Sridharan wrote: > First of all apologies for mixing up the patch version as noted by > Heikki and Greg. All of them were v1's but since I was manually adding > the version numbers I mixed them up. Using the --reroll-count option > now. Updating the patch version to v6 (highest version number in the > previous patchset + 1) to avoid confusion. If this is v6, then where are v2 - v5? And what changed? Why didn't you just make this v2? > I also rebased on to off of the recent usb-next tip: > 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next > Which had the following changes causing merge conflict: > 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events > 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart > > Addressed comments from Heikki and Randy which have described in the > individual commit's change history as well. > > Badhri Jagan Sridharan (14): > usb: typec: tcpci: Add register definitions to tcpci > usb: typec: tcpci: Add support when hidden tx registers are > inaccessible > usb: typec: tcpci: update ROLE_CONTROL for DRP > usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference > usb: typec: tcpci: Add set_vbus tcpci callback > dt-bindings: usb: Maxim type-c controller device tree binding document > usb: typec: tcpci_maxim: Chip level TCPC driver > dt-bindings: connector: Add property to set initial current cap for > FRS > usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS) > usb: typec: tcpci: Implement callbacks for FRS > usb: typec: tcpci_maxim: Add support for Sink FRS > usb: typec: tcpm: Implement enabling Auto Discharge disconnect support > usb: typec: tcpci: Implement Auto discharge disconnect callbacks > usb: typec: tcpci_maxim: Implemnent set_auto_vbus_discharge_threshold > > .../bindings/connector/usb-connector.txt | 128 ++++ > .../devicetree/bindings/usb/maxim,tcpci.txt | 44 ++ > drivers/usb/typec/tcpm/Kconfig | 5 + > drivers/usb/typec/tcpm/Makefile | 13 +- > drivers/usb/typec/tcpm/tcpci.c | 146 ++++- > drivers/usb/typec/tcpm/tcpci.h | 43 ++ > drivers/usb/typec/tcpm/tcpci_maxim.c | 564 ++++++++++++++++++ > drivers/usb/typec/tcpm/tcpm.c | 291 ++++++++- > include/dt-bindings/usb/pd.h | 10 + > include/linux/usb/pd.h | 19 +- > include/linux/usb/tcpm.h | 24 +- > include/linux/usb/typec.h | 13 + > 12 files changed, 1266 insertions(+), 34 deletions(-) > create mode 100644 Documentation/devicetree/bindings/connector/usb-connector.txt > create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.txt > create mode 100644 drivers/usb/typec/tcpm/tcpci_maxim.c > > > base-commit: 5fedf0d295d3ef69fd85fdee4cb68fd3756b54c2 > -- > 2.28.0.402.g5ffc5be6b7-goog -- heikki
On Mon, Aug 31, 2020 at 07:59:13PM -0700, Badhri Jagan Sridharan wrote: > First of all apologies for mixing up the patch version as noted by > Heikki and Greg. All of them were v1's but since I was manually adding > the version numbers I mixed them up. Using the --reroll-count option > now. Updating the patch version to v6 (highest version number in the > previous patchset + 1) to avoid confusion. > > I also rebased on to off of the recent usb-next tip: > 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next > Which had the following changes causing merge conflict: > 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events > 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart > > Addressed comments from Heikki and Randy which have described in the > individual commit's change history as well. I'll try to study the AutoDischarge a bit before reviewing the last patches. They all appeared to be only about AutoDischarge. Sorry, I didn't have time for that yet. If Guenter is fine with those, then feel free to add my ACK to those patches. But Guenter really should review these in any case. Hope he has time. Br, -- heikki
On Tue, Sep 15, 2020 at 5:09 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Mon, Aug 31, 2020 at 07:59:13PM -0700, Badhri Jagan Sridharan wrote: > > First of all apologies for mixing up the patch version as noted by > > Heikki and Greg. All of them were v1's but since I was manually adding > > the version numbers I mixed them up. Using the --reroll-count option > > now. Updating the patch version to v6 (highest version number in the > > previous patchset + 1) to avoid confusion. > > If this is v6, then where are v2 - v5? And what changed? Why didn't > you just make this v2? Frankly, I did not know how to fix the version numbers that I messed up in the original patchset. I had, by mistake, versioned the patch5 in the series v5 in the original patchset. So I thought I will consistently call them V6 and update all the patches to version v6 to avoid confusion. To confirm there is no v2-v5 for most of them. I have also mentioned the actual code changes and versioning changes in the change history for each patch. Hopefully that mitigates the confusion. Again apologies for messing up the versioning in the original patchset ! I have started to double check the patch version numbers before sending. Thanks, Badhri > > > > I also rebased on to off of the recent usb-next tip: > > 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next > > Which had the following changes causing merge conflict: > > 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events > > 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart > > > > Addressed comments from Heikki and Randy which have described in the > > individual commit's change history as well. > > > > Badhri Jagan Sridharan (14): > > usb: typec: tcpci: Add register definitions to tcpci > > usb: typec: tcpci: Add support when hidden tx registers are > > inaccessible > > usb: typec: tcpci: update ROLE_CONTROL for DRP > > usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference > > usb: typec: tcpci: Add set_vbus tcpci callback > > dt-bindings: usb: Maxim type-c controller device tree binding document > > usb: typec: tcpci_maxim: Chip level TCPC driver > > dt-bindings: connector: Add property to set initial current cap for > > FRS > > usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS) > > usb: typec: tcpci: Implement callbacks for FRS > > usb: typec: tcpci_maxim: Add support for Sink FRS > > usb: typec: tcpm: Implement enabling Auto Discharge disconnect support > > usb: typec: tcpci: Implement Auto discharge disconnect callbacks > > usb: typec: tcpci_maxim: Implemnent set_auto_vbus_discharge_threshold > > > > .../bindings/connector/usb-connector.txt | 128 ++++ > > .../devicetree/bindings/usb/maxim,tcpci.txt | 44 ++ > > drivers/usb/typec/tcpm/Kconfig | 5 + > > drivers/usb/typec/tcpm/Makefile | 13 +- > > drivers/usb/typec/tcpm/tcpci.c | 146 ++++- > > drivers/usb/typec/tcpm/tcpci.h | 43 ++ > > drivers/usb/typec/tcpm/tcpci_maxim.c | 564 ++++++++++++++++++ > > drivers/usb/typec/tcpm/tcpm.c | 291 ++++++++- > > include/dt-bindings/usb/pd.h | 10 + > > include/linux/usb/pd.h | 19 +- > > include/linux/usb/tcpm.h | 24 +- > > include/linux/usb/typec.h | 13 + > > 12 files changed, 1266 insertions(+), 34 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/connector/usb-connector.txt > > create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.txt > > create mode 100644 drivers/usb/typec/tcpm/tcpci_maxim.c > > > > > > base-commit: 5fedf0d295d3ef69fd85fdee4cb68fd3756b54c2 > > -- > > 2.28.0.402.g5ffc5be6b7-goog > > -- > heikki
On Tue, Sep 15, 2020 at 6:33 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Mon, Aug 31, 2020 at 07:59:13PM -0700, Badhri Jagan Sridharan wrote: > > First of all apologies for mixing up the patch version as noted by > > Heikki and Greg. All of them were v1's but since I was manually adding > > the version numbers I mixed them up. Using the --reroll-count option > > now. Updating the patch version to v6 (highest version number in the > > previous patchset + 1) to avoid confusion. > > > > I also rebased on to off of the recent usb-next tip: > > 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next > > Which had the following changes causing merge conflict: > > 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events > > 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart > > > > Addressed comments from Heikki and Randy which have described in the > > individual commit's change history as well. > > I'll try to study the AutoDischarge a bit before reviewing the last > patches. They all appeared to be only about AutoDischarge. Sorry, I > didn't have time for that yet. If Guenter is fine with those, then > feel free to add my ACK to those patches. But Guenter really should > review these in any case. Hope he has time. Really appreciate you spending time on reviewing the patches. So thanks for doing that. I quickly went through the comments you have given. Will respond today. Thanks & Regards, Badhri > > Br, > > -- > heikki
On Mon, Aug 31, 2020 at 07:59:13PM -0700, Badhri Jagan Sridharan wrote: > First of all apologies for mixing up the patch version as noted by > Heikki and Greg. All of them were v1's but since I was manually adding > the version numbers I mixed them up. Using the --reroll-count option > now. Updating the patch version to v6 (highest version number in the > previous patchset + 1) to avoid confusion. > > I also rebased on to off of the recent usb-next tip: > 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next > Which had the following changes causing merge conflict: > 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events > 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart > > Addressed comments from Heikki and Randy which have described in the > individual commit's change history as well. First 3 patches now queued up, thanks. greg k-h
First of all apologies for mixing up the patch version as noted by Heikki and Greg. All of them were v1's but since I was manually adding the version numbers I mixed them up. Using the --reroll-count option now. Updating the patch version to v6 (highest version number in the previous patchset + 1) to avoid confusion. I also rebased on to off of the recent usb-next tip: 5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next Which had the following changes causing merge conflict: 3ed8e1c2ac99 usb: typec: tcpm: Migrate workqueue to RT priority for processing events 6bbe2a90a0bb usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart Addressed comments from Heikki and Randy which have described in the individual commit's change history as well. Badhri Jagan Sridharan (14): usb: typec: tcpci: Add register definitions to tcpci usb: typec: tcpci: Add support when hidden tx registers are inaccessible usb: typec: tcpci: update ROLE_CONTROL for DRP usb: typec: tcpci: Add a getter method to retrieve tcpm_port reference usb: typec: tcpci: Add set_vbus tcpci callback dt-bindings: usb: Maxim type-c controller device tree binding document usb: typec: tcpci_maxim: Chip level TCPC driver dt-bindings: connector: Add property to set initial current cap for FRS usb: typec: tcpm: Add support for Sink Fast Role SWAP(FRS) usb: typec: tcpci: Implement callbacks for FRS usb: typec: tcpci_maxim: Add support for Sink FRS usb: typec: tcpm: Implement enabling Auto Discharge disconnect support usb: typec: tcpci: Implement Auto discharge disconnect callbacks usb: typec: tcpci_maxim: Implemnent set_auto_vbus_discharge_threshold .../bindings/connector/usb-connector.txt | 128 ++++ .../devicetree/bindings/usb/maxim,tcpci.txt | 44 ++ drivers/usb/typec/tcpm/Kconfig | 5 + drivers/usb/typec/tcpm/Makefile | 13 +- drivers/usb/typec/tcpm/tcpci.c | 146 ++++- drivers/usb/typec/tcpm/tcpci.h | 43 ++ drivers/usb/typec/tcpm/tcpci_maxim.c | 564 ++++++++++++++++++ drivers/usb/typec/tcpm/tcpm.c | 291 ++++++++- include/dt-bindings/usb/pd.h | 10 + include/linux/usb/pd.h | 19 +- include/linux/usb/tcpm.h | 24 +- include/linux/usb/typec.h | 13 + 12 files changed, 1266 insertions(+), 34 deletions(-) create mode 100644 Documentation/devicetree/bindings/connector/usb-connector.txt create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.txt create mode 100644 drivers/usb/typec/tcpm/tcpci_maxim.c base-commit: 5fedf0d295d3ef69fd85fdee4cb68fd3756b54c2