| Message ID | 20210713193522.1770306-1-u.kleine-koenig@pengutronix.de |
|---|---|
| Headers | show |
| Series | bus: Make remove callback return void | expand |
On Tue, Jul 13, 2021 at 9:35 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > drivers/zorro/zorro-driver.c | 3 +-- Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert
On Tue, Jul 13, 2021 at 09:35:17PM +0200, Uwe Kleine-König wrote: > Hello, > > this is v4 of the final patch set for my effort to make struct > bus_type::remove return void. > > The first four patches contain cleanups that make some of these > callbacks (more obviously) always return 0. They are acked by the > respective maintainers. Bjorn Helgaas explicitly asked to include the > pci patch (#1) into this series, so Greg taking this is fine. I assume > the s390 people are fine with Greg taking patches #2 to #4, too, they > didn't explicitly said so though. > > The last patch actually changes the prototype and so touches quite some > drivers and has the potential to conflict with future developments, so I > consider it beneficial to put these patches into next soon. I expect > that it will be Greg who takes the complete series, he already confirmed > via irc (for v2) to look into this series. > > The only change compared to v3 is in the fourth patch where I modified a > few more drivers to fix build failures. Some of them were found by build > bots (thanks!), some of them I found myself using a regular expression > search. The newly modified files are: > > arch/sparc/kernel/vio.c > drivers/nubus/bus.c > drivers/sh/superhyway/superhyway.c > drivers/vlynq/vlynq.c > drivers/zorro/zorro-driver.c > sound/ac97/bus.c > > Best regards > Uwe Now queued up. I can go make a git tag that people can pull from after 0-day is finished testing this to verify all is good, if others need it. thanks, greg k-h