mbox series

[0/7] USB: cdc: add control and state defines

Message ID 20220725075841.1187-1-johan@kernel.org
Headers show
Series USB: cdc: add control and state defines | expand

Message

Johan Hovold July 25, 2022, 7:58 a.m. UTC 
Several drivers use the control-line and serial-state bitmap values from
the CDC spec, but there were no matching defines in the global CDC
(UAPI) header.

This series adds the missing defines and converts cdc-acm and f_acm to
use them.

One staging driver also had an unused set of CDC defines which are
removed.

The final patch by Yan Xinyu, which triggered this work, converts the
usb_wwan driver to use CDC defines instead of hardcoded values in its
line-control handling.

Greg, are you ok with me taking these through USB serial (where there
are a few more drivers that could potentially use them) or do you want
to take the lot through your tree directly?

Johan


Johan Hovold (6):
  USB: cdc: add control-signal defines
  USB: cdc: add serial-state defines
  USB: cdc-acm: use CDC control-line defines
  USB: cdc-acm: use CDC serial-state defines
  staging: gdm724x: drop unused CDC defines
  USB: gadget: f_acm: use CDC defines

Yan Xinyu (1):
  USB: serial: usb_wwan: replace DTR/RTS magic numbers with macros

 drivers/staging/gdm724x/gdm_tty.c   |  6 -----
 drivers/usb/class/cdc-acm.c         | 42 ++++++++++++++---------------
 drivers/usb/class/cdc-acm.h         | 20 --------------
 drivers/usb/gadget/function/f_acm.c | 20 ++++----------
 drivers/usb/serial/usb_wwan.c       | 10 ++++---
 include/uapi/linux/usb/cdc.h        | 13 +++++++++
 6 files changed, 45 insertions(+), 66 deletions(-)

Comments

Johan Hovold July 25, 2022, 8:54 a.m. UTC | #1 
On Mon, Jul 25, 2022 at 10:52:17AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 25, 2022 at 09:58:34AM +0200, Johan Hovold wrote:
> > Several drivers use the control-line and serial-state bitmap values from
> > the CDC spec, but there were no matching defines in the global CDC
> > (UAPI) header.
> > 
> > This series adds the missing defines and converts cdc-acm and f_acm to
> > use them.
> > 
> > One staging driver also had an unused set of CDC defines which are
> > removed.
> > 
> > The final patch by Yan Xinyu, which triggered this work, converts the
> > usb_wwan driver to use CDC defines instead of hardcoded values in its
> > line-control handling.
> > 
> > Greg, are you ok with me taking these through USB serial (where there
> > are a few more drivers that could potentially use them) or do you want
> > to take the lot through your tree directly?
> 
> Many thanks for this, I'll just take this now and you can send future
> patches for usb-serial that can rely on these being present.

Sounds good. That probably won't happen before the merge window anyway.

Thanks.

Johan
Oliver Neukum July 25, 2022, 9:18 a.m. UTC | #2 
On 25.07.22 09:58, Johan Hovold wrote:
> Use the new CDC control-line defines.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Oliver Neukum <oneukum@suse.com>