mbox series

[0/3] xhci fixes for usb-linus

Message ID 20230330143056.1390020-1-mathias.nyman@linux.intel.com
Headers show
Series xhci fixes for usb-linus | expand

Message

Mathias Nyman March 30, 2023, 2:30 p.m. UTC 
Hi Greg

A few small patches for usb-linus.
Reverting xhci-pci asynchronous probe due to Renesas host regression, and
fixing a memory leak.

Thanks
Mathias

D Scott Phillips (1):
  xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu

Mathias Nyman (2):
  Revert "usb: xhci-pci: Set PROBE_PREFER_ASYNCHRONOUS"
  xhci: Free the command allocated for setting LPM if we return early

 drivers/usb/host/xhci-pci.c | 7 +++----
 drivers/usb/host/xhci.c     | 7 ++++++-
 2 files changed, 9 insertions(+), 5 deletions(-)

Comments

Greg Kroah-Hartman March 30, 2023, 2:40 p.m. UTC | #1 
On Thu, Mar 30, 2023 at 05:30:54PM +0300, Mathias Nyman wrote:
> From: D Scott Phillips <scott@os.amperecomputing.com>
> 
> Previously the quirk was skipped when no iommu was present. The same
> rationale for skipping the quirk also applies in the iommu.passthrough=1
> case.
> 
> Skip applying the XHCI_ZERO_64B_REGS quirk if the device's iommu domain is
> passthrough.
> 
> Fixes: 12de0a35c996 ("xhci: Add quirk to zero 64bit registers on Renesas PCIe controllers")

Why not also for stable?

thanks,

greg k-h
Mathias Nyman March 31, 2023, 7:35 a.m. UTC | #2 
On 30.3.2023 17.40, Greg KH wrote:
> On Thu, Mar 30, 2023 at 05:30:54PM +0300, Mathias Nyman wrote:
>> From: D Scott Phillips <scott@os.amperecomputing.com>
>>
>> Previously the quirk was skipped when no iommu was present. The same
>> rationale for skipping the quirk also applies in the iommu.passthrough=1
>> case.
>>
>> Skip applying the XHCI_ZERO_64B_REGS quirk if the device's iommu domain is
>> passthrough.
>>
>> Fixes: 12de0a35c996 ("xhci: Add quirk to zero 64bit registers on Renesas PCIe controllers")
> 
> Why not also for stable?

Ah, yes, this should go to stable as well.

Thanks
Mathias
Greg Kroah-Hartman March 31, 2023, 7:40 a.m. UTC | #3 
On Fri, Mar 31, 2023 at 10:35:07AM +0300, Mathias Nyman wrote:
> On 30.3.2023 17.40, Greg KH wrote:
> > On Thu, Mar 30, 2023 at 05:30:54PM +0300, Mathias Nyman wrote:
> > > From: D Scott Phillips <scott@os.amperecomputing.com>
> > > 
> > > Previously the quirk was skipped when no iommu was present. The same
> > > rationale for skipping the quirk also applies in the iommu.passthrough=1
> > > case.
> > > 
> > > Skip applying the XHCI_ZERO_64B_REGS quirk if the device's iommu domain is
> > > passthrough.
> > > 
> > > Fixes: 12de0a35c996 ("xhci: Add quirk to zero 64bit registers on Renesas PCIe controllers")
> > 
> > Why not also for stable?
> 
> Ah, yes, this should go to stable as well.

Thanks for confirming these, as you noticed, all are applied to my tree
now.

greg k-h