| Message ID | 20231201183113.343256-1-dianders@chromium.org |
|---|---|
| Headers | show |
| Series | net: usb: r8152: Fix lost config across deauthorize+authorize | expand |
On Fri, 1 Dec 2023 10:29:49 -0800 Douglas Anderson wrote: > Since these three patches straddle the USB subsystem and the > networking subsystem then maintainers will (obviously) need to work > out a way for them to land. I don't have any strong suggestions here > so I'm happy to let the maintainers propose what they think will work > best. No strong preference here, on a quick read it seems more like a USB change than networking change, tho, so I'll defer to Greg unless told otherwise.
On Mon, Dec 04, 2023 at 06:27:27PM -0800, Jakub Kicinski wrote: > On Fri, 1 Dec 2023 10:29:49 -0800 Douglas Anderson wrote: > > Since these three patches straddle the USB subsystem and the > > networking subsystem then maintainers will (obviously) need to work > > out a way for them to land. I don't have any strong suggestions here > > so I'm happy to let the maintainers propose what they think will work > > best. > > No strong preference here, on a quick read it seems more like a USB > change than networking change, tho, so I'll defer to Greg unless told > otherwise. I took these in my tree already, sorry for not saying anything here. thanks, greg k-h
This series fixes problems introduced by commit ec51fbd1b8a2 ("r8152: add USB device driver for config selection") where the r8152 device would stop functioning if you deauthorized it (by writing 0 to the "authorized" field in sysfs) and then reauthorized it (by writing a 1). In v1 this was just a single patch [1], but it's now a 3-patch series and solves the problem in a much cleaner way, as suggested by Alan Stern. Since these three patches straddle the USB subsystem and the networking subsystem then maintainers will (obviously) need to work out a way for them to land. I don't have any strong suggestions here so I'm happy to let the maintainers propose what they think will work best. [1] https://lore.kernel.org/r/20231130154337.1.Ie00e07f07f87149c9ce0b27ae4e26991d307e14b@changeid Changes in v2: - ("Don't force USB generic_subclass drivers to define ...") new for v2. - ("Allow subclassed USB drivers to override ...") new for v2. - ("Choose our USB config with choose_configuration()...) new for v2. Douglas Anderson (3): usb: core: Don't force USB generic_subclass drivers to define probe() usb: core: Allow subclassed USB drivers to override usb_choose_configuration() r8152: Choose our USB config with choose_configuration() rather than probe() drivers/net/usb/r8152.c | 16 +++++----------- drivers/usb/core/driver.c | 5 ++++- drivers/usb/core/generic.c | 7 +++++++ include/linux/usb.h | 6 ++++++ 4 files changed, 22 insertions(+), 12 deletions(-)