From patchwork Wed Dec 27 09:19:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Kurapati X-Patchwork-Id: 758582 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A81DF24B3C; Wed, 27 Dec 2023 09:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="LLf524rZ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BR58nNn005175; Wed, 27 Dec 2023 09:20:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=qcppdkim1; bh=D09pakx kZpoqnCMSsypMnglMTzE0YMh/zDhiL5mB7yU=; b=LLf524rZwGEJddjSWodgg7E bFS9dNgRSDs0nrtgJyYCPA9qnKo0aJPulbu6p5rt7/BQaOLVXU67dTGasYahB3EO 0PiOsL3U59SeK9rQBttvpIZb4ktafxdctZppXgP7ZcuznsTWyDMlfUYWZR3GHIBR LThknJngxXZjsG988+rFP+41xEHm2WKA7GnLgav3nvTBfcaPpyM3LCH/09wFZqDz WAnhe6Dbl7vG3yh5K1ekGh5KzfnhI2Y6niSV44yz8+cLDsCAJWbk9MiRqm0nwqy0 SXOyxfWafRT37kJi7ncsjib08i3XmBf6Z24ZAYDUe0a1ogsqjeu1ezIjZdFv1rg= = Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3v7s8uasav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Dec 2023 09:20:09 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BR9K9co023039 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Dec 2023 09:20:09 GMT Received: from hu-kriskura-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 27 Dec 2023 01:20:03 -0800 From: Krishna Kurapati To: Greg Kroah-Hartman , Krzysztof Kozlowski , Rob Herring , "Andy Gross" , Bjorn Andersson , "Thinh Nguyen" , Konrad Dybcio , Wesley Cheng , Conor Dooley , Johan Hovold CC: , , , , , , Krishna Kurapati Subject: [PATCH v6 0/2] Refine USB interrupt vectors on Qualcomm platforms Date: Wed, 27 Dec 2023 14:49:49 +0530 Message-ID: <20231227091951.685-1-quic_kriskura@quicinc.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: mdgU9MN1Rh3ag35lvyRV0M_rNhqZF2aS X-Proofpoint-ORIG-GUID: mdgU9MN1Rh3ag35lvyRV0M_rNhqZF2aS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 mlxlogscore=793 impostorscore=0 adultscore=0 clxscore=1015 mlxscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312270068 Qualcomm targets define the following interrupts for usb wakeup: {dp/dm}_hs_phy_irq, hs_phy_irq, pwr_event, ss_phy_irq. But QUSB2 Phy based targets have another interrupt which gets triggered in response to J/K states on dp/dm pads. Its functionality is replaced by dp/dm interrupts on Femto/m31/eusb2 phy based targets for wakeup purposes. Exceptions are some targets like SDM845/SDM670/SM6350 where dp/dm irq's are used although they are qusb2 phy targets. Currently in QUSB2 Phy based DT's, te qusb2_phy interrupt is named and used as "hs_phy_irq" when in fact it is a different interrupt (used by HW validation folks for debug purposes and not used on any downstream target qusb/non-qusb). On some non-QUSB2 targets (like sm8450/sm8550), the pwr_event IRQ was named as hs_phy_irq and actual pwr_event_irq was skipped. This series tries to address the discrepancies in the interrupt numbering adding the missing interrupts and correcting the existing ones. This series has been compared with downstream counter part and hw specifics to ensure the numbering is right. Since there is not functionality change the code has been only compile tested. Changes in v6: Removed QCM2290/SM6375 from v5 as these are additional targets added to schema without informing in commit text in v5. Will add it back later. For now only the targets present in original schema for usb interrupts where re-ordered. Removed min items for ipq5332/x1e80100 targets as they definitely have 4 irq's. Moved SC8280XP to cluster where 5 irq's are present (dp/dp/hs/ss/pwr_event). Also, moved qusb_phy before hs_phy in cluster-2 in v6. Changes in v5: Fixed commit header on v4-1 bindings patch. Provide lore link instead of patchwork link for v3. Changes in v4: Udpated commit text indicating why pwr_event interrupt was added as the first one and fixed some typos present in v3. While at it, rebase on top of latest linux-next fixing merge conflicts. Changes in v3: Separated out the DT changes and pushed only bindings and driver update. Modified order of irq descriptions to match them with permutations defined. Fixed nitpicks mentioned by reviewers in v2. Changes in v2: Removed additional compatibles added for different targets in v1. Specified permuations of interrupts possible for QC targets and regrouped interrupts for most of the DT's. Link to v5: https://lore.kernel.org/all/20231222063648.11193-1-quic_kriskura@quicinc.com/ Link to v4: https://lore.kernel.org/all/20231222062720.10128-1-quic_kriskura@quicinc.com/ Link to v3: https://lore.kernel.org/all/20231211121124.4194-1-quic_kriskura@quicinc.com/ Link to v2: https://lore.kernel.org/all/20231204100950.28712-1-quic_kriskura@quicinc.com/ Link to v1: (providing patchwork link since threading was broken in v1) https://patchwork.kernel.org/project/linux-arm-msm/cover/20231122191259.3021-1-quic_kriskura@quicinc.com/ Krishna Kurapati (2): dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding usb: dwc3: qcom: Rename hs_phy_irq to qusb2_phy_irq .../devicetree/bindings/usb/qcom,dwc3.yaml | 141 ++++++++---------- drivers/usb/dwc3/dwc3-qcom.c | 22 +-- 2 files changed, 72 insertions(+), 91 deletions(-)