mbox series

[v1,0/2] external ulpi vbus control

Message ID 20240531-citable-copier-188d32c108ff@wendy
Headers show
Series external ulpi vbus control | expand

Message

Conor Dooley May 31, 2024, 7:04 a.m. UTC 
A customer sent me a patch adding a dt property to enable external vbus
control as their phy didn't support it*. I was surprised to see that none
of the other musb drivers made any use of this, but there is handling
in the musb core for it - made me feel like I was missing something as
to why it was not used by other drivers.

I've vendor prefixed the property for now, but I figure there may well
be a bunch of other potential users since this isn't just an musb thing,
given that there's a snps,ulpi-ext-vbus-drv used by an xHCI IP.

This is my third attempt to send these patches. I cannot find them on
lore from either of my previous attempts, so I'm gonna treat this as
v1. I think must've tried to send it from my kernel.org account from
Microchip's corp network and that failed. Either way, apologies if this
is #3 you've got from me..

* they didn't want to be identified, but said it was okay to post.

CC: Conor Dooley <conor.dooley@microchip.com>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC: Bin Liu <b-liu@ti.com>
CC: linux-riscv@lists.infradead.org
CC: linux-usb@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Conor Dooley (2):
  dt-bindings: musb: mpfs: add ULPI external vbus support
  usb: musb: mpfs: detect UPLI external vbus control requirement from DT

 .../devicetree/bindings/usb/microchip,mpfs-musb.yaml       | 7 +++++++
 drivers/usb/musb/mpfs.c                                    | 2 ++
 2 files changed, 9 insertions(+)

Comments

Krzysztof Kozlowski June 1, 2024, 3:52 p.m. UTC | #1 
On 31/05/2024 09:04, Conor Dooley wrote:
> Add a property to allow configuring the musb controller on PolarFire SoC
> to use an external vbus for ULPI PHYs.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof