mbox series

[v2,0/5] hid-pidff fixes and PID compliance improvement

Message ID 20250225223004.415965-1-tomasz.pakula.oficjalny@gmail.com
Headers show
Series hid-pidff fixes and PID compliance improvement | expand

Message

Tomasz Pakuła Feb. 25, 2025, 10:29 p.m. UTC 
Based on top of current hid.git#for-6.15/pidff

Another batch of updated to the generic USB PID driver. Apart from
realigning two function names with the rest of the driver, clamping
LOOP_COUNT value to the logical max to fix some errors.

Infinite values were previously hardcoded to 0xffff but the standard
actually calls for the max possible value for the presented field size.
If the duration is not 16 bit, but 32 bit 0xffff won't work as infinite.

Setting infinite value works now by computing this value from report
size. We still need to look out for 0xffff as that's the max possible
value we can get from the ff API. 0 was never actually defined in the
Linux kernel as explicitly INFINITE but it seems like it has become a
de-facto standard.

After pidff, I'll (at least try) working on extending and updating
the ff API as it lacks some features and could be considered incomplete.
The biggest issue is that there's currently no way of obtaining effect
status or sending device control commands.

---
Changes in v2:
- Fix the direction name in the fixed direction comment
- Fix set_device_control() and implelemt missing device control commands

Tomasz Pakuła (5):
  HID: pidff: Rename two functions to align them with naming convention
  HID: pidff: Clamp effect playback LOOP_COUNT value
  HID: pidff: Compute INFINITE value instead of using hardcoded 0xffff
  HID: pidff: Fix 90 degrees direction name North -> East
  HID: pidff: Fix set_device_control()

 drivers/hid/usbhid/hid-pidff.c | 42 ++++++++++++++++++++++------------
 1 file changed, 27 insertions(+), 15 deletions(-)


base-commit: b9c340b67b33cd37e543195b157c73a7bb0c8d4a