| Message ID | 20250409082752.3697532-1-tmyu0@nuvoton.com |
|---|---|
| Headers | show |
| Series | Add Nuvoton NCT6694 MFD drivers | expand |
On 09/04/2025 10:27, a0282524688@gmail.com wrote: > + > +static int nct6694_response_err_handling(struct nct6694 *nct6694, > + unsigned char err_status) > +{ > + switch (err_status) { > + case NCT6694_NO_ERROR: > + return 0; > + case NCT6694_NOT_SUPPORT_ERROR: > + dev_err(nct6694->dev, "Command is not supported!\n"); > + break; > + case NCT6694_NO_RESPONSE_ERROR: > + dev_warn(nct6694->dev, "Command received no response!\n"); > + break; > + case NCT6694_TIMEOUT_ERROR: > + dev_warn(nct6694->dev, "Command timed out!\n"); > + break; > + case NCT6694_PENDING: > + dev_err(nct6694->dev, "Command is pending!\n"); > + break; > + default: > + return -EINVAL; > + } > + > + return -EIO; > +} > + Missing Kconfig. Exported functions are supposed to have it. > +int nct6694_read_msg(struct nct6694 *nct6694, const struct nct6694_cmd_header *cmd_hd, void *buf) > +{ > + union nct6694_usb_msg *msg = nct6694->usb_msg; > + struct usb_device *udev = nct6694->udev; > + int tx_len, rx_len, ret; > + > + guard(mutex)(&nct6694->access_lock); > + > + memcpy(&msg->cmd_header, cmd_hd, sizeof(*cmd_hd)); > + msg->cmd_header.hctrl = NCT6694_HCTRL_GET; > + > + /* Send command packet to USB device */ > + ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, NCT6694_BULK_OUT_EP), &msg->cmd_header, > + sizeof(*msg), &tx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + /* Receive response packet from USB device */ > + ret = usb_bulk_msg(udev, usb_rcvbulkpipe(udev, NCT6694_BULK_IN_EP), &msg->response_header, > + sizeof(*msg), &rx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + /* Receive data packet from USB device */ > + ret = usb_bulk_msg(udev, usb_rcvbulkpipe(udev, NCT6694_BULK_IN_EP), buf, > + le16_to_cpu(cmd_hd->len), &rx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + if (rx_len != le16_to_cpu(cmd_hd->len)) { > + dev_err(nct6694->dev, "Expected received length %d, but got %d\n", > + le16_to_cpu(cmd_hd->len), rx_len); > + return -EIO; > + } > + > + return nct6694_response_err_handling(nct6694, msg->response_header.sts); > +} > +EXPORT_SYMBOL(nct6694_read_msg); GPL > + > +int nct6694_write_msg(struct nct6694 *nct6694, const struct nct6694_cmd_header *cmd_hd, void *buf) > +{ > + union nct6694_usb_msg *msg = nct6694->usb_msg; > + struct usb_device *udev = nct6694->udev; > + int tx_len, rx_len, ret; > + > + guard(mutex)(&nct6694->access_lock); > + > + memcpy(&msg->cmd_header, cmd_hd, sizeof(*cmd_hd)); > + msg->cmd_header.hctrl = NCT6694_HCTRL_SET; > + > + /* Send command packet to USB device */ > + ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, NCT6694_BULK_OUT_EP), &msg->cmd_header, > + sizeof(*msg), &tx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + /* Send data packet to USB device */ > + ret = usb_bulk_msg(udev, usb_sndbulkpipe(udev, NCT6694_BULK_OUT_EP), buf, > + le16_to_cpu(cmd_hd->len), &tx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + /* Receive response packet from USB device */ > + ret = usb_bulk_msg(udev, usb_rcvbulkpipe(udev, NCT6694_BULK_IN_EP), &msg->response_header, > + sizeof(*msg), &rx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + /* Receive data packet from USB device */ > + ret = usb_bulk_msg(udev, usb_rcvbulkpipe(udev, NCT6694_BULK_IN_EP), buf, > + le16_to_cpu(cmd_hd->len), &rx_len, NCT6694_URB_TIMEOUT); > + if (ret) > + return ret; > + > + if (rx_len != le16_to_cpu(cmd_hd->len)) { > + dev_err(nct6694->dev, "Expected transmitted length %d, but got %d\n", > + le16_to_cpu(cmd_hd->len), rx_len); > + return -EIO; > + } > + > + return nct6694_response_err_handling(nct6694, msg->response_header.sts); > +} > +EXPORT_SYMBOL(nct6694_write_msg); > + Same comments. Best regards, Krzysztof
On Thu, 10 Apr 2025, Krzysztof Kozlowski wrote: > On 09/04/2025 10:27, a0282524688@gmail.com wrote: > > + > > +static int nct6694_response_err_handling(struct nct6694 *nct6694, > > + unsigned char err_status) > > +{ > > + switch (err_status) { > > + case NCT6694_NO_ERROR: > > + return 0; > > + case NCT6694_NOT_SUPPORT_ERROR: > > + dev_err(nct6694->dev, "Command is not supported!\n"); > > + break; > > + case NCT6694_NO_RESPONSE_ERROR: > > + dev_warn(nct6694->dev, "Command received no response!\n"); > > + break; > > + case NCT6694_TIMEOUT_ERROR: > > + dev_warn(nct6694->dev, "Command timed out!\n"); > > + break; > > + case NCT6694_PENDING: > > + dev_err(nct6694->dev, "Command is pending!\n"); > > + break; > > + default: > > + return -EINVAL; > > + } > > + > > + return -EIO; > > +} > > + > > Missing Kconfig. Exported functions are supposed to have it. ------- KernelDoc
On 10/04/2025 09:52, Lee Jones wrote: > On Thu, 10 Apr 2025, Krzysztof Kozlowski wrote: > >> On 09/04/2025 10:27, a0282524688@gmail.com wrote: >>> + >>> +static int nct6694_response_err_handling(struct nct6694 *nct6694, >>> + unsigned char err_status) >>> +{ >>> + switch (err_status) { >>> + case NCT6694_NO_ERROR: >>> + return 0; >>> + case NCT6694_NOT_SUPPORT_ERROR: >>> + dev_err(nct6694->dev, "Command is not supported!\n"); >>> + break; >>> + case NCT6694_NO_RESPONSE_ERROR: >>> + dev_warn(nct6694->dev, "Command received no response!\n"); >>> + break; >>> + case NCT6694_TIMEOUT_ERROR: >>> + dev_warn(nct6694->dev, "Command timed out!\n"); >>> + break; >>> + case NCT6694_PENDING: >>> + dev_err(nct6694->dev, "Command is pending!\n"); >>> + break; >>> + default: >>> + return -EINVAL; >>> + } >>> + >>> + return -EIO; >>> +} >>> + >> >> Missing Kconfig. Exported functions are supposed to have it. > ------- > > KernelDoc Yes, thank you. -ENOCOFFEE Best regards, Krzysztof
On 09/04/2025 10:27, a0282524688@gmail.com wrote: > + data->irq = irq; > + data->nct6694 = nct6694; > + data->rtc->ops = &nct6694_rtc_ops; > + data->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; > + data->rtc->range_max = RTC_TIMESTAMP_END_2099; > + > + platform_set_drvdata(pdev, data); > + > + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > + nct6694_irq, IRQF_ONESHOT, > + "rtc-nct6694", data); > + if (ret < 0) { > + dev_err_probe(&pdev->dev, ret, "Failed to request irq\n"); > + goto dispose_irq; > + } > + > + ret = devm_rtc_register_device(data->rtc); > + if (ret) > + goto dispose_irq; > + > + device_init_wakeup(&pdev->dev, true); devm_device_init_wakeup Let's save us from one more patch... As pointed out in other patch by Bartosz, you have messed cleanups. Use only devm, because currently your cleanup looks like this: 1. dispose mapping 2. free IRQ and this should be reversed. Best regards, Krzysztof
From: Ming Yu <tmyu0@nuvoton.com> This patch series introduces support for Nuvoton NCT6694, a peripheral expander based on USB interface. It models the chip as an MFD driver (1/7), GPIO driver(2/7), I2C Adapter driver(3/7), CANfd driver(4/7), WDT driver(5/7), HWMON driver(6/7), and RTC driver(7/7). The MFD driver implements USB device functionality to issue custom-define USB bulk pipe packets for NCT6694. Each child device can use the USB functions nct6694_read_msg() and nct6694_write_msg() to issue a command. They can also request interrupt that will be called when the USB device receives its interrupt pipe. The following introduces the custom-define USB transactions: nct6694_read_msg - Send bulk-out pipe to write request packet Receive bulk-in pipe to read response packet Receive bulk-in pipe to read data packet nct6694_write_msg - Send bulk-out pipe to write request packet Send bulk-out pipe to write data packet Receive bulk-in pipe to read response packet Receive bulk-in pipe to read data packet Changes since version 8: - Modify the signed-off-by with my work address - Rename all MFD cell names to "nct6694-xxx" - Add irq_dispose_mapping() in the error handling path and in the remove function - Fix some comments in nct6694.c and in nct6694.h - Add module parameters to configure I2C's baudrate in i2c-nct6694.c - Rename all function names nct6694_can_xxx to nct6694_canfd_xxx in nct6694_canfd.c - Fix nct6694_canfd_handle_state_change() in nct6694_canfd.c - Fix nct6694_canfd_start() to configure NBTP and DBTP in nct6694_canfd.c - Add can_set_static_ctrlmode() in nct6694_canfd.c Changes since version 7: - Add error handling for devm_mutex_init() - Modify the name of the child devices CAN1 and CAN2 to CAN0 and CAN1. - Fix multiline comments to net-dev style in nct6694_canfd.c Changes since version 6: - Fix nct6694_can_handle_state_change() in nct6694_canfd.c - Fix warnings in nct6694_canfd.c - Move the nct6694_can_priv's bec to the end in nct6694_canfd.c - Fix warning in nct6694_wdt.c - Fix temp_hyst's data type to signed variable in nct6694-hwmon.c Changes since version 5: - Modify the module name and the driver name consistently - Fix mfd_cell to MFD_CELL_NAME() and MFD_CELL_BASIC() - Drop unnecessary macros in nct6694.c - Update private data and drop mutex in nct6694_canfd.c - Fix nct6694_can_handle_state_change() in nct6694_canfd.c Changes since version 4: - Modify arguments in read/write function to a pointer to cmd_header - Modify all callers that call the read/write function - Move the nct6694_canfd.c to drivers/net/can/usb/ - Fix the missing rx offload function in nct6694_canfd.c - Fix warngings in nct6694-hwmon.c Changes since version 3: - Modify array buffer to structure for each drivers - Fix defines and comments for each drivers - Add header <linux/bits.h> and use BIT macro in nct6694.c and gpio-nct6694.c - Modify mutex_init() to devm_mutex_init() - Add rx-offload helper in nct6694_canfd.c - Drop watchdog_init_timeout() in nct6694_wdt.c - Modify the division method to DIV_ROUND_CLOSEST() in nct6694-hwmon.c - Drop private mutex and use rtc core lock in rtc-nct6694.c - Modify device_set_wakeup_capable() to device_init_wakeup() in rtc-nct6694.c Changes since version 2: - Add MODULE_ALIAS() for each child driver - Modify gpio line names be a local variable in gpio-nct6694.c - Drop unnecessary platform_get_drvdata() in gpio-nct6694.c - Rename each command in nct6694_canfd.c - Modify each function name consistently in nct6694_canfd.c - Modify the pretimeout validation procedure in nct6694_wdt.c - Fix warnings in nct6694-hwmon.c Changes since version 1: - Implement IRQ domain to handle IRQ demux in nct6694.c - Modify USB_DEVICE to USB_DEVICE_AND_INTERFACE_INFO API in nct6694.c - Add each driver's command structure - Fix USB functions in nct6694.c - Fix platform driver registration in each child driver - Sort each driver's header files alphabetically - Drop unnecessary header in gpio-nct6694.c - Add gpio line names in gpio-nct6694.c - Fix errors and warnings in nct6694_canfd.c - Fix TX-flow control in nct6694_canfd.c - Fix warnings in nct6694_wdt.c - Drop unnecessary logs in nct6694_wdt.c - Modify start() function to setup device in nct6694_wdt.c - Add voltage sensors functionality in nct6694-hwmon.c - Add temperature sensors functionality in nct6694-hwmon.c - Fix overwrite error return values in nct6694-hwmon.c - Add write value limitation for each write() function in nct6694-hwmon.c - Drop unnecessary logs in rtc-nct6694.c - Fix overwrite error return values in rtc-nct6694.c - Modify to use dev_err_probe API in rtc-nct6694.c Ming Yu (7): mfd: Add core driver for Nuvoton NCT6694 gpio: Add Nuvoton NCT6694 GPIO support i2c: Add Nuvoton NCT6694 I2C support can: Add Nuvoton NCT6694 CANFD support watchdog: Add Nuvoton NCT6694 WDT support hwmon: Add Nuvoton NCT6694 HWMON support rtc: Add Nuvoton NCT6694 RTC support MAINTAINERS | 12 + drivers/gpio/Kconfig | 12 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-nct6694.c | 494 +++++++++++++++ drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/nct6694-hwmon.c | 949 ++++++++++++++++++++++++++++ drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-nct6694.c | 184 ++++++ drivers/mfd/Kconfig | 15 + drivers/mfd/Makefile | 2 + drivers/mfd/nct6694.c | 367 +++++++++++ drivers/net/can/usb/Kconfig | 11 + drivers/net/can/usb/Makefile | 1 + drivers/net/can/usb/nct6694_canfd.c | 815 ++++++++++++++++++++++++ drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-nct6694.c | 309 +++++++++ drivers/watchdog/Kconfig | 11 + drivers/watchdog/Makefile | 1 + drivers/watchdog/nct6694_wdt.c | 298 +++++++++ include/linux/mfd/nct6694.h | 101 +++ 23 files changed, 3616 insertions(+) create mode 100644 drivers/gpio/gpio-nct6694.c create mode 100644 drivers/hwmon/nct6694-hwmon.c create mode 100644 drivers/i2c/busses/i2c-nct6694.c create mode 100644 drivers/mfd/nct6694.c create mode 100644 drivers/net/can/usb/nct6694_canfd.c create mode 100644 drivers/rtc/rtc-nct6694.c create mode 100644 drivers/watchdog/nct6694_wdt.c create mode 100644 include/linux/mfd/nct6694.h