From patchwork Wed May 21 20:46:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 891647 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87CA4233156; Wed, 21 May 2025 20:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747860383; cv=none; b=V4Qn1oqDLrO03jJYQg1v8gcU50i0gkFmje1r92NiVIa++CidQiXKzW15hz8aGVrM+0uNjeLhVg0eX0vPmcVUdoQuCLpol0HsYJRjPs+j6ciCRJLA0eP5N2EQaCBVJfpQA5ntuVctM9m35r2SMY6UJCW9QY1kv2Pp1BuZGOMoVpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747860383; c=relaxed/simple; bh=TB5RrtCE3tLkkWSSZvlSdGdEuB83W94mJusyAgZ8cTE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=AHrxqXsKYCQOc2NSsYaWeiWFYFoWSZaF6hX0Wbr2toFpzE33rpo99nc/ezDZgspFdnuW7jX5YoZTIhQ0yUcft6yERPT7HM8BT4ruw4NwGIkdQDhTBNWsgnzRC6R4biMde+zbRlBm26EDUPV4WMNuprISR3x8dIJZ+62qQ5lgooo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=azKxmU9y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="azKxmU9y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17535C4CEE4; Wed, 21 May 2025 20:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747860383; bh=TB5RrtCE3tLkkWSSZvlSdGdEuB83W94mJusyAgZ8cTE=; h=From:To:Cc:Subject:Date:From; b=azKxmU9yy7Izy99ARGU0CwcQd4sF4KPMD1aOQ//cIUDTuPCHSVJo6VQexSwPahcCY RaB+/ec6twf4muJqtblNNKS/GpDDD2XG3WtK/YVf5pHdY030dyLCSc8h4ij0bAqyxG XhMzcNbqL8jIseK0RS+FeGkfPecDLFgtEPxMgAOfvEscrYZNh+S4Apfj3U9piEHogG y9AGdGlc3O0MHidOMqYgAwp7Okoo3zWYOYIkWqEJ9lP3XE3rJP/2gpLAJ+KJG3hZi0 kPJez90sL/EYEcH5kWO6CvWwcrgZuWC6+OgAByhtJvtb+9BzJ98rYQ164KEaiHbnwN Wk4GR0fftc4bQ== From: Kees Cook To: Kuniyuki Iwashima Cc: Kees Cook , Willem de Bruijn , "Martin K. Petersen" , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mike Christie , Max Gurtovoy , Maurizio Lombardi , Dmitry Bogdanov , Mingzhe Zou , Christophe Leroy , Simon Horman , "Dr. David Alan Gilbert" , "Gustavo A. R. Silva" , Andrew Lunn , Stanislav Fomichev , Cosmin Ratiu , Lei Yang , Ido Schimmel , Samuel Mendoza-Jonas , Paul Fertser , Alexander Aring , Stefan Schmidt , Miquel Raynal , Hayes Wang , Douglas Anderson , Grant Grundler , Jay Vosburgh , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jiri Pirko , Jason Wang , Vladimir Oltean , Florian Fainelli , Kory Maincent , Maxim Georgiev , Aleksander Jan Bajkowski , Philipp Hahn , Eric Biggers , Ard Biesheuvel , Al Viro , Ahmed Zaki , Alexander Lobakin , Xiao Liang , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-usb@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH net-next v2 0/8] net: Convert dev_set_mac_address() to struct sockaddr_storage Date: Wed, 21 May 2025 13:46:08 -0700 Message-Id: <20250521204310.it.500-kees@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2500; i=kees@kernel.org; h=from:subject:message-id; bh=TB5RrtCE3tLkkWSSZvlSdGdEuB83W94mJusyAgZ8cTE=; b=owGbwMvMwCVmps19z/KJym7G02pJDBl61lMn8Rlk/WQ5tG/fnM3cc3mE/hqzZ3+yr2D0L1GRf iekt16jo5SFQYyLQVZMkSXIzj3OxeNte7j7XEWYOaxMIEMYuDgFYCIe3Az//f2rG3P6DZ5UOD7/ tuvKqRbdCQfV0q4oJrdt32d7xpNJhZFhldYdQ86QnhUK32dnBp/7eZFtyvJNKkZbN6/8239RZs9 5TgA= X-Developer-Key: i=kees@kernel.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 v2: - add conversion of dev_set_mac_address_user() (kuniyu) - fix missed sockaddr/sockaddr_storage conversion (kuba) v1: https://lore.kernel.org/all/20250520222452.work.063-kees@kernel.org/ Hi, As part of the effort to allow the compiler to reason about object sizes, we need to deal with the problematic variably sized struct sockaddr, which has no internal runtime size tracking. In much of the network stack the use of struct sockaddr_storage has been adopted. Continue the transition toward this for more of the internal APIs. Specifically: - inet_addr_is_any() - netif_set_mac_address() - dev_set_mac_address() - dev_set_mac_address_user() Only a few callers of dev_set_mac_address() needed adjustment; all others were already using struct sockaddr_storage internally. -Kees Kees Cook (8): net: core: Convert inet_addr_is_any() to sockaddr_storage net: core: Switch netif_set_mac_address() to struct sockaddr_storage net/ncsi: Use struct sockaddr_storage for pending_mac ieee802154: Use struct sockaddr_storage with dev_set_mac_address() net: usb: r8152: Convert to use struct sockaddr_storage internally net: core: Convert dev_set_mac_address() to struct sockaddr_storage rtnetlink: do_setlink: Use struct sockaddr_storage net: core: Convert dev_set_mac_address_user() to use struct sockaddr_storage include/linux/inet.h | 2 +- include/linux/netdevice.h | 6 ++-- net/ncsi/internal.h | 2 +- drivers/net/bonding/bond_alb.c | 8 ++--- drivers/net/bonding/bond_main.c | 15 ++++----- drivers/net/hyperv/netvsc_drv.c | 6 ++-- drivers/net/macvlan.c | 18 +++++----- drivers/net/tap.c | 14 +++++--- drivers/net/team/team_core.c | 2 +- drivers/net/tun.c | 8 ++++- drivers/net/usb/r8152.c | 52 +++++++++++++++-------------- drivers/nvme/target/rdma.c | 2 +- drivers/nvme/target/tcp.c | 2 +- drivers/target/iscsi/iscsi_target.c | 2 +- net/core/dev.c | 11 +++--- net/core/dev_api.c | 11 +++--- net/core/dev_ioctl.c | 6 ++-- net/core/rtnetlink.c | 19 +++-------- net/core/utils.c | 8 ++--- net/ieee802154/nl-phy.c | 6 ++-- net/ncsi/ncsi-rsp.c | 18 +++++----- 21 files changed, 109 insertions(+), 109 deletions(-) Acked-by: Gustavo A. R. Silva