From patchwork Sat Jun 14 12:56:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yang X-Patchwork-Id: 897966 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012053.outbound.protection.outlook.com [52.101.66.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33C1F1DFE8 for ; Sat, 14 Jun 2025 12:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749905674; cv=fail; b=Zlj74BN6i1b0fNGLxKnftKuvEg2jcON1SkPFUD0rGSbgkunUZEH6XgUdgbTm0mox8AeSso0+FhpIk6N+vDDUIhY7pbH41urdyHWy6D8tz61PVipS/K7a5zqd83risnfmxi/nRfQGOel9p4+KHYX7VYX92B9Y6KCIdX3jejRo2h8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749905674; c=relaxed/simple; bh=QwaqP0DX+uRgVl9EnuVaTiPvcbYggzT50gwNkDihQD0=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=S1UI7/Gad0DaS5IrFFrEOyC0qztPbmtzCjuipMQULPRWQU30R5zEk5ih3EB4G+xzn+zSCh7isZgU4z4aNm3+DhNnXLg+PRMdR/9H5r6ZCGhpCC7jv+fRkDw4iwnpUuoXWOs5KxYS88NcO0+RO5gcswTK+gDwSiQmcl9+oKtYOAw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=mhYVUfHC; arc=fail smtp.client-ip=52.101.66.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="mhYVUfHC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XzrCQw8oLVu9PgEvG+GDC6YapYYvBWxx+LkBy+kUriqFYnoPc1oOFHZ7IblDfuOswJrXYSERJOxaAExaw8EeEkZ41KZz6c5w5HZV6UNR4h5IDatMNvaXhtCyMEOSxB2v+I15CtVj52kVJv5gYL7H90BaaHoSSURL44dNOAKjycmjoB9Cpp5TaZ/yP0yJzSDQLwP79umCpfWBSEuDoScOAZEOY4jZ+uX+gySzmX0WlGZwItoQRaoCO7IlPZKBGwqX0loQzFJT9nKd52zv2orS6YbAaoMiQFcC4/hST4XoEAgwxZqVEP2/rtVXiJFR6t0HcxLwnhN5OHA/qANcfffTow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OrHiIb0t9wpSJuepS+AfcwUH5fMFksmaOWZGewePXb0=; b=DkB/FWvHmU84l/Uh6PGWaGXNof5UMslKhYR+w6sQdQEvOdsjXfyzC3zlfUQ+JK2zu7f990f1FXJE1xBCTfsoj76kn+COTIDQlH8Vp2QXAhoLWWG5C3puEeykCLQASVPYx+kvasM1TEFtJriElK2cYvH7O9hI9yEzhYSPgnLFhjgflNUkkTzJPWfhQmzaW4ryvKTv1XZIxFOojCV+s+VDb1JkdUJW6af3sk1u9Hub1McqiF/xYRgiegrW+iUvZZduh2riyyWp0YYPOpWQhZwgmBskwYCiRGP7xGkcq3j79Mt2exv3I0Kg/DJYNlfhfepnoV0bHHS8OA5t8uIV2dSb1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OrHiIb0t9wpSJuepS+AfcwUH5fMFksmaOWZGewePXb0=; b=mhYVUfHCREJgGA4WAJQAv6TrfHPn+kk12eaQOlc4LXfwqL/e3kxiXt75+xrdDciSA0ZRxorb9nnIQhDSPxza1ZUhE7o7V6OXstqUbhU9Y/JxUqAykRZHVPmVMZJq3MgsuhF8l8XnWmq64cDHjaxYDFc46+B9C+e4YeeNGyFiExZHNyBjlPp2++hR5sG8SsfxojWA4PzrnSVc9EKUTLtHj8T19r8Nwd6oaHdVDh5rFnOsJ++1kqfoQMrMZmBvPJsKAafhkx5XPJyqEIDkBRiqmdJWT8xhFz1B2KrEF+sFIZbSgeN2Z/qrnpAZvXArFHnEWlnIqU6c1RyGxiqY0Bjj5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by DU4PR04MB10958.eurprd04.prod.outlook.com (2603:10a6:10:581::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.19; Sat, 14 Jun 2025 12:54:29 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%6]) with mapi id 15.20.8835.026; Sat, 14 Jun 2025 12:54:28 +0000 From: Xu Yang To: peter.chen@kernel.org, gregkh@linuxfoundation.org, shawnguo@kernel.org, s.hauer@pengutronix.d, kernel@pengutronix.de, festevam@gmail.com Cc: jun.li@nxp.com, linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/3] implement workaround for ERR051725 Date: Sat, 14 Jun 2025 20:56:42 +0800 Message-Id: <20250614125645.207732-1-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR04CA0007.apcprd04.prod.outlook.com (2603:1096:4:197::19) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|DU4PR04MB10958:EE_ X-MS-Office365-Filtering-Correlation-Id: 712c9107-b91c-4043-51f8-08ddab429951 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: xqhEcnoCpGZyBz1oJDiR2toF+ho64tIna75vDk9gKeFXwajALXdesXLK7x4wIR3yZdJQ0QGZBkvcXfhiQfwdJjdZwOOzMluIOdRy6P9/rY/s1RGbyL0eubNLKyT+gJjx7Osn1qf57IuLY+IG7BT0QlZQ/o8YQzHGaqAycFvB1CffJFTguERgjEMH0JT3Nglq9E0rRMuwMfcKOAM0l4QKi6N+6Ot9UXFlGGrmllp2UGTqEEcuXp5D2Lpujf9PlORRnai1qRCqoFRfU/YFjnduRXvGJcQDhbEK8EC3JTJtQw6su7W4nvLCoQnRUNq6PmMjswJHz3W3tIZuLw8kXFIpYDB6T4iWbyROc2ddMdu6VAEVBhQXp9+tfafbezHhxxOyZZEjkzzMjEkEU6VQbtXI9n8pPkev4PdS8s8vWUjP+YBlLAdD07kWeXGm7vfEiZ59jmkJODWhV0CRgvkIKTF+iGturYIRnbHMGXrxajpuBuC07RW4vLSuNpNaLin8aCw9e05p0EUbLLvOScxPqBfi3Ic/+sWi/s+WKaTbWvW+SmwQ+eb922oF7Vz1J9d9g1hsYx3KXFhKV65ZFpcwwuLJi+ZjesAJ1LwWGnxyCdZzoCpUZoG3pbYEROT8jzUxx9JsAmt954IawYXqU3w1JXAOv4Bx3UhzKPsXn0jAMYxC5812afr1Ou5GBbhXE6FJ3ex2KqbD5VtJ8oDqpxtEHpRgAa59ivUwt36JmTEqH9AZSNQbTUiwNj6Lua2RQszgX2RUcUvyV5ZwTJ3m3hDhv+fniNseGzfBlNxANEfqLZilcavZyyn2dIpOx99vISl62I1G488a/Jdc12HFVcLqma3fkFlxh6NDFmz9mqLqUodNIVjx6Zj1lml29UfPvrJysoE9HyA3hqy0+u4QNcqclthutICj5egcy3NmXjvfBA9GbaOYwcBTL9iNYR5iITLOgZO0jbP6SZ6UEwg9xt0U/es7sWu2PfTE3lNSC9qdFTk8kfQObks8GjFvRx0N9dL76JP/b2hhQQROQI8An2QyUwBHSJ2ds7F5/PLdjIpco1VD4+jfftkydv+jKLiwN/5nevrAjzsBThxn7m11AMyBHs2o8eV7im8uV6xjjomJE2AGvXlCH+sez+C5YVvHd9ESG3b/2jgJGvRkSZ38xxRK1PCYxfUbM9uNUYXG9Tz9M70JpjEmFWoE6eL9oOFg3Mnq/zFKUdqC32ZyZCvV7T4ZgsrjyGw7+WHzuJQ3b79GuIyeOOQF4hWk3mNIr7aqkSrrbzIXXAXybuQEG+CvFwTySSJweBYN5yJmiAbwPqan9QdTZXClafdjFJOtucC+j28W33S/D84kf/tpxeLkAPlAMUv4aI4I96JUKzLmOtku/TsTWLfim5lXL4LKSg9XV/vuHGreDfSUbjJnEMzDLz7PB/K6E/BjiPFnXZbRZH0gCtz0+zfLSs7/41JBUbQVgUubTxQxzwBdv8Qv5cqOXJdKm1BD4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8822.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aKE/pcxoPa4xGLP++exgXtgDGi1/MIGuh05IJSFayPouubzEOl73lh5BnXaanJvCqZ60uJPUVf8Ew12dIwcaNuD/tn6umwj0WAZ4kE+crGh5G9UYshJKY4FfQytOZ6UZ5QuFNIeqp91hdDHDPIHp5qCrXkLDfhBk8bOOk7GXAdoAizE8ikKkswG2Pp0tR9Nu8/cqzHdIl7Xh1mAUQb/p16eMawk8kJbWF0Jv/f8mBYUI0EarUdGXLTGcDcoqq4BFDH09ih8EFukNoFizhqcrgi2y45+DKV4QLHAMtCQnuEmXB/y9OFhIEU4RvWtQ617ToQ7G959EkrCShPADpoC7yrgWjYa+hKd7dsnTbZxJasnI2rNQsrXFTdgrKAUIV52MLkRYwOZ1/gamM4P9Ja6/Pgp56n8Sz7yIkiKzoL/ULqdmMehYzYVJwOk5yyW5qMQjzLjUbdEB00Xa0VrUxcEFZ8nf9U8Zdnf+GSpr1Yh/D8zyFutWiNIUL9KnDxmkkdAc3OE+REd7e3O8bndRsaXTYNWx2WnrTR56/GDk7qjqFFCu+NgzTOsA2eiY74MoCy5CfnQeBqL6JJw/wdsMRv6zcDxQMm1nhURJGphSSqIB1j+7xFF2uAW2wHE0N++4naaopWHf7HKxJz3ZZLX6cIXI63owSRkw0MW16au/8WTZhGRHK+AiDvbRcpJ1Nktmv6DXDJK55J+PGaF1kGlhOZuRw9WPZaVhH5cKq1O8Nj8l6zjbgpyG/c+yLbZNHKP2wNC7ArtG3jKB17ZIUJ4ELpWPuLt1pHLQ/LfZoz1jx0KFwh3jLnIb4uPIWknFJfrq322RMLN5hp7WVNU1BGXNkWofv3xhU3g9avKlbwJy0vF0AAN8psOdr7yDIb/9i1jxN12JlAClpQ6sdsvcGZ2zRZn8WKCv4qcSVLiEXuEeckQ53qy/YKXyMxaaoBwp58In+K4yGeWexXyfJRJ6ionvWa2NrXE2NjDX4suBMsuzUJnzHnIi4QDh7wNOmgRz/2YSaqkPJOPZj+4NyDsUlmlPPZyH1tG63e6jc57blr1qNHSJ6WDtA8rEV8PV2/zEwycEH5Pnsrxq9mUZQvw2+xOVzjwy6c3U6usqRW3nT2gO8A5TlVkibbasHxFQjsSc5AYOKieBD9+JIPYOiflCLopHw+APMlK0THbKrIvjjxlCLHnYC3xIXhGm+dIgv8rhzOsBAJwRvr+dGFcP5ctasKAewQRS5fTulm1BK2nQiJmsw41sShe7Dn6QGbNdLemBGFzh3KTx9uqG0DHgA/DlECNWyVrpMR7V9GHFMQXD1YeFV650tCoeUB+zO+QNzzO5M8O1mnef6mDKprCRGOXM/3YxOrZj+mLLkOAPkCodDn4ZxjNdR5fwJYhrpAERWsh8zqbdqfPNzvt5yRZLb5f8bAU8w7li010bawfJkUnvuQN2N/KmMRMFFNLiI+0Wj4yqffyTcJH08tu48IfoC2lUR2DLOCUhtrU10uPHOtwKVZ9zRbH6j+OPo7jNdIqXlXVQqBJAnyvKjOPwnAGKKYXxAQ9igHMWzCkY2VTV/HeRmzQ8aDVJrqy/1vC1qacLbfBes8zRqKCn X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 712c9107-b91c-4043-51f8-08ddab429951 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2025 12:54:28.8798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bAxPKgnga3ZDDaygN40kfd/0vBbr3bavdZr14JKxhqaCJk1wIZ4Hvqp4DOa7tSX/OjYV7JvA946v3pKh/QqyMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10958 Currently, the USB2.0 phy on some imx7d compliant Soc has below issue. ERR051725: USB: With the USB controller configured as device mode, Clearing the RS bit of USBCMD register fails to cause USB device to be detached Description 1. USB controller working as high speed device mode with USB gadget function enabled 2. Cable plugged into USB host 3. Use case is software-controlled detach from USB device side The expected result is device side terminations removed, increase in USB signal amplitude, USB host detect device is detached. But the issue is that the clear RS bit of USBCMD register cannot cause device detach event. Workaround - Use the below steps to detach from the host: write USBCMD.RS = 0b write CTRL2[7:6] = 01b write CTRL2[8] = 1b - As CTRL2[8] is set at detach case, so attach the steps should add clear CTRL2[8]: write USBCMD.RS = 1b write CTRL2[8] = 0b This will add workaround for it. Xu Yang (3): usb: chipidea: udc: add CI_HDRC_CONTROLLER_PULLUP_EVENT event usb: chipidea: imx: add imx_usbmisc_pullup() hook usb: chipidea: imx: implement workaround for ERR051725 drivers/usb/chipidea/ci_hdrc_imx.c | 5 ++++ drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/udc.c | 5 ++++ drivers/usb/chipidea/usbmisc_imx.c | 39 ++++++++++++++++++++++++++++++ include/linux/usb/chipidea.h | 1 + 5 files changed, 51 insertions(+)