mbox series

[v2,0/2] usb: dwc3: gadget: Fix halt/clear_stall handling

Message ID cover.1599096763.git.thinhn@synopsys.com
Headers show
Series usb: dwc3: gadget: Fix halt/clear_stall handling | expand

Message

Thinh Nguyen Sept. 3, 2020, 1:42 a.m. UTC 
This series fixes a couple of driver issues handling ClearFeature(halt)
request:

1) A function driver often uses set_halt() to reject a class driver protocol
command. After set_halt(), the endpoint will be stalled. It can queue new
requests while the endpoint is stalled. However, dwc3 currently drops those
requests after CLEAR_STALL. The driver should only drop started requests. Keep
the pending requests in the pending list to resume and process them after the
host issues ClearFeature(Halt) to the endpoint.

2) DWC3 should issue CLEAR_STALL command _after_ END_TRANSFER command completes.

Changes in v2:
- Rebased on 5.9-rc3
- Remove a cleanup patch so this series can be merged to 5.9-rcX
- Account for wedged endpoint
- Account for CLEAR_FEATURE on stopped endpoints with pending requests
  (END_TRANSFER command won't be issued for stopped endpoints, so just kick
  pending request right after CLEAR_STALL)


Thinh Nguyen (2):
  usb: dwc3: gadget: Resume pending requests after CLEAR_STALL
  usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command

 drivers/usb/dwc3/core.h   |  1 +
 drivers/usb/dwc3/ep0.c    | 16 +++++++++++
 drivers/usb/dwc3/gadget.c | 56 ++++++++++++++++++++++++++++++---------
 drivers/usb/dwc3/gadget.h |  1 +
 4 files changed, 61 insertions(+), 13 deletions(-)


base-commit: f75aef392f869018f78cfedf3c320a6b3fcfda6b